commit 631a0382a26d3f3dc72b8496f1861732919f7cff
author Tanguy Pruvot <tanguy.pruvot@gmail.com> Thu Jun 07 00:04:54 2012 +0200
committer Andrew Sutherland <dr3wsuth3rland@gmail.com> Wed Nov 14 13:41:19 2012 -0600
tree 72d38ae6271928f0f4adc6459efd70b4c0000ed3
parent 82932ef364d9102caf4f2533779adfdb0345be22

getopt(): fix missing carriage return on bad parameters

This affect all command line tools which show the usage on stdout
after an invalid parameter error (printed on stderr)

Change-Id: I8e2cb3fda241ab989dc42055f15082f8b3ba1397
Signed-off-by: Tanguy Pruvot <tanguy.pruvot@gmail.com>

libc/unistd/getopt_long.c

diff --git a/libc/unistd/getopt_long.c b/libc/unistd/getopt_long.c
index dbdf01a..0b8181a 100644
--- a/libc/unistd/getopt_long.c
+++ b/libc/unistd/getopt_long.c
@@ -100,12 +100,12 @@
 static int nonopt_end = -1;   /* first option after non options (for permute) */
 
 /* Error messages */
-static const char recargchar[] = "option requires an argument -- %c";
-static const char recargstring[] = "option requires an argument -- %s";
-static const char ambig[] = "ambiguous option -- %.*s";
-static const char noarg[] = "option doesn't take an argument -- %.*s";
-static const char illoptchar[] = "unknown option -- %c";
-static const char illoptstring[] = "unknown option -- %s";
+static const char recargchar[] = "option requires an argument -- %c\n";
+static const char recargstring[] = "option requires an argument -- %s\n";
+static const char ambig[] = "ambiguous option -- %.*s\n";
+static const char noarg[] = "option doesn't take an argument -- %.*s\n";
+static const char illoptchar[] = "unknown option -- %c\n";
+static const char illoptstring[] = "unknown option -- %s\n";
 
 /*
  * Compute the greatest common divisor of a and b.