commit 79abce42146b27d523f309e0a1bc9f50175191cb
author Dimitry Ivanov <dimitry@google.com> Wed Apr 13 11:46:59 2016 -0700
committer Dimitry Ivanov <dimitry@google.com> Wed Apr 13 11:46:59 2016 -0700
tree c78e7b727d35e83e57d266b0013ef9002c8c2868
parent 8e3a3fb4f2b7b5183c00e299e9ab17fffced1124

linker: unload RTLD_NODELETE libraries when loading fails

Linker was not unloading libraries marked with RTLD_NODELETE
even when there was a error on load. For example when one of
dt_needed libraries was not found.

Bug: http://b/27911891
Change-Id: Ibc0bf110aa41fbfdc9f327ad8c364f2e3600af71

linker/linker.cpp

diff --git a/linker/linker.cpp b/linker/linker.cpp
index dfa3d21..a4dae3e 100644
--- a/linker/linker.cpp
+++ b/linker/linker.cpp
@@ -3322,7 +3322,7 @@
 }
 
 bool soinfo::can_unload() const {
-  return (get_rtld_flags() & (RTLD_NODELETE | RTLD_GLOBAL)) == 0;
+  return !is_linked() || ((get_rtld_flags() & (RTLD_NODELETE | RTLD_GLOBAL)) == 0);
 }
 
 bool soinfo::is_linked() const {