commit 7b77cb35aff34ff56a0b63517267c6203f9d1119
author Elliott Hughes <enh@google.com> Fri Oct 09 17:27:41 2015 -0700
committer Elliott Hughes <enh@google.com> Fri Oct 09 17:36:05 2015 -0700
tree d81082b185a13a6b9c71be9379cd131ed7082f56
parent 487a1823e8617011009eded8eae9a75c1f871887

Fix inet_aton on LP32.

I wasn't checking for overflow. Luckily, I had a test that overflows on LP32.

Change-Id: If2cf33d88f459eb26d0ce75f3c5ed192f516ab7a

libc/bionic/arpa_inet.cpp

diff --git a/libc/bionic/arpa_inet.cpp b/libc/bionic/arpa_inet.cpp
index 260d6a0..9d4afe3 100644
--- a/libc/bionic/arpa_inet.cpp
+++ b/libc/bionic/arpa_inet.cpp
@@ -39,8 +39,9 @@
   size_t i;
   for (i = 0; i < 4; ++i) {
     char* end;
+    errno = 0;
     parts[i] = strtoul(cp, &end, 0);
-    if (end == cp || (*end != '.' && *end != '\0')) return 0;
+    if (errno != 0 || end == cp || (*end != '.' && *end != '\0')) return 0;
     if (*end == '\0') break;
     cp = end + 1;
   }

tests/arpa_inet_test.cpp

diff --git a/tests/arpa_inet_test.cpp b/tests/arpa_inet_test.cpp
index 8ba0d7a..a368b8f 100644
--- a/tests/arpa_inet_test.cpp
+++ b/tests/arpa_inet_test.cpp
@@ -98,7 +98,11 @@
   // Out of range a form.
   ASSERT_EQ(0, inet_aton("0x100000000", nullptr));
 
-  ASSERT_EQ(0, inet_aton("0400.0.0.1", nullptr)); // Out of range octal.
+  // 64-bit overflow.
+  ASSERT_EQ(0, inet_aton("0x10000000000000000", nullptr));
+
+  // Out of range octal.
+  ASSERT_EQ(0, inet_aton("0400.0.0.1", nullptr));
 }
 
 TEST(arpa_inet, inet_lnaof) {