)]}' { "log": [ { "commit": "4956c372cf320328952665629b2626e7cbc84c54", "tree": "7a02304c6c2eadc93b1b7a357fb31a143b661a89", "parents": [ "e592dacfa254f59bb097c98d118d0c860b181da1" ], "author": { "name": "Josh Gao", "email": "jmgao@google.com", "time": "Thu Dec 19 16:35:51 2019 -0800" }, "committer": { "name": "Josh Gao", "email": "jmgao@google.com", "time": "Thu Jan 02 14:09:50 2020 -0800" }, "message": "Move bionic_macros.h from private to platform.\n\nTest: treehugger\nChange-Id: Ie473914f4c8924c7240b3ac22093a9daf42fc948\n" }, { "commit": "b233fab925ca9b8370e83c2577610b26cb143619", "tree": "c769a8eaf1e5fbb4e32c437d82f2433b65a6668e", "parents": [ "0c499a69e3d8b858f53a7410285416c0cb30f83b" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue Dec 18 16:44:42 2018 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue Dec 18 17:45:46 2018 -0800" }, "message": "Fix handling of libs with a ro map and a rx map.\n\nWhen the linker was changed so that it put a read-only map and\nread-execute map, this code incorrectly computed the relative pc and\noffset. Modify to look for the actual start map in this case.\n\nAlso, change the load_base name to load_bias.\n\nBug: 120613266\n\nTest: Dumped logcat while dumping backtraces.\n\nChange-Id: I6628694c5222ea34d63217af3d138707d4900004\n" }, { "commit": "5e62b34c0d6fa545b487b9b64fb4a04a0589bc13", "tree": "e08ee44067b3b636ace11b21ec8d63a08d4d2a19", "parents": [ "c89a3971e94c30611c885e4c440eae2fd9937948" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Oct 25 11:00:00 2018 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Oct 25 11:00:00 2018 -0700" }, "message": "Clean up bionic_macros.h a bit.\n\nUse \u003candroid-base/macros.h\u003e instead where possible, and move the bionic\nmacros out of the way of the libbase ones. Yes, there are folks who manage\nto end up with both included at once (thanks OpenGL!), and cleaning that\nup doesn\u0027t seem nearly as practical as just making this change.\n\nBug: N/A\nTest: builds\nChange-Id: I23fc544f39d5addf81dc61471771a5438778895b\n" }, { "commit": "4da2503d70dc4bc1444454876e3794b69227d90d", "tree": "d904c750ebac96aee76df44baad1320c0db211a3", "parents": [ "a3f6f6c1b9135c90e410f5382b153db9a43a4db0" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Mar 07 13:38:48 2018 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Apr 02 18:59:23 2018 -0700" }, "message": "Refactor malloc debug.\n\nChanges\n- Refactor the code so that only guards require creating a special header\n for every pointer allocated.\n- Store only a single copy of every backtrace. This saves memory so that\n turning on the backtrace option doesn\u0027t result in 10X memory usage.\n- Added new option track_allocs that only verifies pointers are valid for\n free/malloc_usable_size/realloc.\n- Remove suffix from test names.\n- Add the TRACK_ALLOCS options to all guard options.\n- Add new option verify_pointers that is a lightweight way to verify\n pointers that are passed to allocation routines.\n- Do auto-formatting of the code.\n- Updated documentation for all of these changes.\n\nBug: 74361929\n\nTest: Ran unit tests.\nTest: Ran libmemunreachable unit tests.\nTest: Ran an app with backtrace enabled.\n\nChange-Id: I3246c48ae4f9811f64622d90d0a9b4d9d818702c\n" }, { "commit": "cbc80ba9d839675a0c4891e2ab33f39ba51b04b2", "tree": "0b24e6123c94bd3e61d94fd6eca6a3b9cc9b074e", "parents": [ "3374d0cabb973ff2b73ad8cd909389bdeed18658" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Feb 13 14:26:29 2018 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Feb 13 14:27:17 2018 -0800" }, "message": "Switch the rest of our internal headers to #pragma once.\n\nWe\u0027ve been using #pragma once for new internal files, but let\u0027s be more bold.\n\nBug: N/A\nTest: builds\nChange-Id: I7e2ee2730043bd884f9571cdbd8b524043030c07\n" }, { "commit": "5cec377f49d6429b19895eb632225cd757ea611e", "tree": "bcd08fe1e6b656a5a4e235a225fbe88feb54a112", "parents": [ "0d63a3c233040af004cc470d5f76547f3adc0148" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Jan 19 15:45:23 2018 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Jan 19 15:56:12 2018 -0800" }, "message": "Address a bunch of clang-tidy complaints.\n\nThere were a bunch more unreasonable/incorrect ones, but these ones\nseemed legit. Nothing very interesting, though.\n\nBug: N/A\nTest: ran tests, benchmarks\nChange-Id: If66971194d4a7b4bf6d0251bedb88e8cdc88a76f\n" }, { "commit": "d75d4bea54a788dada3f2538a33cc491e4c56ed4", "tree": "2afb4a19e32539b11eda85948225ef456b4cf638", "parents": [ "2c75991359df165ca7cc7a6213fb227c0b5ed87c" ], "author": { "name": "Colin Cross", "email": "ccross@android.com", "time": "Mon Feb 08 14:29:03 2016 -0800" }, "committer": { "name": "Colin Cross", "email": "ccross@android.com", "time": "Thu Feb 18 16:09:17 2016 -0800" }, "message": "malloc_debug: reread /proc/pid/maps when entry is missing\n\nReread /proc/pid/maps on demand in case a new library has been loaded.\n\nChange-Id: Iac8109b3e6a07bf02c38300b21eecabf4bcd54df\n" }, { "commit": "63860cb8fd1adf3f679b9b4ad876323a8d65cd9d", "tree": "25aeae686d92efcb5e08a54e8cba1e8c31efe33b", "parents": [ "ad9c3f34f762ed45cce5dbb93218124ed31f6873" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Nov 16 17:30:32 2015 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Jan 25 10:54:21 2016 -0800" }, "message": "Malloc debug rewrite.\n\nThe major components of the rewrite:\n\n- Completely remove the qemu shared library code. Nobody was using it\n and it appears to have broken at some point.\n- Adds the ability to enable/disable different options independently.\n- Adds a new option that can enable the backtrace on alloc/free when\n a process gets a specific signal.\n- Adds a new way to enable malloc debug. If a special property is\n set, and the process has an environment variable set, then debug\n malloc will be enabled. This allows something that might be\n a derivative of app_process to be started with an environment variable\n being enabled.\n- get_malloc_leak_info() used to return one element for each pointer that\n had the exact same backtrace. The new version returns information for\n every one of the pointers with same backtrace. It turns out ddms already\n automatically coalesces these, so the old method simply hid the fact\n that there where multiple pointers with the same amount of backtrace.\n- Moved all of the malloc debug specific code into the library.\n Nothing related to the malloc debug data structures remains in libc.\n- Removed the calls to the debug malloc cleanup routine. Instead, I\n added an atexit call with the debug malloc cleanup routine. This gets\n around most problems related to the timing of doing the cleanup.\n\nThe new properties and environment variables:\n\nlibc.debug.malloc.options\n Set by option name (such as \"backtrace\"). Setting this to a bad value\n will cause a usage statement to be printed to the log.\n\nlibc.debug.malloc.program\n Same as before. If this is set, then only the program named will\n be launched with malloc debug enabled. This is not a complete match,\n but if any part of the property is in the program name, malloc debug is\n enabled.\n\nlibc.debug.malloc.env_enabled\n If set, then malloc debug is only enabled if the running process has the\n environment variable LIBC_DEBUG_MALLOC_ENABLE set.\n\nBug: 19145921\n\nChange-Id: I7b0e58cc85cc6d4118173fe1f8627a391b64c0d7\n" }, { "commit": "70b6e1daffd58ebce006d4b504cd0fb9672b6d07", "tree": "8996cc437814eb0b7c9074809b8bab14d53007cf", "parents": [ "cd588f847f3f23a9c60e32ab1e37c170e9f5be57" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Thu Jul 16 14:49:17 2015 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Thu Jul 16 15:25:39 2015 -0700" }, "message": "Add support for non-zero vaddr in maps.\n\nIf a map has a non-zero vaddr then it needs to be added to the\ncomputed relative offset.\n\nBug: 22532054\nChange-Id: If55015165d25ecc4b530f674b481c8c7ef760a23\n" }, { "commit": "861c0ef37bcfcae56d88572cb01c18bcfe1faded", "tree": "f63fc703a50b23213537962e4f60519f8b34db47", "parents": [ "a7dc7600fe1be1f3fd61856b407bb7065307e711" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Thu Jul 24 17:52:23 2014 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue Jul 29 18:10:00 2014 -0700" }, "message": "Use libunwindbacktrace for debug malloc code.\n\nCreate a method of disabling the debug allocation code paths so that\nit\u0027s possible to use the libunwindbacktrace library without any\nmodifications.\n\nUse this path to create and destroy the maps for the process. It\u0027s not\nstricly necessary in the init code since the symbols are not modified\nuntil after the initialize calls.\n\nAlso, remove the debug_XXX source files that doesn\u0027t need to be in libc.so.\n\nFix the maps reading code since it was completely broken for 64 bit.\n\nBug: 16408686\n\nChange-Id: I6b02ef6ce26fdb7a59ad1029e7cbba9accceb704\n" }, { "commit": "35b621c5f4c79959cd36fec0153c2c9c43ebe5f0", "tree": "016d232e99a12943587357bf8b10a3d25cb98b0e", "parents": [ "a0151cbfbaa37965dbcd188a55a78d3ad4802b9b" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Jan 28 16:27:36 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Jan 29 09:56:31 2013 -0800" }, "message": "Don\u0027t collect useless stack frames; do demangle C++ symbols.\n\nPreviously, we\u0027d collect every stack frame and then throw some away\nwhen we came to log them. This meant that stack traces were effectively\nshorter than the buffers that had been allocated for them. This patch\nonly stores frames we\u0027ll actually output.\n\nAlso dynamically call the C++ demangler so we don\u0027t have to try to\nread mangled names. Because no one knows the mangling of operator new[]\nfor int arrays off the top of their head.\n\nBug: 7291287\nChange-Id: I42b022fd7cd61675d05171de4c3b2704d058ef2a\n" }, { "commit": "1e980b6bc8315d00a07312b25486531247abd98c", "tree": "539f2c0c63fca27d5eb6ba184d658bb0e11a32d9", "parents": [ "e4ca88d9fa8757e4fb4056fcafa5bc15b406a2fd" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Jan 17 18:36:06 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Jan 18 22:20:06 2013 -0800" }, "message": "Fix the duplication in the debugging code.\n\nWe had two copies of the backtrace code, and two copies of the\nlibcorkscrew /proc/pid/maps code. This patch gets us down to one.\n\nWe also had hacks so we could log in the malloc debugging code.\nThis patch pulls the non-allocating \"printf\" code out of the\ndynamic linker so everyone can share.\n\nThis patch also makes the leak diagnostics easier to read, and\nmakes it possible to paste them directly into the \u0027stack\u0027 tool (by\nusing relative PCs).\n\nThis patch also fixes the stdio standard stream leak that was\ncausing a leak warning every time tf_daemon ran.\n\nBug: 7291287\nChange-Id: I66e4083ac2c5606c8d2737cb45c8ac8a32c7cfe8\n" }, { "commit": "c4d1fecc105063e68a5090a6900b63d1b9a24287", "tree": "93dad687b245a981d3c47ede05b43345b86202fe", "parents": [ "9dfaa63a1c0d1b8e75dd9d7077a8103a19821fa9" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Aug 28 14:15:04 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Aug 29 12:08:13 2012 -0700" }, "message": "Clean up warnings in the malloc_debug_* files.\n\nAlso clean up cpplint.py-detected lint.\n\nChange-Id: Ia18e89c4c6878764f8d7ed34b8247e7a8d8fe88b\n" }, { "commit": "e1dd3c287ba836281de0197670018bd9bbfbd62b", "tree": "a5138cb21c8de6be4ea4be61e44f95fb8bcb776e", "parents": [ "7d2e24eb167b6257f7935c7bd2023a708704ca1a" ], "author": { "name": "Iliyan Malchev", "email": "malchev@google.com", "time": "Tue May 29 14:22:42 2012 -0700" }, "committer": { "name": "Iliyan Malchev", "email": "malchev@google.com", "time": "Fri Jun 01 15:54:34 2012 -0700" }, "message": "bionic: import heaptracker as chk_malloc\n\nThis patch is a rewrite of libc.debug.malloc \u003d 10 (chk_malloc). It provides\nthe same features as the original (poison freed memory, detect heap overruns\nand underruns), except that it provides more debugging information whenever it\ndetects a problem.\n\nIn addition to the original features, the new chk_malloc() implementation\ndetects multiple frees within a given range of the last N allocations, N being\nconfigurable via the system property libc.debug.malloc.backlog.\n\nFinally, this patch keeps track of all outstanding memory allocations. On\nprogram exit, we walk that list and report each outstanding allocation.\n\n(There is support (not enabled) for a scanner thread periodically walks over\nthe list of outstanding allocations as well as the backlog of recently-freed\nallocations, checking for heap-usage errors.)\n\nFeature overview:\n\n 1) memory leaks\n 2) multiple frees\n 3) use after free\n 4) overrun\n\nImplementation:\n\n-- for each allocation, there is a:\n 1) stack trace at the time the allocation is made\n 2) if the memory is freed, there is also a stack trace at the point\n 3) a front and rear guard (fence)\n 4) the stack traces are kept together with the allocation\n\n-- the following lists and maintained\n\n 1) all outstanding memory allocations\n 3) a backlog of allocations what are freed; when you call free(), instead of\n actually freed, the allocation is moved to this backlog;\n 4) when the backlog of allocations gets full, the oldest entry gets evicted\n from it; at that point, the allocation is checked for overruns or\n use-after-free errors, and then actually freed.\n 5) when the program exits, the list of outstanding allocations and the\n backlog are inspected for errors, then freed;\n\nTo use this, set the following system properties before running the process or\nprocesses you want to inspect:\n\nlibc.malloc.debug.backlog # defaults to 100\nlibc.malloc.debug 10\n\nWhen a problem is detected, you will see the following on logcat for a multiple\nfree:\n\nE/libc ( 7233): +++ ALLOCATION 0x404b9278 SIZE 10 BYTES MULTIPLY FREED!\nE/libc ( 7233): +++ ALLOCATION 0x404b9278 SIZE 10 ALLOCATED HERE:\nE/libc ( 7233): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***\nE/libc ( 7233): #00 pc 0000c35a /system/lib/libc_malloc_debug_leak.so\nE/libc ( 7233): #01 pc 0000c658 /system/lib/libc_malloc_debug_leak.so\nE/libc ( 7233): #02 pc 00016d80 /system/lib/libc.so\nE/libc ( 7233): #03 pc 4009647c /system/bin/malloctest\nE/libc ( 7233): #04 pc 00016f24 /system/lib/libc.so\nE/libc ( 7233): +++ ALLOCATION 0x404b9278 SIZE 10 FIRST FREED HERE:\nE/libc ( 7233): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***\nE/libc ( 7233): #00 pc 0000c35a /system/lib/libc_malloc_debug_leak.so\nE/libc ( 7233): #01 pc 0000c7d2 /system/lib/libc_malloc_debug_leak.so\nE/libc ( 7233): #02 pc 00016d94 /system/lib/libc.so\nE/libc ( 7233): #03 pc 40096490 /system/bin/malloctest\nE/libc ( 7233): #04 pc 00016f24 /system/lib/libc.so\nE/libc ( 7233): +++ ALLOCATION 0x404b9278 SIZE 10 NOW BEING FREED HERE:\nE/libc ( 7233): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***\nE/libc ( 7233): #00 pc 0000c35a /system/lib/libc_malloc_debug_leak.so\nE/libc ( 7233): #01 pc 0000c6ac /system/lib/libc_malloc_debug_leak.so\nE/libc ( 7233): #02 pc 00016d94 /system/lib/libc.so\nE/libc ( 7233): #03 pc 400964a0 /system/bin/malloctest\nE/libc ( 7233): #04 pc 00016f24 /system/lib/libc.so\n\nThe following for a heap overrun and underrun:\n\nE/libc ( 7233): +++ REAR GUARD MISMATCH [10, 11)\nE/libc ( 7233): +++ ALLOCATION 0x404b9198 SIZE 10 HAS A CORRUPTED REAR GUARD\nE/libc ( 7233): +++ ALLOCATION 0x404b9198 SIZE 10 ALLOCATED HERE:\nE/libc ( 7233): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***\nE/libc ( 7233): #00 pc 0000c35a /system/lib/libc_malloc_debug_leak.so\nE/libc ( 7233): #01 pc 0000c658 /system/lib/libc_malloc_debug_leak.so\nE/libc ( 7233): #02 pc 00016d80 /system/lib/libc.so\nE/libc ( 7233): #03 pc 40096438 /system/bin/malloctest\nE/libc ( 7233): #04 pc 00016f24 /system/lib/libc.so\nE/libc ( 7233): +++ ALLOCATION 0x404b9198 SIZE 10 FREED HERE:\nE/libc ( 7233): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***\nE/libc ( 7233): #00 pc 0000c35a /system/lib/libc_malloc_debug_leak.so\nE/libc ( 7233): #01 pc 0000c7d2 /system/lib/libc_malloc_debug_leak.so\nE/libc ( 7233): #02 pc 00016d94 /system/lib/libc.so\nE/libc ( 7233): #03 pc 40096462 /system/bin/malloctest\nE/libc ( 7233): #04 pc 00016f24 /system/lib/libc.so\nE/libc ( 7233): +++ ALLOCATION 0x404b9358 SIZE 10 HAS A CORRUPTED FRONT GUARD\nE/libc ( 7233): +++ ALLOCATION 0x404b9358 SIZE 10 ALLOCATED HERE:\nE/libc ( 7233): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***\nE/libc ( 7233): #00 pc 0000c35a /system/lib/libc_malloc_debug_leak.so\nE/libc ( 7233): #01 pc 0000c658 /system/lib/libc_malloc_debug_leak.so\nE/libc ( 7233): #02 pc 00016d80 /system/lib/libc.so\nE/libc ( 7233): #03 pc 400964ba /system/bin/malloctest\nE/libc ( 7233): #04 pc 00016f24 /system/lib/libc.so\nE/libc ( 7233): +++ ALLOCATION 0x404b9358 SIZE 10 FREED HERE:\nE/libc ( 7233): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***\nE/libc ( 7233): #00 pc 0000c35a /system/lib/libc_malloc_debug_leak.so\nE/libc ( 7233): #01 pc 0000c7d2 /system/lib/libc_malloc_debug_leak.so\nE/libc ( 7233): #02 pc 00016d94 /system/lib/libc.so\nE/libc ( 7233): #03 pc 400964e4 /system/bin/malloctest\nE/libc ( 7233): #04 pc 00016f24 /system/lib/libc.so\n\nThe following for a memory leak:\n\nE/libc ( 7233): +++ THERE ARE 1 LEAKED ALLOCATIONS\nE/libc ( 7233): +++ DELETING 4096 BYTES OF LEAKED MEMORY AT 0x404b95e8 (1 REMAINING)\nE/libc ( 7233): +++ ALLOCATION 0x404b95e8 SIZE 4096 ALLOCATED HERE:\nE/libc ( 7233): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***\nE/libc ( 7233): #00 pc 0000c35a /system/lib/libc_malloc_debug_leak.so\nE/libc ( 7233): #01 pc 0000c658 /system/lib/libc_malloc_debug_leak.so\nE/libc ( 7233): #02 pc 00016d80 /system/lib/libc.so\nE/libc ( 7233): #03 pc 0001bc94 /system/lib/libc.so\nE/libc ( 7233): #04 pc 0001edf6 /system/lib/libc.so\nE/libc ( 7233): #05 pc 0001b80a /system/lib/libc.so\nE/libc ( 7233): #06 pc 0001c086 /system/lib/libc.so\nE/libc ( 7233): #07 pc 40096402 /system/bin/malloctest\nE/libc ( 7233): #08 pc 00016f24 /system/lib/libc.so\n\nChange-Id: Ic440e9d05a01e2ea86b25e8998714e88bc2d16e0\nSigned-off-by: Iliyan Malchev \u003cmalchev@google.com\u003e\n" } ] }