)]}' { "log": [ { "commit": "9bf7817dd29d15ea49c88436db4067d87fc7e6c4", "tree": "83df3be7fc9aa5b879d22b9db6361baf7c83c17f", "parents": [ "ba198d508497ffeb146d61c5ec5fb66d84e864f3" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed May 20 15:37:30 2020 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed May 20 18:18:54 2020 -0700" }, "message": "Fix deadlock/timeout in thread unwinding.\n\nWhen malloc debug is enabled, using libbacktrace to unwind can\nresult in a deadlock. This happens when an unwind of a thread\nis occuring which triggers a signal to be sent to that thread. If\nthat thread is interrupted while a malloc debug function is\nexecuting and owns a lock, that thread is then stuck in the signal\nhandler. Then the original unwinding thread attempts to do an\nallocation and gets stuck waiting for the same malloc debug lock.\n\nThis is not a complete deadlock since the unwinder has timeouts,\nbut it results in truncated unwinds that take at least five\nseconds to complete.\n\nOnly the backtrace signals needs to be blocked because it is the only\nknown signal that will result in a thread being paused in a signal\nhandler.\n\nAlso, added a named signal in the reserved signal list for the\nspecial bionic backtrace signal.\n\nBug: 150833265\n\nTest: New unit tests pass with fix, fail without fix.\nChange-Id: If3e41f092ebd40ce62a59ef51d636a91bc31ed80\n" }, { "commit": "ad9e99dad70dabeaf877feaeb4812851216ba0d9", "tree": "f2c1b0aecc9409d5f03e43efd5b8268a97ddca96", "parents": [ "19377a55c5fedd917019ac38382c0e921b8ce09d" ], "author": { "name": "Tom Cherry", "email": "tomcherry@google.com", "time": "Wed Apr 22 19:00:42 2020 -0700" }, "committer": { "name": "Tom Cherry", "email": "tomcherry@google.com", "time": "Wed Apr 22 19:00:42 2020 -0700" }, "message": "Include log/log_read.h for reading logs\n\nlog/log.h is concerned with writing logs.\n\nBug: 78370064\nTest: build\nChange-Id: I03d35f47acaa6eb0c8865836767d855be0203e92\n" }, { "commit": "1995d74baa158dad4b034d732707d141453b4aff", "tree": "85a2f6f02fe17fb9c61fa4eb479d9aca3056648c", "parents": [ "8d1849930f10e6b1a6b9c5885def5a08cee44040" ], "author": { "name": "Tom Cherry", "email": "tomcherry@google.com", "time": "Mon Mar 23 13:41:06 2020 -0700" }, "committer": { "name": "Tom Cherry", "email": "tomcherry@google.com", "time": "Mon Mar 23 13:41:06 2020 -0700" }, "message": "Remove ANDROID_LOG_RDONLY\n\nThis macro hasn\u0027t been meaningful in years.\n\nTest: logging unit tests\nChange-Id: I849a466052524c24f1dba585a6423e80198c6b9c\n" }, { "commit": "00a131f387e7cde76c30bd3fbbd81ab5d86adf49", "tree": "f6a3a587f5282fa417b3f08a87741bdbc17db71f", "parents": [ "96fbba1ea07c1496c3fbde86b19b935badc74084" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Jan 22 23:23:17 2020 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Jan 22 23:29:43 2020 -0800" }, "message": "Update for change MapInfo constructor.\n\nBug: 148075852\n\nTest: Ran unit tests.\nChange-Id: I8326d8db9887e2bba26d6d94786a72c49edc5d21\n" }, { "commit": "4956c372cf320328952665629b2626e7cbc84c54", "tree": "7a02304c6c2eadc93b1b7a357fb31a143b661a89", "parents": [ "e592dacfa254f59bb097c98d118d0c860b181da1" ], "author": { "name": "Josh Gao", "email": "jmgao@google.com", "time": "Thu Dec 19 16:35:51 2019 -0800" }, "committer": { "name": "Josh Gao", "email": "jmgao@google.com", "time": "Thu Jan 02 14:09:50 2020 -0800" }, "message": "Move bionic_macros.h from private to platform.\n\nTest: treehugger\nChange-Id: Ie473914f4c8924c7240b3ac22093a9daf42fc948\n" }, { "commit": "e4619f771984064da861a1be17de53132542dade", "tree": "2a9d64631584bf725571225d1ee34cf0fdf5b04d", "parents": [ "17dfa33200f8b72e3bf96271f590e2fd7db10529" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Nov 11 14:17:44 2019 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Fri Nov 15 14:19:33 2019 -0800" }, "message": "Add automatic running of tests on bionic changes.\n\nmalloc debug and malloc hooks have been broken for a long time\nand no one noticed. So add them to be run by default on bionic\nchanges since that provides the most coverage.\n\nChange the malloc debug and malloc hooks tests to support isolated\nruns.\n\nChanged the name of the malloc hooks unit tests to system tests\nbecause they weren\u0027t really unit tests.\n\nChanged the verify leak malloc debug tests to print out extra\ninformation so it is possible to figure out what sized allocation\nfailed.\n\nTest: Ran tests.\nChange-Id: Idea4c864f1d62598148ee78d7c9397e45234b1ca\n" }, { "commit": "ff88fb0d3adbc67a4f94f5ef7e2b5bcc7a96c8f3", "tree": "1a78e188d9e51383579f697cb5532846b841cd69", "parents": [ "1994f28be2c0faf2b70b1ca8fff7d8d2fa68d922" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Nov 04 18:40:00 2019 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Nov 06 10:42:42 2019 -0800" }, "message": "Fix allocations escaping malloc debug.\n\nWhen using a FILE object for some malloc debug functions, calling\nfprintf will trigger an allocation to be put in the object. The problem\nis that these allocations were not allocated by the malloc debug\nwrapper and they get freed during the fclose as if they are malloc\ndebug allocation. In most cases, the code will detect the bad pointer\nand leak the memory, but it might also cause a crash.\n\nThe fix is to avoid using fprintf so that no allocations are made\nin the object that survive and need to be freed in the fclose call.\n\nChange the MallocXmlElem.h to use a file decsriptor not a FILE object.\n\nAdd new unit and system tests to detect this case.\n\nBug: 143742907\n\nTest: Ran unit and system tests.\nTest: Ran bionic unit tests.\nChange-Id: I524392de822a29483aa5be8f14c680e70033eba2\n" }, { "commit": "2b0638ef29bb305f8a37c16c706fb0ee80a994c0", "tree": "bea668f7605903876618505b7aec795da94ea4ae", "parents": [ "1ffee0cfc1e3a7fddf4cbe633694be91e72265a1" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Sep 11 19:05:29 2019 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Sep 16 12:27:33 2019 -0700" }, "message": "Make bionic_malloc.h a platform header.\n\nInstead of having platform directories directly include the\nprivate header, create a platform header directory and export it.\n\nBug: 130763340\n\nTest: Builds.\nChange-Id: Ie0f092b3fe077a3de8b90266c0b28bfbc20d0dfa\nMerged-In: Ie0f092b3fe077a3de8b90266c0b28bfbc20d0dfa\n(cherry picked from commit 8f582ef2f8a77d953d0e9f33387f592d20f852e2)\n" }, { "commit": "d269fcc935b276502b9e47a575d76693fe1b8455", "tree": "cb9e09297fb247d3d8511565e25a930336b6bc72", "parents": [ "9433a0299e2493303776713072f0744d18c705dc" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon May 06 19:03:59 2019 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue May 07 13:16:58 2019 -0700" }, "message": "Avoid using malloc debug code after exit.\n\nI wrote a new unit test that would fail on the old version of the\ncode.\n\nOn a walleye big cpu, this costs about 40ns-50ns (going from ~430ns to ~480ns).\nI think this is an acceptable performance degradation.\n\nBug: 131867816\n\nTest: New unit tests pass.\nChange-Id: I4c0f4373fb0694bf29c3824dbb1224a8a17e211e\n" }, { "commit": "8189e77bbb47dbaa1a09d565c62c2fed03e358c3", "tree": "2c8fc5d8fd1ec1ab881d35519670104ad86283e3", "parents": [ "b9a7c651f178323e27752406f89d741cfb143e61" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue Apr 09 16:37:23 2019 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue Apr 16 11:22:06 2019 -0700" }, "message": "Remove gMallocLeakZygoteChild.\n\nRemove this global variable and change the setting of it to non-zero\nto a call to android_mallopt.\n\nIn addition, change the initialize function to use pass a bool* instead of\nint*.\n\nBug: 130028357\n\nTest: Ran malloc_debug/malloc_hooks/perfetto tests.\nChange-Id: I20d382bdeaaf38aac6b9dcabea5b3dfab3c945f6\nMerged-In: I20d382bdeaaf38aac6b9dcabea5b3dfab3c945f6\n(cherry picked from commit 5225b342f0810c027df3d09fbbcef4d324b19b93)\n" }, { "commit": "c328e4465d12d760f5fbcb2daddf5fa4138f50b1", "tree": "fd91c386332bbe1198cb0bedc11505b76d146057", "parents": [ "4699cf61746d37fc11c8eb8bdfc7eb296a476e4b" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Apr 01 19:31:26 2019 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue Apr 02 10:55:21 2019 -0700" }, "message": "Disable info messages by default for malloc debug.\n\nAdd a new option verbose for malloc debug that is not enabled by default.\nThis disables all of the info log messages. It turns out these log\nmessages can add a measurable amount of time and can change the boot up.\n\nBug: 129239269\n\nTest: Adjusted unit tests pass.\nTest: Verified no messages unless verbose option used.\nChange-Id: I805cb7c8ecb44de88119574e59d784877cacc383\n" }, { "commit": "1fc5ccfe762f4cf2322a53215934492003dae49e", "tree": "b07af2f8b2466d0a7210b2aaacd97af5fe70efbd", "parents": [ "ac74615c1c3638d33448f0f6995fb8bc9599f062" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Fri Feb 15 18:06:15 2019 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Fri Mar 15 10:54:55 2019 -0700" }, "message": "Add a platform API for setting an allocation limit.\n\nIntroduce an M_SET_ALLOCATION_LIMIT enumerator for android_mallopt(),\nwhich can be used to set an upper bound on the total size of all\nallocations made using the memory allocation APIs.\n\nThis is useful for programs such as audioextractor and mediaserver\nwhich need to set such a limit as a security mitigation. Currently\nthese programs are using setrlimit(RLIMIT_AS) which isn\u0027t exactly\nwhat these programs want to control. RLIMIT_AS is also problematic\nunder sanitizers which allocate large amounts of address space as\nshadow memory, and is especially problematic under shadow call stack,\nwhich requires 16MB of address space per thread.\n\nAdd new unit tests for bionic.\n\nAdd new unit tests for malloc debug that verify that when the limit\nis enabled, malloc debug still functions for nearly every allocation\nfunction.\n\nBug: 118642754\nTest: Ran bionic-unit-tests/bionic-unit-tests-static.\nTest: Ran malloc debug tests and perfetto integration tests.\nChange-Id: I735403c4d2c87f00fb2cdef81d00af0af446b2bb\n" }, { "commit": "6c619a0da3f96a26d91c1db48fd3e3be156aabe5", "tree": "aa0802d01d19ed0891e6b77a732cc72ed5617dcc", "parents": [ "4e167f35d602f9dcede3b74ff3e09e88f3edb398" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Fri Mar 01 17:59:51 2019 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Thu Mar 07 08:39:55 2019 -0800" }, "message": "Refactor the malloc_info code.\n\nmalloc_info needs to be per native allocator, but the code treated it\nlike a global function that doesn\u0027t depend on the native memory allocator.\n\nUpdate malloc debug to dump the actual pointers that it has been tracking.\n\nTest: bionic-unit-tests pass.\nTest: malloc debug tests pass.\nTest: malloc hook tests pass.\nChange-Id: I3b0d4d748489dd84c16d16933479dc8b8d79013e\nMerged-In: I3b0d4d748489dd84c16d16933479dc8b8d79013e\n(cherry picked from commit a3656a98b10d2a4a6194a5d9705ad9c2cc5877b0)\n" }, { "commit": "a22f5d5175df5c42ec86d2c2db250edf1f64084c", "tree": "66d2980a1b04626c7e4fc1437e96194b958ea8f8", "parents": [ "0771b752f1b955e7ded6ccbbf825b0ae93439eb5" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Fri Mar 01 16:40:59 2019 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Fri Mar 01 23:56:23 2019 -0800" }, "message": "Make aligned_alloc match the standard.\n\nJemalloc does not verify that the size parameter is a multiple of\nalignment. Fix this since it only went into P.\n\nFix the unit tests, and fix malloc debug/malloc hooks to handle this\nnew restrictive behavior.\n\nBug: 126944692\n\nTest: Ran bionic unit tests.\nTest: Ran bionic unit tests with malloc hooks enabled (no new tests fail).\nTest: Ran bionic unit tests with malloc debug enabled (no new tests fail).\nTest: Ran malloc debug unit tests.\nChange-Id: I4d50785928815679c781ca729f998454d76b9192\n" }, { "commit": "b34415046c91d8e4af4e748689af3cb0080e0b05", "tree": "f69a02f5e605b2a8e0e6575804d9493b64289824", "parents": [ "1b82812635e35667df9d28e7416d4b02c2083dfe" ], "author": { "name": "Iris Chang", "email": "iris.chang@mediatek.com", "time": "Tue Feb 12 14:00:59 2019 +0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Thu Feb 14 17:15:03 2019 -0800" }, "message": "malloc debug: fix LogFreeError error log\n\nWhen free_track option is enabled and malloc debug detects error in\nVerifyFreedPointer flow, if freed pointer\u0027s usable_size is more than\ng_debug-\u003econfig().fill_on_free_bytes(), the error log is not correct.\n\nThe max. bytes printed to error message should be the max bytes to\ncmp, not usable size.\n\nBug: 124420174\nTest: build pass and test pass\nChange-Id: I41f35ab3330e49e0a6ad276d405bf4f6c3f0ea92\n" }, { "commit": "7f209a979c55a58e91946a2efd5f0b339ffe309c", "tree": "481e04cf25531a9ced30b032bb5ba93f06de674e", "parents": [ "822326db922ac5d0e4dea8cff1d774e8f04db94a" ], "author": { "name": "Iris Chang", "email": "iris.chang@mediatek.com", "time": "Wed Jan 16 11:17:15 2019 +0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue Jan 22 15:54:36 2019 -0800" }, "message": "Bionic malloc debug: add a new option \"abort_on_error\"\n\nThis new option causes an abort after malloc debug detects an error.\nThis allows vendors to get process coredumps to analyze memory for\ncorruption.\n\nBug: 123009873\nTest: New test cases added for unit tests and config tests.\n\nChange-Id: I6b480af7f747d6a82f61e8bf3df204a5f7ba017f\n" }, { "commit": "6774cc5b9901097fcf9311e6cd91d0465919b77f", "tree": "78d4b889ec421cf2282d2441e6378ce9b670cb11", "parents": [ "9df26193c8adc43a7ac1ba807e70d0b0772712c0" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Thu Oct 04 08:41:10 2018 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Thu Oct 04 08:41:10 2018 -0700" }, "message": "Add new parameter for creation of MapInfo object.\n\nBug: 109657296\n\nTest: Unit tests pass.\nChange-Id: Ie33b50234fa9ba2c5107c3eb0da36a466bba1589\n" }, { "commit": "97b474710225bc4853ab314c3d9ca812dc375525", "tree": "dca19aa52db541c9ef7832d41d1630e81159b12a", "parents": [ "06f217d399b1bf6345e4c71b014cdaac3d1c183a" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue Jul 10 14:45:24 2018 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Jul 11 15:23:00 2018 -0700" }, "message": "Disable malloc debug intercepts when exiting.\n\nThere is a hang when enabling leak_track since the dumping of the\nleak data can wind up doing an allocation.\n\nAdd new system unit test to make sure this doesn\u0027t happen again.\n\nBug: 111146059\n\nTest: Test program that leaks does not hang forever.\nTest: Unit tests pass.\nChange-Id: Icf99be58ba5db98ee124a471b957a086045f5870\n" }, { "commit": "2e1a40a2033088e7f2e78424a8b163d3fcf84b1b", "tree": "51ec5d1703f6225d6dc58ad5b01f9c728e4f2883", "parents": [ "2583b0adb201233313bbe02f665f5c623f2c5a30" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Jun 13 10:46:34 2018 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Fri Jun 15 12:29:13 2018 -0700" }, "message": "Change heap dump format slightly.\n\nBump the version from v1.1 to v1.2 and add a build fingerprint line.\n\nUpdate the heap dump documentation to match the new format and reflect\nwhat made it in P and what made it in Q.\n\nUpdate the unit tests for this change.\n\nAdd -O0 to unit test code to make it easier to debug.\n\nAdd an external function that can be used by the framework code\nso that there is only one way to dump the heap.\n\nBug: 110095681\n\nTest: Ran unit tests.\nTest: Did a dump of a real process and verified fingerprint.\nTest: Did a dump of a process without malloc debug enabled.\nChange-Id: I769a476cbeaf4c85c5d75bd6d6385f0e3add948c\nMerged-In: I769a476cbeaf4c85c5d75bd6d6385f0e3add948c\n(cherry picked from commit c84a2a2601a4112ca6e43a33defb989c1da8c2f4)\n" }, { "commit": "770cbb35cf3441770ce8a808f864beb68b0091cb", "tree": "172e8ed21d5c6027f93313bc65d9c4cb329b7e7e", "parents": [ "8aa6d67f2d48aa01f099a85adc432097a13172f1" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Fri May 25 12:46:55 2018 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Fri May 25 13:28:05 2018 -0700" }, "message": "Point to online documentation.\n\nTest: Unit tests pass.\nChange-Id: Ibbdc260bfdf6a6daf091c4a49cdf03e51f6ca6cf\n" }, { "commit": "93bdd6ae3ad8322b7be2be0201c8db7227631d14", "tree": "42ee959b96c2c2db42f0569554680dbe22ce39ef", "parents": [ "4c5c45346fcc6f066a89bfc455f287fe2f4e3e41" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Thu Apr 05 11:12:38 2018 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Thu May 24 08:44:53 2018 -0700" }, "message": "Add support for using the new unwinder.\n\nThis adds a new option backtrace_full, when it is set, then it will use\nlibunwindstack.\n\nModify the dump to file data to dump the extra information from libunwindstack.\nAlong with the new dump file format, change the version to v1.1.\nUpdated document for new format of file data.\n\nAdd unit tests for the new functionality.\n\nBug: 74361929\n\nTest: Ran unit tests.\nChange-Id: I40fff795f5346bba7b9d7fde2e04f269ff4eb7f1\n" }, { "commit": "c151bc30789ade22d5423b20d2c72948284bba3c", "tree": "687fae810571b1147c5ccb0b5f31fb7515489537", "parents": [ "8602538a15f89f91d6994c3abfd64a274bf7ddb0" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue May 01 12:59:37 2018 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue May 01 14:49:15 2018 -0700" }, "message": "Fix nullptr dereference during sort.\n\nAdd new unit test that will crash without this fix.\n\nBug: 78900050\n\nTest: Ran unit tests.\nChange-Id: I73e1b89e965a7b399822c3a6f25cbc70d2d355e2\n" }, { "commit": "4da2503d70dc4bc1444454876e3794b69227d90d", "tree": "d904c750ebac96aee76df44baad1320c0db211a3", "parents": [ "a3f6f6c1b9135c90e410f5382b153db9a43a4db0" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Mar 07 13:38:48 2018 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Apr 02 18:59:23 2018 -0700" }, "message": "Refactor malloc debug.\n\nChanges\n- Refactor the code so that only guards require creating a special header\n for every pointer allocated.\n- Store only a single copy of every backtrace. This saves memory so that\n turning on the backtrace option doesn\u0027t result in 10X memory usage.\n- Added new option track_allocs that only verifies pointers are valid for\n free/malloc_usable_size/realloc.\n- Remove suffix from test names.\n- Add the TRACK_ALLOCS options to all guard options.\n- Add new option verify_pointers that is a lightweight way to verify\n pointers that are passed to allocation routines.\n- Do auto-formatting of the code.\n- Updated documentation for all of these changes.\n\nBug: 74361929\n\nTest: Ran unit tests.\nTest: Ran libmemunreachable unit tests.\nTest: Ran an app with backtrace enabled.\n\nChange-Id: I3246c48ae4f9811f64622d90d0a9b4d9d818702c\n" }, { "commit": "cae21a9b53a10f0cba79bf6783c4a5af16228fed", "tree": "c60c6622d2b80f9ad4ae5a990b7fb3439f16444b", "parents": [ "be6fbae74fc3048647caadd58a9eaad81245e934" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Feb 05 18:14:55 2018 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Feb 07 06:57:14 2018 -0800" }, "message": "Add aligned_alloc to libc.\n\nBug: 72969374\n\nTest: Bionic unit tests pass.\nTest: Malloc debug unit tests pass.\nChange-Id: I235985bbc638855d94249c97c98f14ab2924bda0\n(cherry picked from commit d69ee59594088c0d92ba9273188ef53ea5e6cd6a)\n" }, { "commit": "cabc77f9172d74ff0bfc56d0797a6a8255b14f2a", "tree": "48d55bb7530c8fdf5ae0b72d65236d5c480def44", "parents": [ "7d5777ef15136e4e12a27c85d7b06d6806b98e70" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Nov 28 12:55:19 2017 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Nov 28 12:55:19 2017 -0800" }, "message": "Always wrap waitpid in TEMP_FAILURE_RETRY.\n\nStrictly not needed in the WNOHANG case, but it\u0027s probably best to have\nevery waitpid wrapped for future copy \u0026 pasters.\n\nBug: https://issuetracker.google.com/69525592\nTest: ran tests\nChange-Id: I013b0a52d2753e3d32638e9b84c79af7327fb405\n" }, { "commit": "a613d0df5c682617380728a7d151483de05a4f92", "tree": "5a73110db954e5fc92116ad0930ed83495607729", "parents": [ "3e8584d4a7d617289e8a954711ba895415d781c4" ], "author": { "name": "Dan Albert", "email": "danalbert@google.com", "time": "Thu Oct 05 16:39:33 2017 -0700" }, "committer": { "name": "Dan Albert", "email": "danalbert@google.com", "time": "Thu Oct 05 23:41:47 2017 -0700" }, "message": "Add a legacy inline for mmap64.\n\nWhile this was never an inline, this function alone has caused most of\nthe bug reports related to _FILE_OFFSET_BITS\u003d64. Providing an inline\nfor it should allow a lot more code to build with _FILE_OFFSET_BITS\u003d64\nwhen targeting pre-L.\n\nTest: make checkbuild\nTest: built trivial cc_binary for LP32 against API 14 with\n _FILE_OFFSET_BITS\u003d64 set\nBug: lots\nChange-Id: I8479d34af4da358c11423bee43d45b59e9d4143e\n" }, { "commit": "602b88ccddfafdefec023e7599d49c811ad3214f", "tree": "11730f3f0cbc308860c4e45d6f0310c7f2083041", "parents": [ "e0e2798f11ca082fe0a796f167f9006c51dc3304" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Fri Aug 04 13:04:04 2017 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue Sep 05 15:57:00 2017 -0700" }, "message": "Provide method to dump backtrace heap data.\n\nFor non-zygote spawned processes, we might want to dump the backtrace\ndata. Provide a method to send a signal to a process and then dump the\ndata to a file.\n\nAdds a method to dump the backtrace data on exit.\n\nUpdate documentation and explain format of heap dump data.\n\nTest: Ran unit tests, enabled new options and used them.\nChange-Id: Ie2fa706694160731afe02c1382b037d06df1d069\n" }, { "commit": "a1c0d2fd4ce96e123c4ae6506c9d637d747e1fe2", "tree": "b1f89edbd67d6b09b9cbdfb1bf03b65b2dac9ad4", "parents": [ "ac58d33d343eba6a3370f541467f09802c48b24b" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon May 15 15:50:19 2017 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon May 15 16:59:16 2017 -0700" }, "message": "Add support for modifying decay timer.\n\nAdd the mallopt function, and only a single option so far.\n\nBug: 36401135\n\nTest: Built and booted bullhead.\nTest: Ran jemalloc unit tests.\nTest: Ran bionic unit tests.\nTest: Ran a test that allocated and free\u0027d a large piece of memory,\nTest: and verified that after changing the parameter, the PSS\nTest: sticks around (decay timer set to 1), the PSS is purged (decay\nTest: timer set to 0).\nChange-Id: I6927929b0c539c1023d34772d9e26bb6a8a45877\n" }, { "commit": "7a3681e5b6c39bc2b3b62031ca5941dbf7bc4e63", "tree": "78c25e2a38b7efed8db770a623a5cbfb7eaab11d", "parents": [ "ca5e0f49ca5df873a20c996755175b5c9c1e2ed9" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Apr 24 17:48:32 2017 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed May 03 08:50:43 2017 -0700" }, "message": "Move libc_log code into libasync_safe.\n\nThis library is used by a number of different libraries in the system.\nMake it easy for platform libraries to use this library and create\nan actual exported include file.\n\nChange the names of the functions to reflect the new name of the library.\n\nRun clang_format on the async_safe_log.cpp file since the formatting is\nall over the place.\n\nBug: 31919199\n\nTest: Compiled for angler/bullhead, and booted.\nTest: Ran bionic unit tests.\nTest: Ran the malloc debug tests.\nChange-Id: I8071bf690c17b0ea3bc8dc5749cdd5b6ad58478a\n" }, { "commit": "2b2b25b87827102671cdd4b25c01aa22a9971a63", "tree": "d318825c7548379a307beee5b78580e51ce97a52", "parents": [ "e06c69d07324f3da67aa063202e698dedd831365" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Apr 05 19:13:03 2017 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Thu Apr 06 15:30:42 2017 -0700" }, "message": "Refactor Config from a struct to a class.\n\nThis should make it easier to add new options, and to add options that\nare complex. For example, I want to modify the behavior of\nrecord_allocs_file so that it also enables record_allocs to a default\nstate.\n\nTest: All unit tests pass.\nTest: Enable the backtrace option and restart.\nChange-Id: Idf5cdeed06ade3bc2c8ae39d228734bf65209b4f\n" }, { "commit": "426b00a29b61a3ac0135373e8c5140957bd867da", "tree": "7d8245cd14cf4f31f2f379c67fd60a4914b34b2d", "parents": [ "b3b11edda111a44c979aa5cd5363ce6064ff4092" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Thu Mar 09 13:47:37 2017 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Thu Mar 09 13:47:37 2017 -0800" }, "message": "Fix the way malloc debug returns info.\n\nWhen I rewrote malloc debug, I accidentally thought that each\nvalue returned in the info buffer contained the number of backtrace\nframes in the backtrace. This was incorrect, it should have been\nthe total number of allocations with the same backtrace.\n\nThis is a temporary fix that sets that value to 1. The better fix is\nto de-dupe backtraces and then return all allocations of the same size\nwith the same backtrace.\n\nI updated the documents to describe this.\n\nBug: 31854476\n\nTest: Unit tests pass.\nChange-Id: Idf9efaa3d363923b5d7543d90dc7c65a0ed553d9\n" }, { "commit": "191d2f3c9959d1b051bac8346b0f80b0bcb0ef15", "tree": "cfa030fe8325c7e999e6d3c2da136d9ceaa3cfb7", "parents": [ "7844b4c5dbd0be9ea4212a523da2dd6a4804032c" ], "author": { "name": "Vijay Venkatraman", "email": "vijaykv@google.com", "time": "Mon Jan 23 18:56:53 2017 -0800" }, "committer": { "name": "Vijay Venkatraman", "email": "vijaykv@google.com", "time": "Mon Jan 23 18:56:53 2017 -0800" }, "message": "Removed include log\\logger.h from log_fake.cpp\n\nTest: Compile malloc_debug_unit_tests\nChange-Id: I635687016570ba52c571435b87d8e89f7f04d609\n" }, { "commit": "ac81fe8657119c265edcc2f05b3e5b7c5b17ae9f", "tree": "99a6e825926829bb7c8d955cbc96ae1777691ef9", "parents": [ "8945d5e43a25737f3f888a90742cc918b1124a05" ], "author": { "name": "Tamas Berghammer", "email": "tberghammer@google.com", "time": "Fri Aug 26 15:54:59 2016 +0100" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Thu Nov 17 13:13:27 2016 -0800" }, "message": "Enable malloc debug using environment variables\n\nPreviously malloc debug can be enabled only using global settings\naccessible to the root user only. This CL adds a new option to enable\nit using environment variables making it possible to use it with pure\nnative (shell) applications on production builds (from shell user) and\nprepares it for using it from logwrapper on production devices.\n\nRemove the old environment variable and property since they are not\nnecessary.\n\nTest: Enable malloc debug using environment variable and verify\nTest: that it only affects the commands launched from the shell.\nTest: Enable malloc debug using the property variable and verify\nTest: that it affects all commands.\nTest: Run all unit tests in 32 bit and 64 bit.\nChange-Id: Iecb75a3471552f619f196ad550c5f41fcd9ce8e5\n" }, { "commit": "4bef28161f6c13b3690914eb14413faf5c74e91c", "tree": "ff7fd27b8cdecc121e4b80b563f93ba49a4b1c80", "parents": [ "52ea18658fb3939aa02cebcb53eef053ba132566" ], "author": { "name": "Tamas Berghammer", "email": "tberghammer@google.com", "time": "Fri Sep 02 16:35:50 2016 +0100" }, "committer": { "name": "Tamas Berghammer", "email": "tberghammer@google.com", "time": "Wed Sep 07 16:12:02 2016 +0100" }, "message": "Fix unittests broken by 545808a\n\nChange-Id: I590af5958e4dcb772b710be965ed6c99cd1d9234\n" }, { "commit": "7bd01783a830f72c1245c262a7fd9a199e90aed1", "tree": "5bd657e6c452d5f9d81a6c9b156ee748c8a8f070", "parents": [ "a0e205e3b4f7993affb864260e924ce9f20573d0" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Apr 20 12:30:58 2016 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Fri Jul 08 14:05:17 2016 -0700" }, "message": "Add the record alloc option.\n\nThis option adds the ability to record all of the allocation requests\nand dump them to a file when a signal is sent to the process.\n\nIncluded in this change, redo the option processing to add a new\nstring option.\n\nBug: 27747898\n\nChange-Id: Ida043362e38b5eb1d459c99db9c2581015dab366\n" }, { "commit": "97fd7d95f5abd3fbc3274b2591883ecdd9cc03cc", "tree": "71e473fe2bd617df202a64db25880adb6e6b5d2f", "parents": [ "1c3a5d87f2844b637f48f43ca22a6ac5e4cbf9c9" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Apr 20 16:44:39 2016 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Apr 20 16:44:39 2016 -0700" }, "message": "Change pointer to allocation in unit tests.\n\nI changed the output from \"pointer\" to \"allocation\" for allocation\nmismatches. I forgot to update the tests.\n\nBug: 28218530\nChange-Id: I3278cb1dd17fb50ff7448c00e069c1af68ce5a57\n" }, { "commit": "d0919623a2ef56107590eca9a9522a250fb8bd4a", "tree": "b0e66ab45ca64f3fb90e03205ebd814f5c55c4f0", "parents": [ "8d0af0bf8004c65f13b985643004a915d7e382eb" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue Mar 15 22:39:39 2016 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Mar 16 17:38:08 2016 -0700" }, "message": "Fix race in malloc debug option free_track.\n\nThe free track mechanism could fail if, at the same time a free occurs,\nanother thread is trying to free and verify the same allocation. This\ndoesn\u0027t work if the freed allocation is added to the list and we still\ndo work on it. The fix is to only add to the free list when we are done\nwith the allocation.\n\nAlso fix a problem where the usable size is computed incorrectly because\ntwo of the arguments where reversed.\n\nIn addition, add a check that the allocation being verified has the correct\ntag before trying to check the body of the allocation.\n\nAdd a test to catch the original failure.\n\nAdd a test for the tag being different.\n\nBug: 27601650\nChange-Id: Ie9200677d066255b8e668a48422f23f909f4ddee\n" }, { "commit": "a4b14252752d14454afb48feb3272e8689e3a66d", "tree": "939fc4e7324147dd97d0e54d9383bb1758ec8848", "parents": [ "0e00c168cea9c951df5ce47d25d8f042b9cc566a" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Mar 14 15:29:46 2016 -0700" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Mar 14 15:34:22 2016 -0700" }, "message": "Fix problem where unknown option is not an error.\n\nIf the first option is found, then any unknown options are simply\nignored, but do not produce an error. Fixed this so that each\noption found is actually verified to exist.\n\nBug: 27620263\nChange-Id: If58732df3285eeae72188162c505e0e202fada8c\n" }, { "commit": "7877df66c27c8cd27dcb809e5cbfdc38b798e5cb", "tree": "d77a82183c705cb4a0e2ebf290de217d86bc8af6", "parents": [ "9567c7b82cba21d3046bab5c9b1fe4e73f2629bf" ], "author": { "name": "Colin Cross", "email": "ccross@android.com", "time": "Thu Mar 10 13:01:27 2016 -0800" }, "committer": { "name": "Colin Cross", "email": "ccross@android.com", "time": "Thu Mar 10 14:53:02 2016 -0800" }, "message": "malloc_debug: fix multiplication overflow in debug_calloc\n\nThe over flow check for nmemb * bytes in debug_calloc is incorrect,\nuse the builtin overflow functions to check for multiplication and\naddition overflow.\n\nChange-Id: I3f1c13102621bc5380be1f69caa88dba2118f3cb\n(cherry picked from commit 239838608dbe9917acddfe5a51d92350a4c8e135)\n" }, { "commit": "549e52200b6af3c33cba7ef759ea98b49fa40082", "tree": "bf86a923f9e99668414f03f47b41f5493ef33072", "parents": [ "eb727252f22bd533ebfd40637c0718fdc9946221" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Feb 22 19:23:26 2016 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Fri Feb 26 17:02:17 2016 -0800" }, "message": "Move hard-coded values to constants.\n\nChange all of the hard-coded config values to be defined constants.\nAlso make sure to use these constants in the usage output.\n\nBug: 26739265\nChange-Id: I597a6d71279a2df9cc7e98c42ac70224261bac99\n" }, { "commit": "0e2a0265798ed47cbbf6977f0f84cf81d93173a6", "tree": "888f3e9a96e38769cddae99ce0b9eb2881aa5c4d", "parents": [ "f2d516b3f9ef901991387ee473140ea24feaab48" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Feb 22 19:14:26 2016 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Feb 22 19:14:26 2016 -0800" }, "message": "Fix wrong guard values for 64 bit.\n\nI added the code to force alignments of 8 for 32 bit and 16 for 64 bit,\nbut I missed a couple of tests that failed due to this change. Fix the\nfailing tests.\n\nBug: 26739265\nChange-Id: Ice9932d1419e59c07483c4c9fcdb84970844f0a6\n" }, { "commit": "869691c6f7691dd5bf343617aa185c32e0d3d160", "tree": "aa0cb5619aa90a899a31ca0ba250cb180c5d1302", "parents": [ "aca201358b910e5a4b925c639902387fbdfd9016" ], "author": { "name": "Colin Cross", "email": "ccross@android.com", "time": "Fri Jan 29 12:48:18 2016 -0800" }, "committer": { "name": "Colin Cross", "email": "ccross@android.com", "time": "Thu Feb 18 15:05:38 2016 -0800" }, "message": "Export malloc_iterate and friends\n\nExport malloc_iterate, malloc_enable, and malloc_disable to be used by\nlibmemunreachable.\n\nChange-Id: I08a50349af82a95d096b6b4cbac37ababe4b9b06\n" }, { "commit": "72df6708c829a4c6494936fdfbda6dc7e68e647b", "tree": "17ede0d54b6f50c3598a3fcec56f50754067690d", "parents": [ "72bca4b4105e24058f3f2eca024382bedb122a30" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Thu Feb 11 15:51:31 2016 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Fri Feb 12 17:30:30 2016 -0800" }, "message": "Fix the default alignment of the allocations.\n\nIn order to enforce this constraint:\n\nThe pointer returned if the allocation succeeds shall be suitably\naligned so that it may be assigned to a pointer to any type of object\nand then used to access such an object in the space allocated.\n\nForce all allocations on 32 bit systems to have 8 byte alignment,\nand all allocations on 64 bit systems to have 16 byte alignment.\n\nAdd a test to verify that the allocator returns the correct alignments.\n\nBug: 26739265\nChange-Id: I9af53279617408676b94e4ec6481b3ed7ffafc6a\n" }, { "commit": "701bb65511aed14da6c51179619785e5706fa5a6", "tree": "04cffebe6ad88578e7212d690318563b4bb3bfa5", "parents": [ "4821db1b3ecc14828d4acf4abed26bb7d8b8cf6a" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue Feb 02 13:09:59 2016 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Tue Feb 02 13:22:40 2016 -0800" }, "message": "Remove the unused TrackHeader structure.\n\nChange-Id: I07ae5de717e1fcfbe5dfe552a531db9f630da622\n" }, { "commit": "7993b80f894db20af4d1d154221c42fea6171a3d", "tree": "fc99d36000a8f0853224d75296d96509a730ee05", "parents": [ "50647711ebaf2360aca05cc94a2fdf431c1a153e" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Thu Jan 28 18:35:05 2016 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Fri Jan 29 15:19:22 2016 -0800" }, "message": "Add better free tracking.\n\nIncluded in this change:\n\n- Change the tag when a pointer is freed so it\u0027s easy to detect if\n an already freed pointer is being used.\n- Move the free backtrace out of the header. This backtrace is only\n used under only some circumstances, so no need to allocate space\n in all headers for it.\n- Add new option free_track_backtrace_num_frames to specify how many\n frames to record when the free occurs. This removes the dependency\n on the backtrace option to get backtraces.\n\nBug: 26739265\nChange-Id: I76f5209507dcf46af67ada162a7cb2bf282116f2\n" }, { "commit": "166c8535a5a4253bcb2b04bbd20a2a8c04c44f2c", "tree": "09ea8c0e5618aaee0434ad89b83c5ae05162642a", "parents": [ "e4daf100b33fb17936b4d61e0ddfe679fcd04123" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Jan 27 17:23:36 2016 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Wed Jan 27 18:13:09 2016 -0800" }, "message": "Add min/max values for config values.\n\nThis is to only allow realistic values for some of the options.\n\nBug: 26739265\n\nChange-Id: I172d5401c27e5d638d80f1c93c678c26c4dae0fc\n" }, { "commit": "1e185a5056f85e281f699a92114b758591ae3b92", "tree": "86a88c43ee354e576535d5121d2250dc6412ccb8", "parents": [ "f2b67b85f5e192812212d3176c07e195c0ffa503" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Jan 25 17:23:38 2016 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Jan 25 17:27:40 2016 -0800" }, "message": "Fix gcc test issues.\n\nChange-Id: I2b26b779f5198c7c9362a452b971260a8852aa7b\n" }, { "commit": "63860cb8fd1adf3f679b9b4ad876323a8d65cd9d", "tree": "25aeae686d92efcb5e08a54e8cba1e8c31efe33b", "parents": [ "ad9c3f34f762ed45cce5dbb93218124ed31f6873" ], "author": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Nov 16 17:30:32 2015 -0800" }, "committer": { "name": "Christopher Ferris", "email": "cferris@google.com", "time": "Mon Jan 25 10:54:21 2016 -0800" }, "message": "Malloc debug rewrite.\n\nThe major components of the rewrite:\n\n- Completely remove the qemu shared library code. Nobody was using it\n and it appears to have broken at some point.\n- Adds the ability to enable/disable different options independently.\n- Adds a new option that can enable the backtrace on alloc/free when\n a process gets a specific signal.\n- Adds a new way to enable malloc debug. If a special property is\n set, and the process has an environment variable set, then debug\n malloc will be enabled. This allows something that might be\n a derivative of app_process to be started with an environment variable\n being enabled.\n- get_malloc_leak_info() used to return one element for each pointer that\n had the exact same backtrace. The new version returns information for\n every one of the pointers with same backtrace. It turns out ddms already\n automatically coalesces these, so the old method simply hid the fact\n that there where multiple pointers with the same amount of backtrace.\n- Moved all of the malloc debug specific code into the library.\n Nothing related to the malloc debug data structures remains in libc.\n- Removed the calls to the debug malloc cleanup routine. Instead, I\n added an atexit call with the debug malloc cleanup routine. This gets\n around most problems related to the timing of doing the cleanup.\n\nThe new properties and environment variables:\n\nlibc.debug.malloc.options\n Set by option name (such as \"backtrace\"). Setting this to a bad value\n will cause a usage statement to be printed to the log.\n\nlibc.debug.malloc.program\n Same as before. If this is set, then only the program named will\n be launched with malloc debug enabled. This is not a complete match,\n but if any part of the property is in the program name, malloc debug is\n enabled.\n\nlibc.debug.malloc.env_enabled\n If set, then malloc debug is only enabled if the running process has the\n environment variable LIBC_DEBUG_MALLOC_ENABLE set.\n\nBug: 19145921\n\nChange-Id: I7b0e58cc85cc6d4118173fe1f8627a391b64c0d7\n" } ] }