)]}' { "log": [ { "commit": "40a521744825b6060960c296d5fb3da4c6593d94", "tree": "b9736886f5ca89daf4bf6cca05e090315a006dcd", "parents": [ "4ad5066e1de326e5db46df18eeade9a88bc11bec" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jul 30 14:48:10 2014 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jul 30 14:49:40 2014 -0700" }, "message": "Only wipe TLS for user-supplied stacks.\n\nBug: 16667988\nChange-Id: Id180ab2bc6713e1612386120a306db5bbf1d6046\n" }, { "commit": "7086ad6919feb2415c6027163f5c63323bcca27c", "tree": "f32c06d513e90ba1fcb8fe56f9cd055cccc7d01b", "parents": [ "d1bf37780d0bcaca3e6046171f958ebfea34bde1" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Jun 19 16:39:01 2014 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Jun 20 09:06:57 2014 -0700" }, "message": "Cache getpid.\n\nIn practice, with this implementation we never need to make a system call.\nWe get the main thread\u0027s tid (which is the same as our pid) back from\nthe set_tid_address system call we have to make during initialization.\nA new pthread will have the same pid as its parent, and a fork child\u0027s\nmain (and only) thread will have a pid equal to its tid, which we get for\nfree from the kernel before clone returns.\n\nThe only time we\u0027d actually have to make a getpid system call now is if\nwe take a signal during fork and the signal handler calls getpid. (That,\nor we call getpid in the dynamic linker while it\u0027s still dealing with its\nown relocations and hasn\u0027t even set up the main thread yet.)\n\nBug: 15387103\nChange-Id: I6d4718ed0a5c912fc75b5f738c49a023dbed5189\n" }, { "commit": "b30aff405a220495941f1673b0a5e66c4fa8b84c", "tree": "3bf667c009cf468c040ccaae6e81d468b4fd0254", "parents": [ "52f74322b1d72d57146107f32ee2c76c421bf4b1" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed May 28 19:35:33 2014 +0000" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed May 28 18:31:15 2014 -0700" }, "message": "Revert \"Revert \"Lose the hand-written futex assembler.\"\"\n\nThe problem with the original patch was that using syscall(3) means that\nerrno can be set, but pthread_create(3) was abusing the TLS errno slot as\na pthread_mutex_t for the thread startup handshake.\n\nThere was also a mistake in the check for syscall failures --- it should\nhave checked against -1 instead of 0 (not just because that\u0027s the default\nidiom, but also here because futex(2) can legitimately return values \u003e 0).\n\nThis patch stops abusing the TLS errno slot and adds a pthread_mutex_t to\npthread_internal_t instead. (Note that for LP64 sizeof(pthread_mutex_t) \u003e\nsizeof(uintptr_t), so we could potentially clobber other TLS slots too.)\n\nI\u0027ve also rewritten the LP32 compatibility stubs to directly reuse the\ncode from the .h file.\n\nThis reverts commit 75c55ff84ebfa686c7ae2cc8ee431c6a33bd46b4.\n\nBug: 15195455\nChange-Id: I6ffb13e5cf6a35d8f59f692d94192aae9ab4593d\n" }, { "commit": "1728b2396591853345507a063ed6075dfd251706", "tree": "7083cd234073afa5179b94b3d978550c890af90c", "parents": [ "bac795586bbc5dcbe886d8d781710f60c4c19d9b" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed May 14 10:02:03 2014 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed May 14 10:02:03 2014 -0700" }, "message": "Switch to g_ for globals.\n\nThat\u0027s what the Google style guide recommends, and we\u0027re starting\nto get a mix.\n\nChange-Id: Ib0c53a890bb5deed5c679e887541a715faea91fc\n" }, { "commit": "4b558f50a42c97d461f1dede5aaaae490ea99e2e", "tree": "c239a686131cdda28272c961ce98febbc0c772f8", "parents": [ "bef5016491eed41521f514d5c5528e2274689948" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Mar 04 15:58:02 2014 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Mar 07 16:49:46 2014 -0800" }, "message": "Rewrite the POSIX timer functions.\n\nThis is a much simpler implementation that lets the kernel\ndo as much as possible.\n\nCo-authored-by: Jörgen Strand \u003cjorgen.strand@sonymobile.com\u003e\nCo-authored-by: Snild Dolkow \u003csnild.dolkow@sonymobile.com\u003e\nChange-Id: Iad19f155de977667aea09410266d54e63e8a26bf\n" }, { "commit": "0e714a5b41451e84c5ded93a42c9a4b0a9440691", "tree": "86e6519cc723fb66a9432193da16b380255c22f7", "parents": [ "8e541b12237f597c186820b9e18b059b620bef54" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Mar 03 16:42:47 2014 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Mar 04 10:27:58 2014 -0800" }, "message": "Implement POSIX pthread_mutex_timedlock.\n\nThis replaces the non-standard pthread_mutex_lock_timeout_np, which we have\nto keep around on LP32 for binary compatibility.\n\nChange-Id: I098dc7cd38369f0c1bec1fac35687fbd27392e00\n" }, { "commit": "cef3faec0ea40fdfe58e425fd0be64f00de6a26d", "tree": "1f33cbb2de225d0d76d3eb53ef8857b9ecc79bbe", "parents": [ "1b2d214b62ad7bf46f37c79442a69d930aa29027" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Nov 19 16:52:24 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Nov 19 17:22:22 2013 -0800" }, "message": "Clean up pthread_internal_t.\n\nBug: 11755300\nChange-Id: Ib509e8c5ec6b23513aa78b5ac5141d7c34ce2dc8\n" }, { "commit": "36d6188f8cd8b948fb797f11d9620d63d0c2215a", "tree": "86b3162cac031151b2ae44b4d554fce4f9456147", "parents": [ "318e86ed887e04e593f3db9b84b402d5501ced9b" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Nov 19 13:31:58 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Nov 19 14:08:54 2013 -0800" }, "message": "Clean up forking and cloning.\n\nThe kernel now maintains the pthread_internal_t::tid field for us,\nand __clone was only used in one place so let\u0027s inline it so we don\u0027t\nhave to leave such a dangerous function lying around. Also rename\nfiles to match their content and remove some useless #includes.\n\nChange-Id: I24299fb4a940e394de75f864ee36fdabbd9438f9\n" }, { "commit": "877ec6d90418ff1d6597147d355a2229fdffae7e", "tree": "e475221a7fbff1564ad37548e920333c49cc5873", "parents": [ "f246c589d66e5dc0e3cddc3c37261fb0e3fc67e9" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Nov 15 17:40:18 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Nov 18 19:48:11 2013 -0800" }, "message": "Fix pthread_join.\n\nLet the kernel keep pthread_internal_t::tid updated, including\nacross forks and for the main thread. This then lets us fix\npthread_join to only return after the thread has really exited.\n\nAlso fix the thread attributes of the main thread so we don\u0027t\nunmap the main thread\u0027s stack (which is really owned by the\ndynamic linker and contains things like environment variables),\nwhich fixes crashes when joining with an exited main thread\nand also fixes problems reported publicly with accessing environment\nvariables after the main thread exits (for which I\u0027ve added a new\nunit test).\n\nIn passing I also fixed a bug where if the clone(2) inside\npthread_create(3) fails, we\u0027d unmap the child\u0027s stack and TLS (which\ncontains the mutex) and then try to unlock the mutex. Boom! It wasn\u0027t\nuntil after I\u0027d uploaded the fix for this that I came across a new\npublic bug reporting this exact failure.\n\nBug: 8206355\nBug: 11693195\nBug: https://code.google.com/p/android/issues/detail?id\u003d57421\nBug: https://code.google.com/p/android/issues/detail?id\u003d62392\nChange-Id: I2af9cf6e8ae510a67256ad93cad891794ed0580b\n" }, { "commit": "e48b68570d872ef7ece1d873c0ea298ea76393f3", "tree": "8c6d8721af2bfddd2c649a0d887a4a905358da04", "parents": [ "e39e3a77d6e8cf681718a572bc754fd64dfc87ff" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Nov 15 14:57:45 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Nov 15 14:57:45 2013 -0800" }, "message": "Clean up the pthread_create trampoline.\n\nBug: 8206355\nBug: 11693195\nChange-Id: I35cc024d5b6ebd19d1d2e45610db185addaf45df\n" }, { "commit": "70b24b1cc2a1a4436b1fea3f8b76616fdcb27224", "tree": "70c8e04ccd256eaeda3c7e516776f4c9bca25628", "parents": [ "05ec00bf62ac168c9787a3d0640879ab3e502fe5" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Nov 15 11:51:07 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Nov 15 14:41:19 2013 -0800" }, "message": "Switch pthread_create over to __bionic_clone.\n\nBug: 8206355\nBug: 11693195\nChange-Id: I04aadbc36c87e1b7e33324b9a930a1e441fbfed6\n" }, { "commit": "c3f114037dbf028896310609fd28cf2b3da99c4d", "tree": "e463aeb3604177cd93cea8a58936a8dce4b34ee5", "parents": [ "d0d0b52da375bfa85947a4257198791f615f18a8" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Oct 30 14:40:09 2013 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Oct 31 12:31:16 2013 -0700" }, "message": "\u003cpthread.h\u003e fixes and pthread cleanup.\n\n\u003cpthread.h\u003e was missing nonnull attributes, noreturn on pthread_exit,\nand had incorrect cv qualifiers for several standard functions.\n\nI\u0027ve also marked the non-standard stuff (where I count glibc rather\nthan POSIX as \"standard\") so we can revisit this cruft for LP64 and\ntry to ensure we\u0027re compatible with glibc.\n\nI\u0027ve also broken out the pthread_cond* functions into a new file.\n\nI\u0027ve made the remaining pthread files (plus ptrace) part of the bionic code\nand fixed all the warnings.\n\nI\u0027ve added a few more smoke tests for chunks of untested pthread functionality.\n\nWe no longer need the libc_static_common_src_files hack for any of the\npthread implementation because we long since stripped out the rest of\nthe armv5 support, and this hack was just to ensure that __get_tls in libc.a\nwent via the kernel if necessary.\n\nThis patch also finishes the job of breaking up the pthread.c monolith, and\nadds a handful of new tests.\n\nChange-Id: Idc0ae7f5d8aa65989598acd4c01a874fe21582c7\n" }, { "commit": "2b6e43e00ece68b3aba26d8f95f07cd9d9294ab4", "tree": "7a27d206fb0f2ef7b702c0c785827d607dd7216a", "parents": [ "8e6e7cdadbb4efdeefaa73fe94f7a9a1722745a7" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Oct 29 16:11:06 2013 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Oct 29 16:11:06 2013 -0700" }, "message": "Explain the sigprocmask in pthread_exit.\n\nAlso remove the SIGSEGV special case, which was probably because\nhand-written __exit_with_stack_teardown stubs used to try to cause\nSIGSEGV if the exit system call returned (which it never does, so\nthat dead code disappeared).\n\nAlso move the sigprocmask into the only case where it\u0027s necessary ---\nthe one where we unmap the stack that would be used by a signal\nhandler.\n\nChange-Id: Ie40d20c1ae2f5e7125131b6b492cba7a2c6d08e9\n" }, { "commit": "eb847bc8666842a3cfc9c06e8458ad1abebebaf0", "tree": "15e070fb706ba7599d5f402a8f934a7399541a6a", "parents": [ "0c17099a71cb5d1b36b7aab66fd7341b3fc9106d" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Oct 09 15:50:50 2013 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Oct 09 16:00:17 2013 -0700" }, "message": "Fix x86_64 build, clean up intermediate libraries.\n\nThe x86_64 build was failing because clone.S had a call to __thread_entry which\nwas being added to a different intermediate .a on the way to making libc.so,\nand the linker couldn\u0027t guarantee statically that such a relocation would be\npossible.\n\n ld: error: out/target/product/generic_x86_64/obj/STATIC_LIBRARIES/libc_common_intermediates/libc_common.a(clone.o): requires dynamic R_X86_64_PC32 reloc against \u0027__thread_entry\u0027 which may overflow at runtime; recompile with -fPIC\n\nThis patch addresses that by ensuring that the caller and callee end up in the\nsame intermediate .a. While I\u0027m here, I\u0027ve tried to clean up some of the mess\nthat led to this situation too. In particular, this removes libc/private/ from\nthe default include path (except for the DNS code), and splits out the DNS\ncode into its own library (since it\u0027s a weird special case of upstream NetBSD\ncode that\u0027s diverged so heavily it\u0027s unlikely ever to get back in sync).\n\nThere\u0027s more cleanup of the DNS situation possible, but this is definitely a\nstep in the right direction, and it\u0027s more than enough to get x86_64 building\ncleanly.\n\nChange-Id: I00425a7245b7a2573df16cc38798187d0729e7c4\n" }, { "commit": "50af69e8f326b2762a44d5fea2b118e7616e5d20", "tree": "46a173af8b370ce18d029c05c636bdc6fcc557ed", "parents": [ "322e7bce235ec6e3f82f65669423a1d9e997b51e" ], "author": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Sep 13 16:34:43 2013 -0700" }, "committer": { "name": "Brian Carlstrom", "email": "bdc@google.com", "time": "Fri Sep 13 16:44:47 2013 -0700" }, "message": "Simplify main thread stack size initialization\n\nChange-Id: Iec09433d9de501031cce09dc75848a5e8f3d96bf\n" }, { "commit": "4cf13952175a793fed4646d7d7396364874b0909", "tree": "398598a421abf5790688df72da59cbce627d2e40", "parents": [ "e8bd8c2ed9c71c73682f29020456934c55f260e3" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Jul 19 16:42:27 2013 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Jul 19 16:42:27 2013 -0700" }, "message": "Move stuff only needed by pthread-timers.c into pthread-timers.c.\n\nChange-Id: I4915b3fff9c4f5a36b4f51027fb22019c11607b0\n" }, { "commit": "84114c8dd5b17efecf7988f263ce431208d7be5a", "tree": "81d4ae4e6a40c4255b2e76adeb2b68dab5932058", "parents": [ "40e7a87864fee75f7af2caf8e1972d0d764135cd" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jul 17 13:33:19 2013 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jul 17 13:33:19 2013 -0700" }, "message": "Improve stack overflow diagnostics (take 2).\n\nThis reverts commits eb1b07469f2b5a392dc1bfd8adc211aea8c72bc5 and\nd14dc3b87fbf80553f1cafa453816b7f11366627, and fixes the bug where\nwe were calling mmap (which might cause errno to be set) before\n__set_tls (which is required to implement errno).\n\nBug: 8557703\nChange-Id: I2c36d00240c56e156e1bb430d8c22a73a068b70c\n" }, { "commit": "eb1b07469f2b5a392dc1bfd8adc211aea8c72bc5", "tree": "b4cda0d4fa3935abd85b3ee178d35d0738e8a744", "parents": [ "5cf87951abd23b0b3ebf159e8aa06b02e39527ca" ], "author": { "name": "Guang Zhu", "email": "guangzhu@google.com", "time": "Wed Jul 17 03:16:04 2013 +0000" }, "committer": { "name": "Guang Zhu", "email": "guangzhu@google.com", "time": "Wed Jul 17 03:16:04 2013 +0000" }, "message": "Revert \"Clean up our alternate signal stacks.\"\n\nThis reverts commit 5cf87951abd23b0b3ebf159e8aa06b02e39527ca.\n\nChange-Id: Idd6ca7d80a018755da3bd315d91193723ce7f3bf\n" }, { "commit": "5cf87951abd23b0b3ebf159e8aa06b02e39527ca", "tree": "6eb2d74004073510406eb8363c81273533f71be4", "parents": [ "026867c7dcce7828212dcd4a61806146908e9039" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Jul 16 14:32:47 2013 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Jul 16 14:35:52 2013 -0700" }, "message": "Clean up our alternate signal stacks.\n\nBug: 8557703\nChange-Id: Ie93901dd1c29e9d3bf795b0f0400616d9ef08f75\n" }, { "commit": "0f020d18b138e24b1fe34074808e07ac412f35a4", "tree": "75e84d43c82a0e8013d7b1c34d4da1fec64e116c", "parents": [ "6a44d2271f372d0c65b05a5d3377bd00ce92824e" ], "author": { "name": "msg555", "email": "msg555@gmail.com", "time": "Thu Jun 06 14:59:28 2013 -0400" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jun 12 17:30:58 2013 -0700" }, "message": "Handles spurious wake-ups in pthread_join()\n\nRemoved \u0027join_count\u0027 from pthread_internal_t and switched to using the flag\nPTHREAD_ATTR_FLAG_JOINED to indicate if a thread is being joined. Combined with\na switch to a while loop in pthread_join, this fixes spurious wake-ups but\nprevents a thread from being joined multiple times. This is fine for\ntwo reasons:\n\n1) The pthread_join specification allows for undefined behavior when multiple\n threads try to join a single thread.\n\n2) There is no thread safe way to allow multiple threads to join a single\n thread with the pthread interface. The second thread calling pthread_join\n could be pre-empted until the thread is destroyed and its handle reused for\n a different thread. Therefore multi-join is always an error.\n\nBug: https://code.google.com/p/android/issues/detail?id\u003d52255\nChange-Id: I8b6784d47620ffdcdbfb14524e7402e21d46c5f7\n" }, { "commit": "36fa67bcdd90f18a3c68f8637ae836762407fa51", "tree": "67c47601c9dd09bf8fc97d15e872c264752477da", "parents": [ "c5bfb62433751579e86d5fd24cddf3ae28a49b43" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jun 05 17:51:20 2013 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Jun 05 17:58:08 2013 -0700" }, "message": "Ensure header files using __BEGIN_DECLS include sys/cdefs.h.\n\nWe keep fixing these one-by-one; let\u0027s fix them all at once.\n\nFound thus:\n\n find . -name *.h | xargs grep -L sys/cdefs.h | xargs grep -l BEGIN_DECL | xargs grep -L sys/types\n\nChange-Id: I188842aa2484dc6176e96556d57c38a0f785b59b\n" }, { "commit": "9d23e04c43dbb8480bea8be28b8a2f37423bec49", "tree": "e403288cf01ce40d6f330da09a317c7ad6dc2cb2", "parents": [ "081318e3550b1a8d8384d98d7c94527681691120" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Feb 15 19:21:51 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Feb 19 12:21:41 2013 -0800" }, "message": "Fix pthreads functions that should return ESRCH.\n\nimgtec pointed out that pthread_kill(3) was broken, but most of the\nother functions that ought to return ESRCH for invalid/exited threads\nwere equally broken.\n\nChange-Id: I96347f6195549aee0c72dc39063e6c5d06d2e01f\n" }, { "commit": "40eabe24e4e3ae8ebe437f1f4e43cf39cbba2e9e", "tree": "19eef7fcbba616a52bd37f4c83ece3e918b25445", "parents": [ "3e3b239d2be0c5a92e91385f4f10b8f7da8d2837" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Feb 14 18:59:37 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Feb 15 12:08:59 2013 -0800" }, "message": "Fix the pthread_setname_np test.\n\nFix the pthread_setname_np test to take into account that emulator kernels are\nso old that they don\u0027t support setting the name of other threads.\n\nThe CLONE_DETACHED thread is obsolete since 2.5 kernels.\n\nRename kernel_id to tid.\n\nFix the signature of __pthread_clone.\n\nClean up the clone and pthread_setname_np implementations slightly.\n\nChange-Id: I16c2ff8845b67530544bbda9aa6618058603066d\n" }, { "commit": "6d339182070b035ca94f19bc37c94f4d9813c374", "tree": "3745d21667b8c856276c85cf0864d6ab483f83cf", "parents": [ "4912782c6af7169686acc9553fb0bb33251b0d0d" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Feb 12 16:36:04 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Feb 12 16:36:04 2013 -0800" }, "message": "Simplify pthread_create, using more public API.\n\nChange-Id: I08e65ba88ed01436223e4e528631c9e41ec0e7f4\n" }, { "commit": "3e898476c7230b60a0f76968e64ff25f475b48c0", "tree": "0f876aeb565b7e7ac627a6305a355c40173912f2", "parents": [ "fcaf4e9f9b735e053469c7ecbf63584e10fd67a7" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Feb 12 16:40:24 2013 +0000" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Feb 12 15:27:18 2013 -0800" }, "message": "Revert \"Revert \"More pthreads cleanup.\"\"\n\nThis reverts commit 6f94de3ca49e4ea147b1c59e5818fa175846518f\n\n(Doesn\u0027t try to increase the number of TLS slots; that leads to\nan inability to boot. Adds more tests.)\n\nChange-Id: Ia7d25ba3995219ed6e686463dbba80c95cc831ca\n" }, { "commit": "6f94de3ca49e4ea147b1c59e5818fa175846518f", "tree": "9a2c45004114f53c4cf1f9468a58fe54c58320fa", "parents": [ "2a1bb4e64677b9abbc17173c79768ed494565047" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Feb 12 06:06:22 2013 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Tue Feb 12 06:06:22 2013 +0000" }, "message": "Revert \"More pthreads cleanup.\"\n\nThis reverts commit 2a1bb4e64677b9abbc17173c79768ed494565047\n\nChange-Id: Ia443d0748015c8e9fc3121e40e68258616767b51\n" }, { "commit": "2a1bb4e64677b9abbc17173c79768ed494565047", "tree": "3e843fd4277f2bdc502511bd5e4ee539887c14f1", "parents": [ "2d3e72336e76180fb00822386da4f14203d117ce" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Feb 11 12:34:03 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Feb 11 14:56:39 2013 -0800" }, "message": "More pthreads cleanup.\n\nPOSIX says pthread_create returns EAGAIN, not ENOMEM.\n\nAlso pull pthread_attr_t functions into their own file.\n\nAlso pull pthread_setname_np into its own file.\n\nAlso remove unnecessary #includes from pthread_key.cpp.\n\nAlso account for those pthread keys used internally by bionic,\nso they don\u0027t count against the number of keys available to user\ncode. (They do with glibc, but glibc\u0027s limit is the much more\ngenerous 1024.)\n\nAlso factor out the common errno-restoring idiom to reduce gotos.\n\nBug: 6702535\nChange-Id: I555e66efffcf2c1b5a2873569e91489156efca42\n" }, { "commit": "44b53ad6818de344e0b499ad8fdbb21fcb0ff2b6", "tree": "9a2c45004114f53c4cf1f9468a58fe54c58320fa", "parents": [ "8397cdba9424febeaed4068829a5b0174ee1138c" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Feb 11 20:18:47 2013 +0000" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Feb 11 12:20:33 2013 -0800" }, "message": "Revert \"Revert \"Pull the pthread_key_t functions out of pthread.c.\"\"\n\nThis reverts commit 6260553d48f6fd87ca220270bea8bafdde5726ec\n\n(Removing the accidental libm/Android.mk change.)\n\nChange-Id: I6cddd9857c31facc05636e8221505b3d2344cb75\n" }, { "commit": "6260553d48f6fd87ca220270bea8bafdde5726ec", "tree": "9c2cb4dfb830d7918a0d0b8ecfbf25bf87bcc453", "parents": [ "ad59322ae432d11ff36dcf046016af8cfe45fbe4" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Feb 11 20:18:16 2013 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Feb 11 20:18:16 2013 +0000" }, "message": "Revert \"Pull the pthread_key_t functions out of pthread.c.\"\n\nThis reverts commit ad59322ae432d11ff36dcf046016af8cfe45fbe4\n\nsomehow my unfinished libm/Android.mk change got into here.\n\nChange-Id: I46be626c5269d60fb1ced9862f2ebaa380b4e0af\n" }, { "commit": "ad59322ae432d11ff36dcf046016af8cfe45fbe4", "tree": "04ea728ddd656079ca4b9f228b32c371370be947", "parents": [ "9a9bb243b50be5e3910b8edad72327bc216e72d0" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Fri Feb 08 15:46:37 2013 -0800" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Feb 11 12:00:48 2013 -0800" }, "message": "Pull the pthread_key_t functions out of pthread.c.\n\nThis was originally motivated by noticing that we were setting the\nwrong bits for the well-known tls entries. That was a harmless bug\nbecause none of the well-known tls entries has a destructor, but\nit\u0027s best not to leave land mines lying around.\n\nAlso add some missing POSIX constants, a new test, and fix\npthread_key_create\u0027s return value when we hit the limit.\n\nChange-Id: Ife26ea2f4b40865308e8410ec803b20bcc3e0ed1\n" }, { "commit": "4f251bee5d51228217c1bf4dfc9219f3058bd3ed", "tree": "3d0f1faef6a38e494f8157e467e7fc0f876f6cd4", "parents": [ "064f862d557ab741575dfae479499a07ca0ab742" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Nov 01 16:33:29 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Thu Nov 01 17:27:07 2012 -0700" }, "message": "Don\u0027t corrupt the thread list if the main thread exits.\n\n...and don\u0027t pass a non-heap pointer to free(3), either.\n\nThis patch replaces the \"node** prev\" with the clearer \"node* prev\"\nstyle and fixes the null pointer dereference in the old code. That\u0027s\nnot sufficient to fix the reporter\u0027s bug, though. The pthread_internal_t*\nfor the main thread isn\u0027t heap-allocated --- __libc_init_tls causes a\npointer to a statically-allocated pthread_internal_t to be added to\nthe thread list.\n\nBug: http://code.google.com/p/android/issues/detail?id\u003d37410\nChange-Id: I112b7f22782fc789d58f9c783f7b323bda8fb8b7\n" }, { "commit": "ae8eb74675722b57ab66a51f1d6f4f250137bb23", "tree": "7a5b7bf7eed38b5a7a5129cd1f261e66277381b0", "parents": [ "33c4a3adde3cf1753af0661f48ce86358e105277" ], "author": { "name": "Xi Wang", "email": "xi.wang@gmail.com", "time": "Sat Oct 27 02:02:01 2012 -0400" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Mon Oct 29 08:22:13 2012 -0700" }, "message": "Fix a potential NULL pointer dereference in _init_thread().\n\nThe first NULL pointer check against `attr\u0027 suggests that `attr\u0027 can\nbe NULL. Then later `attr\u0027 is directly dereferenced, suggesting the\nopposite.\n\n if (attr \u003d\u003d NULL) {\n ...\n } else {\n ...\n }\n ...\n if (attr-\u003estack_base \u003d\u003d ...) { ... }\n\nThe public API pthread_create(3) allows NULL, and interprets it as \"default\".\nOur implementation actually swaps in a pointer to the global default\npthread_attr_t, so we don\u0027t need any NULL checks in _init_thread. (The other\ninternal caller passes its own pthread_attr_t.)\n\nChange-Id: I0a4e79b83f5989249556a07eed1f2887e96c915e\nSigned-off-by: Xi Wang \u003cxi.wang@gmail.com\u003e\n" }, { "commit": "5419b9474753d25dff947c7740532f86d130c0be", "tree": "4d746cfc20a1d3b5886f691ed1a49ddf34e2df78", "parents": [ "a9944cfe9e152ca46afb0a77300ec5a2a1a24e64" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Oct 16 15:54:46 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue Oct 16 17:58:17 2012 -0700" }, "message": "Make dlerror(3) thread-safe.\n\nI gave up trying to use the usual thread-local buffer idiom; calls to\ncalloc(3) and free(3) from any of the \"dl\" functions -- which live in\nthe dynamic linker -- end up resolving to the dynamic linker\u0027s stubs.\nI tried to work around that, but was just making things more complicated.\nThis alternative costs us a well-known TLS slot (instead of the\ndynamically-allocated TLS slot we\u0027d have used otherwise, so no difference\nthere), plus an extra buffer inside every pthread_internal_t.\n\nBug: 5404023\nChange-Id: Ie9614edd05b6d1eeaf7bf9172792d616c6361767\n" }, { "commit": "bfeab1bbe7e8d0c08b7e3f46aedab64e3b2bf706", "tree": "d7ee2fec0079394cfacebdc632036a53f079c011", "parents": [ "ff4608ae0cb78caa05b83e109fc2633682958089" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Sep 05 17:47:37 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Wed Sep 05 17:47:37 2012 -0700" }, "message": "Don\u0027t corrupt the thread list in static executables.\n\nSeveral previous changes conspired to make a mess of the thread list\nin static binaries. This was most obvious when trying to call\npthread_key_delete(3) on the main thread.\n\nBug: http://code.google.com/p/android/issues/detail?id\u003d36893\nChange-Id: I2a2f553114d8fb40533c481252b410c10656da2e\n" }, { "commit": "9c3eca7bcee694e6a477a7d50065f11cf1e805bb", "tree": "abb36a7c1f2f13d54caad0f5a8175e47dd153730", "parents": [ "ff0d1ce4dfceb35a65440259c3f325106fc9e39b", "6cf3c7c50a4b9bc8425562c542f6a3d320db70c3" ], "author": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue May 08 13:26:28 2012 -0700" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue May 08 13:26:28 2012 -0700" }, "message": "resolved conflicts for merge of 6cf3c7c5 to jb-dev-plus-aosp\n\nChange-Id: Ib22a8ae1ef63bf9b9c82ce6e22afd188ba7c2806\n" }, { "commit": "d0c884d3595ecca03c3e70de9909c090cd5f9cae", "tree": "a15fbefbe3ffcf1fc111ec284a1c62dcf3beddc6", "parents": [ "e3bc7192ec4254bed00eb8b352735665c6072995" ], "author": { "name": "Pierre Peiffer", "email": "pierre.peiffer@stericsson.com", "time": "Wed Feb 22 16:40:15 2012 +0100" }, "committer": { "name": "Elliott Hughes", "email": "enh@google.com", "time": "Tue May 08 10:54:51 2012 -0700" }, "message": "Let pthread_create fail if schedparam can\u0027t be set\n\nThe creation of a thread succeeds even if the requested scheduling\nparameters can not be set. This is not POSIX compliant, and even\nworse, it leads to a wrong behavior. Let pthread_create() fail in this\ncase.\n\nChange-Id: Ice66e2a720975c6bde9fe86c2cf8f649533a169c\nSigned-off-by: Christian Bejram \u003cchristian.bejram@stericsson.com\u003e\n" }, { "commit": "1a78fbb5c8228e4aea2a516818828b76044310f2", "tree": "4de785711dbfa8923d721f9180473328b6228a5c", "parents": [ "d5099016f70b5acbfeb969787687099df703a4f4" ], "author": { "name": "Evgeniy Stepanov", "email": "eugenis@google.com", "time": "Thu Mar 22 18:01:53 2012 +0400" }, "committer": { "name": "Evgeniy Stepanov", "email": "eugenis@google.com", "time": "Fri Apr 13 00:08:11 2012 +0400" }, "message": "Initialize TLS before any application code is run.\n\nSince e19d702b8e33, dlsym and friends use recursive mutexes that\nrequire the current thread id, which is not available before the libc\nconstructor. This prevents us from using dlsym() in .preinit_array.\n\nThis change moves TLS initialization from libc constructor to the earliest\npossible point - immediately after linker itself is relocated. As a result,\npthread_internal_t for the initial thread is available from the start.\n\nAs a bonus, values stored in TLS in .preinit_array are not lost when libc is\ninitialized.\n\nChange-Id: Iee5a710ee000173bff63e924adeb4a4c600c1e2d\n" }, { "commit": "4f086aeb4aa06e13079b7fec71a8178ceeacf318", "tree": "a6b0fbce5c6d0f507a244ef4f87ec648b7c35a76", "parents": [ "e73a571fd9b60315681eacbef5857f0f0b1ece18" ], "author": { "name": "Matt Fischer", "email": "matt.fischer@garmin.com", "time": "Fri Jun 25 14:36:39 2010 -0500" }, "committer": { "name": "Jean-Baptiste Queru", "email": "jbq@google.com", "time": "Fri Jul 23 13:10:16 2010 -0700" }, "message": "Implemented pthread_atfork()\n\nChange-Id: Ie6c0bf593315d3507b3c4a6c8903a74a1fa053db\n" }, { "commit": "3a654b1e04d4275ae315cfe1b196998acf10052c", "tree": "79ce08ac573c6c5bd7d7a65f7fdc24237c00452a", "parents": [ "03eabfe65e1e2c36f4d26c78a730fa19a3bdada3" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Wed Jun 03 19:32:37 2009 +0200" }, "committer": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Wed Jun 03 19:32:37 2009 +0200" }, "message": "Revert \"Fix the C library initialization to avoid calling static C++ constructors twice.\"\n\nThis reverts commit 03eabfe65e1e2c36f4d26c78a730fa19a3bdada3.\n" }, { "commit": "03eabfe65e1e2c36f4d26c78a730fa19a3bdada3", "tree": "b965ea27e54b0833639227c619f6e35647c92510", "parents": [ "0353195f344666256dba474a15c9ba22cf0cccc9" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Thu May 28 15:54:03 2009 +0200" }, "committer": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Tue Jun 02 23:27:44 2009 +0200" }, "message": "Fix the C library initialization to avoid calling static C++ constructors twice.\n\nThe problem was due to the fact that, in the case of dynamic executables,\nthe dynamic linker calls the DT_PREINIT_ARRAY, DT_INIT and DT_INIT_ARRAY\nconstructors when loading shared libraries and dynamic executables,\n*before* calling the executable\u0027s entry point (i.e. arch-$ARCH/bionic/crtbegin_dynamic.c)\nwhich in turns call __libc_init() in libc.so, as defined by bionic/libc_init_dynamic.c\n\nThe latter did call these constructors array again, mistakenly.\n\nThe patch also updates the documentation of many related functions.\n\nAlso adds a new section to linker/README.TXT explaining restrictions on\nC library usage.\n\nThe patch has been tested on a Dream for stability issues with\nproprietary blobs:\n\n- H264 decoding works\n- Camera + Video recording works\n- GPS works\n- Sensors work\n\nThe tests in system/extra/tests/bionic/libc/common/test_static_cpp_mutex.cpp has been\nrun and shows the static C++ constructor being called only once.\n" }, { "commit": "1dc9e472e19acfe6dc7f41e429236e7eef7ceda1", "tree": "3be0c520fae17689bbf5584e1136fb820caef26f", "parents": [ "1767f908af327fa388b1c66883760ad851267013" ], "author": { "name": "The Android Open Source Project", "email": "initial-contribution@android.com", "time": "Tue Mar 03 19:28:35 2009 -0800" }, "committer": { "name": "The Android Open Source Project", "email": "initial-contribution@android.com", "time": "Tue Mar 03 19:28:35 2009 -0800" }, "message": "auto import from //depot/cupcake/@135843\n" }, { "commit": "1767f908af327fa388b1c66883760ad851267013", "tree": "4b825dc642cb6eb9a060e54bf8d69288fbee4904", "parents": [ "a799b53f10e5a6fd51fef4436cfb7ec99836a516" ], "author": { "name": "The Android Open Source Project", "email": "initial-contribution@android.com", "time": "Tue Mar 03 18:28:13 2009 -0800" }, "committer": { "name": "The Android Open Source Project", "email": "initial-contribution@android.com", "time": "Tue Mar 03 18:28:13 2009 -0800" }, "message": "auto import from //depot/cupcake/@135843\n" }, { "commit": "4e468ed2eb86a2406e14f1eca82072ee501d05fd", "tree": "4e05b3c66eef86531e464521a3bf96a1864d4bf5", "parents": [ "a27d2baa0c1a2ec70f47ea9199b1dd6762c8a349" ], "author": { "name": "The Android Open Source Project", "email": "initial-contribution@android.com", "time": "Wed Dec 17 18:03:48 2008 -0800" }, "committer": { "name": "The Android Open Source Project", "email": "initial-contribution@android.com", "time": "Wed Dec 17 18:03:48 2008 -0800" }, "message": "Code drop from //branches/cupcake/...@124589\n" }, { "commit": "a27d2baa0c1a2ec70f47ea9199b1dd6762c8a349", "tree": "defd1cc07d16ad2f3b21154114e092d11c94c5bb", "parents": [], "author": { "name": "The Android Open Source Project", "email": "initial-contribution@android.com", "time": "Tue Oct 21 07:00:00 2008 -0700" }, "committer": { "name": "The Android Open Source Project", "email": "initial-contribution@android.com", "time": "Tue Oct 21 07:00:00 2008 -0700" }, "message": "Initial Contribution\n" } ] }