Gitiles
Code Review Sign In
review.evervolv.com / android_bootable_recovery / 0150d013eb096a85e541294ee9df320ef4227df0
commit0150d013eb096a85e541294ee9df320ef4227df0[log] [tgz]
authorTao Bao <tbao@google.com>Mon May 01 11:31:28 2017 -0700
committerTao Bao <tbao@google.com>Mon May 01 11:47:43 2017 -0700
tree09473679028a2f8a4f3bfff63da9bf05ed8eac88
parent54da1122776f38ae365f61bb0ea190b456b2fa62 [diff]
adb_install: Stop passing RecoveryUI as a parameter.

It's already a global declared in common.h which is included by
adb_install.cpp.

Remove '#include "minadbd/fuse_adb_provider.h"' that's not needed by
adb_install.cpp (minadbd takes care of that).

Test: mmma bootable/recovery
Change-Id: I6d08b7abc706b4b05de2ef46a57ced2204ad297e
3 files changed
tree: 09473679028a2f8a4f3bfff63da9bf05ed8eac88
  1. .clang-format
  2. Android.mk
  3. CleanSpec.mk
  4. NOTICE
  5. README.md
  6. adb_install.cpp
  7. adb_install.h
  8. applypatch/
  9. asn1_decoder.cpp
  10. asn1_decoder.h
  11. boot_control/
  12. bootloader.h
  13. bootloader_message/
  14. common.h
  15. default_device.cpp
  16. device.cpp
  17. device.h
  18. edify/
  19. error_code.h
  20. etc/
  21. fonts/
  22. fuse_sdcard_provider.cpp
  23. fuse_sdcard_provider.h
  24. fuse_sideload.cpp
  25. fuse_sideload.h
  26. install.cpp
  27. install.h
  28. interlace-frames.py
  29. minadbd/
  30. minui/
  31. mounts.cpp
  32. mounts.h
  33. otafault/
  34. otautil/
  35. print_sha1.h
  36. private/
  37. recovery-persist.cpp
  38. recovery-persist.rc
  39. recovery-refresh.cpp
  40. recovery-refresh.rc
  41. recovery.cpp
  42. res-560dpi ⇨ res-xxxhdpi
  43. res-hdpi/
  44. res-mdpi/
  45. res-xhdpi/
  46. res-xxhdpi/
  47. res-xxxhdpi/
  48. roots.cpp
  49. roots.h
  50. rotate_logs.cpp
  51. rotate_logs.h
  52. screen_ui.cpp
  53. screen_ui.h
  54. stub_ui.h
  55. tests/
  56. tools/
  57. ui.cpp
  58. ui.h
  59. uncrypt/
  60. update_verifier/
  61. updater/
  62. verifier.cpp
  63. verifier.h
  64. wear_touch.cpp
  65. wear_touch.h
  66. wear_ui.cpp
  67. wear_ui.h
README.md

The Recovery Image

Quick turn-around testing

mm -j && m ramdisk-nodeps && m recoveryimage-nodeps

# To boot into the new recovery image
# without flashing the recovery partition:
adb reboot bootloader
fastboot boot $ANDROID_PRODUCT_OUT/recovery.img

Running the tests

# After setting up environment and lunch.
mmma -j bootable/recovery

# Running the tests on device.
adb root
adb sync data

# 32-bit device
adb shell /data/nativetest/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest/recovery_component_test/recovery_component_test

# Or 64-bit device
adb shell /data/nativetest64/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest64/recovery_component_test/recovery_component_test

Running the manual tests

recovery-refresh and recovery-persist executables exist only on systems without /cache partition. And we need to follow special steps to run tests for them.

  • Execute the test on an A/B device first. The test should fail but it will log some contents to pmsg.

  • Reboot the device immediately and run the test again. The test should save the contents of pmsg buffer into /data/misc/recovery/inject.txt. Test will pass if this file has expected contents.

ResourceTest validates whether the png files are qualified as background text image under recovery.

1. `adb sync data` to make sure the test-dir has the images to test.
2. The test will automatically pickup and verify all `_text.png` files in
   the test dir.