Gitiles
Code Review Sign In
review.evervolv.com / android_bootable_recovery / edf1b15fefca1fa43d628a9c79d351dd960a002f
commitedf1b15fefca1fa43d628a9c79d351dd960a002f[log] [tgz]
authorTao Bao <tbao@google.com>Mon Oct 24 16:08:28 2016 -0700
committerTao Bao <tbao@google.com>Mon Oct 24 16:08:28 2016 -0700
tree09d9a2e70f8503722dfb20019a1c8af335153dd3
parentfd796317c309a9c2423d6de1b0c87d1004efbec4 [diff]
applypatch: Fix the bug when constructing VAL_BLOB.

When constructing std::string from C-string, the string may be truncated
at null char. Use range constructor instead.

Bug: 32380016
Test: Use applypatch to install a previously failed recovery image.
Change-Id: Id3e2afb4a810594243cd21db526933d1fea5044b
1 file changed
tree: 09d9a2e70f8503722dfb20019a1c8af335153dd3
  1. Android.mk
  2. CleanSpec.mk
  3. NOTICE
  4. README.md
  5. adb_install.cpp
  6. adb_install.h
  7. applypatch/
  8. asn1_decoder.cpp
  9. asn1_decoder.h
  10. bootloader.h
  11. bootloader_message/
  12. common.h
  13. default_device.cpp
  14. device.cpp
  15. device.h
  16. edify/
  17. error_code.h
  18. etc/
  19. fonts/
  20. fuse_sdcard_provider.cpp
  21. fuse_sdcard_provider.h
  22. fuse_sideload.cpp
  23. fuse_sideload.h
  24. install.cpp
  25. install.h
  26. interlace-frames.py
  27. minadbd/
  28. minui/
  29. mounts.cpp
  30. mounts.h
  31. otafault/
  32. otautil/
  33. print_sha1.h
  34. recovery-persist.cpp
  35. recovery-persist.rc
  36. recovery-refresh.cpp
  37. recovery-refresh.rc
  38. recovery.cpp
  39. res-560dpi ⇨ res-xxxhdpi
  40. res-hdpi/
  41. res-mdpi/
  42. res-xhdpi/
  43. res-xxhdpi/
  44. res-xxxhdpi/
  45. roots.cpp
  46. roots.h
  47. screen_ui.cpp
  48. screen_ui.h
  49. tests/
  50. tools/
  51. ui.cpp
  52. ui.h
  53. uncrypt/
  54. update_verifier/
  55. updater/
  56. verifier.cpp
  57. verifier.h
  58. wear_touch.cpp
  59. wear_touch.h
  60. wear_ui.cpp
  61. wear_ui.h
README.md

The Recovery Image

Quick turn-around testing

mm -j && m ramdisk-nodeps && m recoveryimage-nodeps

# To boot into the new recovery image
# without flashing the recovery partition:
adb reboot bootloader
fastboot boot $ANDROID_PRODUCT_OUT/recovery.img

Running the tests

# After setting up environment and lunch.
mmma -j bootable/recovery

# Running the tests on device.
adb root
adb sync data

# 32-bit device
adb shell /data/nativetest/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest/recovery_component_test/recovery_component_test

# Or 64-bit device
adb shell /data/nativetest64/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest64/recovery_component_test/recovery_component_test