commit 0412f73c6eb83e51832b9b7aaa57a4dc0239e6a5
author Ytai Ben-Tsvi <ytai@google.com> Mon Aug 17 14:43:36 2020 -0700
committer Ytai Ben-Tsvi <ytai@google.com> Fri Sep 11 12:39:20 2020 -0700
tree 4c0803d4e215de220b0c2c15ca50c79959f47eda
parent 10a7efe0387b11acc57cf6cea3f2ae594b1d8907

Convert IAAudioClient to AIDL

Bug: 160253486
Test: Manual testing using OboeTester
      Ran atest CtsNativeMediaAAudioTestCases
Change-Id: I18e6c03144c59ce78181abf7c509c21f2724ad22

media/libaaudio/src/binding/AAudioBinderClient.h

diff --git a/media/libaaudio/src/binding/AAudioBinderClient.h b/media/libaaudio/src/binding/AAudioBinderClient.h
index e8c91fc..a9a621e 100644
--- a/media/libaaudio/src/binding/AAudioBinderClient.h
+++ b/media/libaaudio/src/binding/AAudioBinderClient.h
@@ -21,6 +21,7 @@
 #include <utils/Singleton.h>
 
 #include <aaudio/AAudio.h>
+#include "aaudio/BnAAudioClient.h"
 #include "AAudioServiceDefinitions.h"
 #include "AAudioServiceInterface.h"
 #include "binding/AAudioStreamRequest.h"
@@ -48,7 +49,7 @@
 
     void dropAAudioService();
 
-    void registerClient(const android::sp<android::IAAudioClient>& client __unused) override {}
+    void registerClient(const android::sp<IAAudioClient>& client __unused) override {}
 
     /**
      * @param request info needed to create the stream
@@ -115,7 +116,7 @@
         ALOGW("onStreamChange called!");
     }
 
-    class AAudioClient : public android::IBinder::DeathRecipient , public android::BnAAudioClient
+    class AAudioClient : public android::IBinder::DeathRecipient , public BnAAudioClient
     {
     public:
         AAudioClient(android::wp<AAudioBinderClient> aaudioBinderClient)
@@ -132,11 +133,13 @@
         }
 
         // implement BnAAudioClient
-        void onStreamChange(aaudio_handle_t handle, int32_t opcode, int32_t value) {
+        android::binder::Status onStreamChange(int32_t handle, int32_t opcode, int32_t value) {
+            static_assert(std::is_same_v<aaudio_handle_t, int32_t>);
             android::sp<AAudioBinderClient> client = mBinderClient.promote();
             if (client.get() != nullptr) {
                 client->onStreamChange(handle, opcode, value);
             }
+            return android::binder::Status::ok();
         }
     private:
         android::wp<AAudioBinderClient> mBinderClient;