commit 197d50a057100d12997099b8dc73e988e7fcea21
author Mikhail Naganov <mnaganov@google.com> Thu Apr 30 22:37:43 2020 +0000
committer Mikhail Naganov <mnaganov@google.com> Fri May 01 16:27:08 2020 -0700
tree 07682097b9b7f1319b90223a4a8ca23f9d6aea5c
parent da6850898bbd65edc388cc4f1d536f5d3a6ecc86

Enforce basic thread safety in Audio Policy Service

Enable clang thread safety analysis. Convert comments on TS
into directives. Fix missing lock acquisitions. Add missing
default initializers for the fields of UidPolicy and
SensorPrivacyPolicy

Also remove unused fields mpAudioPolicyDev and mpAudioPolicy
from AudioPolicyService.

TODO: Consider protecting pointers to command threads,
APM instance and the client, and system usages with a separate
lock.

Bug: 70398235
Bug: 155336464
Test: make, flash, and test audio on device
      execute "adb shell cmd media.audio_policy" commands
Change-Id: I47b132c8b5c977812fad5c89fa57882a37779c18

services/audiopolicy/service/Android.bp

diff --git a/services/audiopolicy/service/Android.bp b/services/audiopolicy/service/Android.bp
index 6ee573f..8a7a1b2 100644
--- a/services/audiopolicy/service/Android.bp
+++ b/services/audiopolicy/service/Android.bp
@@ -46,6 +46,7 @@
         "-fvisibility=hidden",
         "-Werror",
         "-Wall",
+        "-Wthread-safety",
     ],
 
     export_shared_lib_headers: [