commit 2461e0cf6ae3fe5c9b52ce9e3ac764f4aff5e5eb
author Lajos Molnar <lajos@google.com> Tue Aug 12 08:55:25 2014 -0700
committer Lajos Molnar <lajos@google.com> Tue Aug 12 16:30:40 2014 +0000
tree 449c2a4029cc6e8048b9d9d373078e5830bd9404
parent e7a1737c92cf2e84754ffbc52cfec8edeffcbc75

MediaCodecList: don't return references

Bug: 16905025
Change-Id: I5b42b294f0cc785b8e4dda0e82c8f8377a46f487

include/media/MediaCodecInfo.h

diff --git a/include/media/MediaCodecInfo.h b/include/media/MediaCodecInfo.h
index 29315ce..b4916af 100644
--- a/include/media/MediaCodecInfo.h
+++ b/include/media/MediaCodecInfo.h
@@ -45,7 +45,7 @@
         void getSupportedProfileLevels(Vector<ProfileLevel> *profileLevels) const;
         void getSupportedColorFormats(Vector<uint32_t> *colorFormats) const;
         uint32_t getFlags() const;
-        const sp<AMessage> &getDetails() const;
+        const sp<AMessage> getDetails() const;
 
     private:
         Vector<ProfileLevel> mProfileLevels;
@@ -67,7 +67,7 @@
     bool isEncoder() const;
     bool hasQuirk(const char *name) const;
     void getSupportedMimes(Vector<AString> *mimes) const;
-    const sp<Capabilities> &getCapabilitiesFor(const char *mime) const;
+    const sp<Capabilities> getCapabilitiesFor(const char *mime) const;
     const char *getCodecName() const;
 
     /**

media/libmedia/MediaCodecInfo.cpp

diff --git a/media/libmedia/MediaCodecInfo.cpp b/media/libmedia/MediaCodecInfo.cpp
index 7900eae..5ea0519 100644
--- a/media/libmedia/MediaCodecInfo.cpp
+++ b/media/libmedia/MediaCodecInfo.cpp
@@ -46,7 +46,7 @@
     return mFlags;
 }
 
-const sp<AMessage> &MediaCodecInfo::Capabilities::getDetails() const {
+const sp<AMessage> MediaCodecInfo::Capabilities::getDetails() const {
     return mDetails;
 }
 
@@ -121,7 +121,7 @@
     }
 }
 
-const sp<MediaCodecInfo::Capabilities> &
+const sp<MediaCodecInfo::Capabilities>
 MediaCodecInfo::getCapabilitiesFor(const char *mime) const {
     ssize_t ix = getCapabilityIndex(mime);
     if (ix >= 0) {