Nuplayer logging empty records to media.metrics
Changes to ensure that nuplayer always reported a particular set
of metrics through android.media.MediaPlayer.getMetrics() changed
the shape of what we should have considered as an empty record.
This caused some noise in the reported media metrics logs.
Also removed a no-longer-wanted ALOGD() diagnostic.
Bug: 36658856
Test: read 'dumpsys media.metrics' output
(cherry picked from commit e4ae17109893b6388299a1f46585fb5d00a0a70e)
Change-Id: I2400e3636bb395aa5f46faf0142b2767f4fad610
diff --git a/media/libmediaplayerservice/nuplayer/NuPlayer.cpp b/media/libmediaplayerservice/nuplayer/NuPlayer.cpp
index 50d5343..510794c 100644
--- a/media/libmediaplayerservice/nuplayer/NuPlayer.cpp
+++ b/media/libmediaplayerservice/nuplayer/NuPlayer.cpp
@@ -1535,8 +1535,6 @@
if (driver != NULL) {
int64_t now = systemTime();
int64_t played = now - mLastStartedPlayingTimeNs;
- ALOGD("played from %" PRId64 " to %" PRId64 " = %" PRId64 ,
- mLastStartedPlayingTimeNs, now, played);
driver->notifyMorePlayingTimeUs((played+500)/1000);
}
diff --git a/media/libmediaplayerservice/nuplayer/NuPlayerDriver.cpp b/media/libmediaplayerservice/nuplayer/NuPlayerDriver.cpp
index 66b64f8..01008b4 100644
--- a/media/libmediaplayerservice/nuplayer/NuPlayerDriver.cpp
+++ b/media/libmediaplayerservice/nuplayer/NuPlayerDriver.cpp
@@ -583,8 +583,12 @@
return;
}
- // only bother to log non-empty records
- if (mAnalyticsItem->count() > 0) {
+ // log only non-empty records
+ // we always updateMetrics() before we get here
+ // and that always injects 2 fields (duration and playing time) into
+ // the record.
+ // So the canonical "empty" record has 2 elements in it.
+ if (mAnalyticsItem->count() > 2) {
mAnalyticsItem->setFinalized(true);
mAnalyticsItem->selfrecord();