commit 3769871b5998f4bbe6d8fe7c124ee97daa6e7fab
author Eric Laurent <elaurent@google.com> Wed Sep 07 16:58:39 2016 -0700
committer Eric Laurent <elaurent@google.com> Thu Sep 08 14:52:16 2016 +0000
tree 12c96899b39577e32fffe8b08e39e115bd228e2b
parent b6c83b60418d531e8010f515b4bd18ffd8f1b791

Radio, SoundTrigger: get service by value.

Get strong pointer to service interface by value and not reference to
prevent race conditions where the service pointer can be cleared
by another thread while in use.

Bug: 30907212
Change-Id: I6f02ec3fd1e6392b842b334e1cc4f9aa23916009

include/soundtrigger/SoundTrigger.h

diff --git a/include/soundtrigger/SoundTrigger.h b/include/soundtrigger/SoundTrigger.h
index bf5e1de..9a05cac 100644
--- a/include/soundtrigger/SoundTrigger.h
+++ b/include/soundtrigger/SoundTrigger.h
@@ -68,7 +68,7 @@
 private:
             SoundTrigger(sound_trigger_module_handle_t module,
                             const sp<SoundTriggerCallback>&);
-            static const sp<ISoundTriggerHwService>& getSoundTriggerHwService();
+            static const sp<ISoundTriggerHwService> getSoundTriggerHwService();
 
             Mutex                               mLock;
             sp<ISoundTrigger>                   mISoundTrigger;