commit 48fc6191823ffa0708f60802fb6724c232760b9a
author Chih-Hung Hsieh <chh@google.com> Fri Aug 04 14:37:31 2017 -0700
committer Chih-Hung Hsieh <chh@google.com> Fri Aug 04 14:58:41 2017 -0700
tree c4b5ac89c6bb9798f20fa29b392306027003c4a2
parent b95106cabbe51d440505e5b97c55a3afebd49af9

Fix performance-for-range-copy warnings in frameworks/av.

* Use const reference type for loop index variables to avoid unnecessary copy.

Bug: 30413223
Test: build with WITH_TIDY=1
Change-Id: I79969be18569c5bb1ea29ee18ae89a3f9d55ce9c

services/oboeservice/AAudioServiceEndpoint.cpp

diff --git a/services/oboeservice/AAudioServiceEndpoint.cpp b/services/oboeservice/AAudioServiceEndpoint.cpp
index 81f1d1b..5a78e11 100644
--- a/services/oboeservice/AAudioServiceEndpoint.cpp
+++ b/services/oboeservice/AAudioServiceEndpoint.cpp
@@ -65,7 +65,7 @@
 
     result << "    Registered Streams:" << "\n";
     result << AAudioServiceStreamShared::dumpHeader() << "\n";
-    for (sp<AAudioServiceStreamShared> sharedStream : mRegisteredStreams) {
+    for (const sp<AAudioServiceStreamShared>& sharedStream : mRegisteredStreams) {
         result << sharedStream->dump() << "\n";
     }
 
@@ -158,7 +158,7 @@
 
 void AAudioServiceEndpoint::disconnectRegisteredStreams() {
     std::lock_guard<std::mutex> lock(mLockStreams);
-    for(auto sharedStream : mRegisteredStreams) {
+    for(const auto& sharedStream : mRegisteredStreams) {
         sharedStream->stop();
         sharedStream->disconnect();
     }