| commit | 5404ee174dd6b5e312d3a97bc63c2bc8d142012b | [log] [tgz] |
|---|---|---|
| author | Chih-Hung Hsieh <chh@google.com> | Tue Aug 09 14:25:53 2016 -0700 |
| committer | Chih-hung Hsieh <chh@google.com> | Wed Aug 10 17:28:17 2016 +0000 |
| tree | f91538f49c70a4730b3806617b1cdf11328e8b55 | |
| parent | 67fbddfdc2cafd63c83d3bb55a2451d4c26f546d [diff] [blame] |
Fix clang-tidy warnings in camera. * Add explicit keyword to conversion constructors. Bug: 28341362 * Use const reference type for read-only parameters. Bug: 30407689 * Use const reference type to avoid unnecessary copy. Bug: 30413862 Test: build with WITH_TIDY=1 Change-Id: I71d3008da843ba5f1df1a73a320fb2af6ceffa16 Merged-In: I71d3008da843ba5f1df1a73a320fb2af6ceffa16
diff --git a/services/camera/libcameraservice/CameraService.h b/services/camera/libcameraservice/CameraService.h index ec8c5e9..269507e 100644 --- a/services/camera/libcameraservice/CameraService.h +++ b/services/camera/libcameraservice/CameraService.h
@@ -265,7 +265,7 @@ class OpsCallback : public BnAppOpsCallback { public: - OpsCallback(wp<BasicClient> client); + explicit OpsCallback(wp<BasicClient> client); virtual void opChanged(int32_t op, const String16& packageName); private: