commit 58a37f8bb8032c4bb2e7cc6bd00d28c1841e7acb
author Robert Shih <robertshih@google.com> Mon Apr 19 10:18:50 2021 -0700
committer Robert Shih <robertshih@google.com> Mon Apr 19 11:56:28 2021 -0700
tree bc1aec39b485a926ea12f225064fabc91e56f079
parent 9a37b24337bd24c008f3650ccbf2e2d832d16f2a

statsd_drm: skip empty pulled atoms

Bug: 184263266
Test: Local Testing of New Atoms/Metrics
Test: http://doc/1pY7g5Xl0_aZ8JC6chQWUg9LHeBsjf2rNtqdc62IMIo8
Change-Id: I789cf3fba8d1ce3ee7477026ee3bd5d57d70b601

services/mediametrics/MediaMetricsService.cpp

diff --git a/services/mediametrics/MediaMetricsService.cpp b/services/mediametrics/MediaMetricsService.cpp
index 5e672ee..1d64878 100644
--- a/services/mediametrics/MediaMetricsService.cpp
+++ b/services/mediametrics/MediaMetricsService.cpp
@@ -545,12 +545,13 @@
         return AStatsManager_PULL_SKIP;
     }
     std::lock_guard _l(mLock);
+    bool dumped = false;
     for (auto &item : mPullableItems[key]) {
         if (const auto sitem = item.lock()) {
-            dump2Statsd(sitem, data, mStatsdLog);
+            dumped |= dump2Statsd(sitem, data, mStatsdLog);
         }
     }
     mPullableItems[key].clear();
-    return AStatsManager_PULL_SUCCESS;
+    return dumped ? AStatsManager_PULL_SUCCESS : AStatsManager_PULL_SKIP;
 }
 } // namespace android