commit 6a3052232c606bc2f74a849c6758fd44b6c01158
author Ray Essick <essick@google.com> Mon Jan 28 20:33:18 2019 -0800
committer Ray Essick <essick@google.com> Thu Jan 31 11:19:44 2019 -0800
tree 529ee3bb94a17c06e19c8642daf9993f23d531f2
parent 2637984613a75eb2640a73e186a6dd1f08cebbc0

use MediaAnalyticsItem::create() instead of new

Bug: 123543489
Test: boot/logcat, select CtsMediaTests
Change-Id: I92f8b9987b78466fae74ce4c0b177f8bb1e7dea8

media/libmediametrics/include/MediaAnalyticsItem.h

diff --git a/media/libmediametrics/include/MediaAnalyticsItem.h b/media/libmediametrics/include/MediaAnalyticsItem.h
index 2f9e7c2..4a36f6a 100644
--- a/media/libmediametrics/include/MediaAnalyticsItem.h
+++ b/media/libmediametrics/include/MediaAnalyticsItem.h
@@ -82,16 +82,19 @@
             PROTO_LAST = PROTO_V1,
         };
 
+    private:
+        // use the ::create() method instead
+        MediaAnalyticsItem();
+        MediaAnalyticsItem(Key);
+        MediaAnalyticsItem(const MediaAnalyticsItem&);
+        MediaAnalyticsItem &operator=(const MediaAnalyticsItem&);
 
     public:
 
-        // so clients do not need to know size details
         static MediaAnalyticsItem* create(Key key);
         static MediaAnalyticsItem* create();
 
         // access functions for the class
-        MediaAnalyticsItem();
-        MediaAnalyticsItem(Key);
         ~MediaAnalyticsItem();
 
         // SessionID ties multiple submissions for same key together