commit 6f51c153ea5e4187a313e47ac8bad9a1a999d4e1
author Colin Cross <ccross@android.com> Fri Apr 28 12:46:17 2017 -0700
committer Colin Cross <ccross@android.com> Fri Apr 28 16:41:36 2017 -0700
tree ca8da064baf8dd1602966a377d6c5ae804e663db
parent f461f38e08ca8afb89e1dc33beae43905f47f9f8

Fix non-trivial warnings hidden by -isystem

These warnings were hidden by -isystem.

Bug: 31751828
Test: m -j checkbuild
Change-Id: Ibb1aa07a6827fcbd29fc15291fcd90280c0f608d

media/libnbaio/NBLog.cpp

diff --git a/media/libnbaio/NBLog.cpp b/media/libnbaio/NBLog.cpp
index c91f467..5413007 100644
--- a/media/libnbaio/NBLog.cpp
+++ b/media/libnbaio/NBLog.cpp
@@ -1239,7 +1239,6 @@
 // ---------------------------------------------------------------------------
 
 NBLog::Merger::Merger(const void *shared, size_t size):
-      mBuffer(NULL),
       mShared((Shared *) shared),
       mFifo(mShared != NULL ?
         new audio_utils_fifo(size, sizeof(uint8_t),

media/libnbaio/include/NBLog.h

diff --git a/media/libnbaio/include/NBLog.h b/media/libnbaio/include/NBLog.h
index dd240ea..68c31af 100644
--- a/media/libnbaio/include/NBLog.h
+++ b/media/libnbaio/include/NBLog.h
@@ -133,6 +133,7 @@
 
     // Entry starting in the given pointer
     explicit AbstractEntry(const uint8_t *entry);
+    virtual ~AbstractEntry() {}
 
     // build concrete entry of appropriate class from pointer
     static std::unique_ptr<AbstractEntry> buildEntry(const uint8_t *ptr);
@@ -164,6 +165,7 @@
 public:
     // explicit FormatEntry(const EntryIterator &it);
     explicit FormatEntry(const uint8_t *ptr) : AbstractEntry(ptr) {}
+    virtual ~FormatEntry() {}
 
     // Entry's format string
     const   char* formatString() const;
@@ -196,6 +198,7 @@
 public:
     explicit HistogramEntry(const uint8_t *ptr) : AbstractEntry(ptr) {
     }
+    virtual ~HistogramEntry() {}
 
     virtual int64_t     timestamp() const override;
 
@@ -516,7 +519,6 @@
     std::vector<NamedReader> mNamedReaders;
 
     // TODO Need comments on all of these
-    uint8_t *mBuffer;
     Shared * const mShared;
     std::unique_ptr<audio_utils_fifo> mFifo;
     std::unique_ptr<audio_utils_fifo_writer> mFifoWriter;