Camera2: Emit ShutterCallback/RawCallback events after takePicture
Bug: 7176692
Change-Id: I50e8f9511f1770d97a42d1fa208c04b1bbcfba6b
diff --git a/services/camera/libcameraservice/camera2/CaptureSequencer.cpp b/services/camera/libcameraservice/camera2/CaptureSequencer.cpp
index bdd8fa9..6d7c54f 100644
--- a/services/camera/libcameraservice/camera2/CaptureSequencer.cpp
+++ b/services/camera/libcameraservice/camera2/CaptureSequencer.cpp
@@ -308,9 +308,8 @@
}
SharedParameters::Lock l(client->getParameters());
- if (l.mParameters.playShutterSound) {
- client->getCameraService()->playSound(CameraService::SOUND_SHUTTER);
- }
+ /* warning: this also locks a SharedCameraClient */
+ shutterNotifyLocked(l.mParameters, client);
mTimeoutCount = kMaxTimeoutsForCaptureEnd;
return STANDARD_CAPTURE_WAIT;
@@ -443,10 +442,8 @@
return DONE;
}
- if (l.mParameters.playShutterSound &&
- l.mParameters.state == Parameters::STILL_CAPTURE) {
- client->getCameraService()->playSound(CameraService::SOUND_SHUTTER);
- }
+ /* warning: this also locks a SharedCameraClient */
+ shutterNotifyLocked(l.mParameters, client);
mTimeoutCount = kMaxTimeoutsForCaptureEnd;
return STANDARD_CAPTURE_WAIT;
@@ -632,6 +629,32 @@
return OK;
}
+/*static*/ void CaptureSequencer::shutterNotifyLocked(const Parameters ¶ms,
+ sp<Camera2Client> client) {
+ ATRACE_CALL();
+
+ if (params.state == Parameters::STILL_CAPTURE && params.playShutterSound) {
+ client->getCameraService()->playSound(CameraService::SOUND_SHUTTER);
+ }
+
+ {
+ Camera2Client::SharedCameraClient::Lock l(client->mSharedCameraClient);
+
+ ALOGV("%s: Notifying of shutter close to client", __FUNCTION__);
+ if (l.mCameraClient != 0) {
+ // ShutterCallback
+ l.mCameraClient->notifyCallback(CAMERA_MSG_SHUTTER,
+ /*ext1*/0, /*ext2*/0);
+
+ // RawCallback with null buffer
+ l.mCameraClient->notifyCallback(CAMERA_MSG_RAW_IMAGE_NOTIFY,
+ /*ext1*/0, /*ext2*/0);
+ } else {
+ ALOGV("%s: No client!", __FUNCTION__);
+ }
+ }
+}
+
}; // namespace camera2
}; // namespace android