commit 72ee01deddaecbfb8766b3acdc60cc04f1bad24e
author Mikhail Naganov <mnaganov@google.com> Thu Mar 26 13:07:31 2020 -0700
committer Mikhail Naganov <mnaganov@google.com> Thu Mar 26 14:48:33 2020 -0700
tree 831f8c8545fd20db5ae664168b19269d9fedb979
parent 379d687ba8c831cedf406d95309c4e7a6f66639d

TimeCheck: fix use of uninitialized variable

Variable 'tag' in TimeCheck::TimeCheckThread::threadLoop
may end up being used w/o prior initialization.
Found by clang-tidy.

Bug: 152526318
Test: m
Change-Id: Ifc1efbee39007ea9cfba8083edbfdb763eafb8dc

media/utils/TimeCheck.cpp

diff --git a/media/utils/TimeCheck.cpp b/media/utils/TimeCheck.cpp
index 4a3e470..59d74de 100644
--- a/media/utils/TimeCheck.cpp
+++ b/media/utils/TimeCheck.cpp
@@ -100,7 +100,6 @@
 bool TimeCheck::TimeCheckThread::threadLoop()
 {
     status_t status = TIMED_OUT;
-    const char *tag;
     {
         AutoMutex _l(mMutex);
 
@@ -109,6 +108,7 @@
         }
 
         nsecs_t endTimeNs = INT64_MAX;
+        const char *tag = "<unspecified>";
         // KeyedVector mMonitorRequests is ordered so take first entry as next timeout
         if (mMonitorRequests.size() != 0) {
             endTimeNs = mMonitorRequests.keyAt(0);