Validate audio data instead of santinize in binder call.
In binder call, if the data is silently santinized, there may be
unexpected behavior. In that case, it is better to just validate the
data and returned error code if there is any error with the data.
Test: audio smoke test
Bug: 174189330
Change-Id: I2f0534f3013f9127a441306c3ff7d5ca8cc0e223
diff --git a/media/libaudioclient/IAudioFlinger.cpp b/media/libaudioclient/IAudioFlinger.cpp
index adb16d4..771cfd9 100644
--- a/media/libaudioclient/IAudioFlinger.cpp
+++ b/media/libaudioclient/IAudioFlinger.cpp
@@ -24,7 +24,7 @@
#include <binder/IPCThreadState.h>
#include <binder/Parcel.h>
-#include <media/AudioSanitizer.h>
+#include <media/AudioValidator.h>
#include <media/IAudioPolicyService.h>
#include <mediautils/ServiceUtilities.h>
#include <mediautils/TimeCheck.h>
@@ -1651,7 +1651,7 @@
ALOGE("b/23905951");
return status;
}
- status = AudioSanitizer::sanitizeAudioPort(&port);
+ status = AudioValidator::validateAudioPort(port);
if (status == NO_ERROR) {
status = getAudioPort(&port);
}
@@ -1674,7 +1674,7 @@
ALOGE("b/23905951");
return status;
}
- status = AudioSanitizer::sanitizeAudioPatch(&patch);
+ status = AudioValidator::validateAudioPatch(patch);
if (status == NO_ERROR) {
status = createAudioPatch(&patch, &handle);
}
@@ -1726,7 +1726,7 @@
if (status != NO_ERROR) {
return status;
}
- status = AudioSanitizer::sanitizeAudioPortConfig(&config);
+ status = AudioValidator::validateAudioPortConfig(config);
if (status == NO_ERROR) {
status = setAudioPortConfig(&config);
}