commit 8a4b3d40a6a1f52b897a0ac49605c1b708e01876
author George Burgess IV <gbiv@google.com> Tue Aug 29 15:26:19 2017 -0700
committer George Burgess IV <gbiv@google.com> Tue Aug 29 17:33:32 2017 -0700
tree 28c8a07aab860ac9c12e3b73237bdd5e8503d44f
parent 0fdeb09e898c39d9e353311577b72f1a53bc11f3

img_utils: fix static analyzer complaints

Due to https://bugs.llvm.org/show_bug.cgi?id=34365, the static analyzer
complains about use of copied `sp`s. In this case, the copy is entirely
unnecessary, since we're just going to destroy the copied-from sp
anyway.

Speed things up a bit + appease the analyzer by moving instead.

Bug: 27101951
Test: mma. Static analyzer no longer complains.
Change-Id: I08f77c2509dc03a919238b97666be3f458ba7cf3

media/img_utils/src/TiffWriter.cpp

diff --git a/media/img_utils/src/TiffWriter.cpp b/media/img_utils/src/TiffWriter.cpp
index 564474f..1711242 100644
--- a/media/img_utils/src/TiffWriter.cpp
+++ b/media/img_utils/src/TiffWriter.cpp
@@ -350,7 +350,7 @@
         if (nextIfd == NULL) {
             break;
         }
-        ifd = nextIfd;
+        ifd = std::move(nextIfd);
     }
     return ifd;
 }