commit 93e471f620454f7de73d190521568b1e25879767
author Glenn Kasten <gkasten@google.com> Mon Aug 19 08:40:07 2013 -0700
committer Glenn Kasten <gkasten@google.com> Mon Nov 04 15:48:55 2013 -0800
tree 42b6c50f27f85233ba0967619ce8a6eeebe11f3f
parent d21952fe5bc94f7bb6ee729f806c0e641fdb1a0d

Rename standby methods

ThreadBase::standby() returns the value of mStandby.

RecordThread::standby() "overrode" ThreadBase::standby(), but with a
different meaning and no return value.  This meant you couldn't
access the parent's class definition within RecordThread.

This could be confusing, so this CL renames RecordThread::standby()
to standbyIfNotAlreadyInStandby().

Change-Id: I9196ee12701dd2dccdfaed922af2d7b8e8774676

services/audioflinger/Threads.cpp

diff --git a/services/audioflinger/Threads.cpp b/services/audioflinger/Threads.cpp
index ef90952..59afee8 100644
--- a/services/audioflinger/Threads.cpp
+++ b/services/audioflinger/Threads.cpp
@@ -4445,7 +4445,7 @@
             // make a stable copy of mActiveTrack
             activeTrack = mActiveTrack;
             if (activeTrack == 0) {
-                standby();
+                standbyIfNotAlreadyInStandby();
                 // exitPending() can't become true here
                 releaseWakeLock_l();
                 ALOGV("RecordThread: loop stopping");
@@ -4465,7 +4465,7 @@
             activeTrackState = activeTrack->mState;
             switch (activeTrackState) {
             case TrackBase::PAUSING:
-                standby();
+                standbyIfNotAlreadyInStandby();
                 mActiveTrack.clear();
                 mStartStopCond.broadcast();
                 doSleep = true;
@@ -4642,7 +4642,7 @@
         // effectChains doesn't need to be cleared, since it is cleared by destructor at scope end
     }
 
-    standby();
+    standbyIfNotAlreadyInStandby();
 
     {
         Mutex::Autolock _l(mLock);
@@ -4660,7 +4660,7 @@
     return false;
 }
 
-void AudioFlinger::RecordThread::standby()
+void AudioFlinger::RecordThread::standbyIfNotAlreadyInStandby()
 {
     if (!mStandby) {
         inputStandBy();

services/audioflinger/Threads.h

diff --git a/services/audioflinger/Threads.h b/services/audioflinger/Threads.h
index 8a859f5..cbc3827 100644
--- a/services/audioflinger/Threads.h
+++ b/services/audioflinger/Threads.h
@@ -931,7 +931,7 @@
             void    clearSyncStartEvent();
 
             // Enter standby if not already in standby, and set mStandby flag
-            void    standby();
+            void    standbyIfNotAlreadyInStandby();
 
             // Call the HAL standby method unconditionally, and don't change mStandby flag
             void    inputStandBy();