commit 9fb7fa159b2a47d6a7c0e9ef323b23298cdc7cb9
author Igor Murashkin <iam@google.com> Wed Feb 20 19:02:36 2013 -0800
committer Igor Murashkin <iam@google.com> Fri Feb 22 10:50:14 2013 -0800
tree e4956f65799199fe24373001c80a398756914a69
parent 69e22433b9d7df77907579f67e47a159aa57f876

Camera: ProCamera2Client implement createStream,createDefaultRequest

The StreamingImage unit test should now work when TEST_DISPLAY_SECS is set.

Change-Id: I9cf3ad5bd5a76096ab21bd39e631d636c4ff3d3f

services/camera/libcameraservice/ProCamera2Client.cpp

diff --git a/services/camera/libcameraservice/ProCamera2Client.cpp b/services/camera/libcameraservice/ProCamera2Client.cpp
index d6389a1..5ebe713 100644
--- a/services/camera/libcameraservice/ProCamera2Client.cpp
+++ b/services/camera/libcameraservice/ProCamera2Client.cpp
@@ -194,8 +194,15 @@
         return PERMISSION_DENIED;
     }
 
-    ALOGE("%s: not fully implemented yet", __FUNCTION__);
-    free_camera_metadata(request);
+    CameraMetadata metadata(request);
+
+    if (streaming) {
+        return mDevice->setStreamingRequest(metadata);
+    } else {
+        return mDevice->capture(metadata);
+    }
+
+    // unreachable. thx gcc for a useless warning
     return OK;
 }
 
@@ -209,7 +216,7 @@
     }
 
     ALOGE("%s: not fully implemented yet", __FUNCTION__);
-    return OK;
+    return INVALID_OPERATION;
 }
 
 status_t ProCamera2Client::requestStream(int streamId) {
@@ -219,32 +226,63 @@
 }
 
 status_t ProCamera2Client::cancelStream(int streamId) {
-    ALOGE("%s: not implemented yet", __FUNCTION__);
+    ATRACE_CALL();
+    ALOGV("%s (streamId = 0x%x)", __FUNCTION__, streamId);
 
-    return INVALID_OPERATION;
+    status_t res;
+    if ( (res = checkPid(__FUNCTION__) ) != OK) return res;
+
+    Mutex::Autolock icl(mIProCameraUserLock);
+
+    return mDevice->deleteStream(streamId);
 }
 
 status_t ProCamera2Client::createStream(int width, int height, int format,
-                                        const sp<Surface>& surface,
-                                        /*out*/
-                                        int* streamId) {
-    ALOGE("%s: not implemented yet", __FUNCTION__);
+                      const sp<Surface>& surface,
+                      /*out*/
+                      int* streamId)
+{
+    if (streamId) {
+        *streamId = -1;
+    }
 
-    return INVALID_OPERATION;
+    ATRACE_CALL();
+    ALOGV("%s (w = %d, h = %d, f = 0x%x)", __FUNCTION__, width, height, format);
+
+    status_t res;
+    if ( (res = checkPid(__FUNCTION__) ) != OK) return res;
+
+    Mutex::Autolock icl(mIProCameraUserLock);
+
+    return mDevice->createStream(surface, width, height, format, /*size*/1, streamId);
 }
 
+// Create a request object from a template.
+// -- Caller owns the newly allocated metadata
 status_t ProCamera2Client::createDefaultRequest(int templateId,
-                                               /*out*/
-                                               camera_metadata** request) {
-    ALOGE("%s: not implemented yet", __FUNCTION__);
+                             /*out*/
+                              camera_metadata** request)
+{
+    ATRACE_CALL();
+    ALOGV("%s (templateId = 0x%x)", __FUNCTION__, templateId);
 
-    return INVALID_OPERATION;
+    if (request) {
+        *request = NULL;
+    }
+
+    status_t res;
+    if ( (res = checkPid(__FUNCTION__) ) != OK) return res;
+
+    Mutex::Autolock icl(mIProCameraUserLock);
+
+    CameraMetadata metadata;
+    if ( (res = mDevice->createDefaultRequest(templateId, &metadata) ) == OK) {
+        *request = metadata.release();
+    }
+
+    return res;
 }
 
-
-
-
-
 status_t ProCamera2Client::dump(int fd, const Vector<String16>& args) {
     String8 result;
     result.appendFormat("ProCamera2Client[%d] (%p) PID: %d, dump:\n",

services/camera/libcameraservice/ProCamera2Client.h

diff --git a/services/camera/libcameraservice/ProCamera2Client.h b/services/camera/libcameraservice/ProCamera2Client.h
index 8f76819..ed42e22 100644
--- a/services/camera/libcameraservice/ProCamera2Client.h
+++ b/services/camera/libcameraservice/ProCamera2Client.h
@@ -58,6 +58,7 @@
                                        int* streamId);
 
     // Create a request object from a template.
+    // -- Caller owns the newly allocated metadata
     virtual status_t      createDefaultRequest(int templateId,
                                                /*out*/
                                                camera_metadata** request);