av: remove a redundant NULL check
The unconditional `readInputParameters_l` call below this condition
immediately and unconditionally dereferences `mInput`. Either
`readInputParameters_l` needs to handle a null `mInput` reasonably, or
`mInput` can never be null. This CL assumes the latter.
Bug: None
Test: TreeHugger
Change-Id: I46f89f918257f9d4aa762a03c3d03e030a17b4a9
diff --git a/services/audioflinger/Threads.cpp b/services/audioflinger/Threads.cpp
index cd1e1db..bf4195f 100644
--- a/services/audioflinger/Threads.cpp
+++ b/services/audioflinger/Threads.cpp
@@ -6725,7 +6725,7 @@
snprintf(mThreadName, kThreadNameLength, "AudioIn_%X", id);
mNBLogWriter = audioFlinger->newWriter_l(kLogSize, mThreadName);
- if (mInput != nullptr && mInput->audioHwDev != nullptr) {
+ if (mInput->audioHwDev != nullptr) {
mIsMsdDevice = strcmp(
mInput->audioHwDev->moduleName(), AUDIO_HARDWARE_MODULE_ID_MSD) == 0;
}