EffectModule: Update mConfig initialization
Use aggregate-initialization of mConfig to zero.
Test: instrumented memcmp with static decltype(mConfig) ZERO
Bug: 70674145
Change-Id: Ifdc8780b5da4e0e959f144a1b927ed9bd48edddf
diff --git a/services/audioflinger/Effects.cpp b/services/audioflinger/Effects.cpp
index 09cc852..5d04a5b 100644
--- a/services/audioflinger/Effects.cpp
+++ b/services/audioflinger/Effects.cpp
@@ -67,7 +67,10 @@
: mPinned(pinned),
mThread(thread), mChain(chain), mId(id), mSessionId(sessionId),
mDescriptor(*desc),
- // mConfig cleared in constructor body, set by configure()
+ // clear mConfig to ensure consistent initial value of buffer framecount
+ // in case buffers are associated by setInBuffer() or setOutBuffer()
+ // prior to configure().
+ mConfig{{}, {}},
mStatus(NO_INIT), mState(IDLE),
// mMaxDisableWaitCnt is set by configure() and not used before then
// mDisableWaitCnt is set by process() and updateState() and not used before then
@@ -80,11 +83,6 @@
ALOGV("Constructor %p pinned %d", this, pinned);
int lStatus;
- // clear configuration to ensure consistent initial value of buffer framecount
- // in case buffers are associated by setInBuffer() or setOutBuffer()
- // prior to configure().
- memset(&mConfig, 0, sizeof(mConfig));
-
// create effect engine from effect factory
mStatus = -ENODEV;
sp<AudioFlinger> audioFlinger = mAudioFlinger.promote();