commit ae7d9e6e52ffe38f449abd5a253771e6d91035d6
author Nate Myren <ntmyren@google.com> Mon Mar 15 14:21:43 2021 -0700
committer Nate Myren <ntmyren@google.com> Mon Mar 15 21:26:05 2021 +0000
tree ac91d71e41f48d67a64165adbce49c49d7bcc0a3
parent da52d86663542d1860adb0bba7f49902f0e67ac9

Put brackets around AIDL_RETURN macro

This makes the VALUE_OR_RETURN_ILLEGAL_ARG_STATUS if statement
work correctly. Also removes needless double conversion

Fixes: 182788325
Test: Launch OboeTester, run "TEST OUTPUT" with MMAP checked
Change-Id: I3d441645bee735c58b0c7c234032ec76a238928d

services/oboeservice/AAudioService.cpp

diff --git a/services/oboeservice/AAudioService.cpp b/services/oboeservice/AAudioService.cpp
index 8baf8dc..0b69bf6 100644
--- a/services/oboeservice/AAudioService.cpp
+++ b/services/oboeservice/AAudioService.cpp
@@ -39,7 +39,7 @@
 using namespace aaudio;
 
 #define MAX_STREAMS_PER_PROCESS   8
-#define AIDL_RETURN(x) *_aidl_return = (x); return Status::ok();
+#define AIDL_RETURN(x) { *_aidl_return = (x); return Status::ok(); }
 
 #define VALUE_OR_RETURN_ILLEGAL_ARG_STATUS(x) \
     ({ auto _tmp = (x); \
@@ -116,12 +116,11 @@
 
     // Enforce limit on client processes.
     Identity callingIdentity = request.getIdentity();
+    pid_t pid = IPCThreadState::self()->getCallingPid();
     callingIdentity.pid = VALUE_OR_RETURN_ILLEGAL_ARG_STATUS(
-        legacy2aidl_pid_t_int32_t(IPCThreadState::self()->getCallingPid()));
+        legacy2aidl_pid_t_int32_t(pid));
     callingIdentity.uid = VALUE_OR_RETURN_ILLEGAL_ARG_STATUS(
         legacy2aidl_uid_t_int32_t(IPCThreadState::self()->getCallingUid()));
-    pid_t pid = VALUE_OR_RETURN_ILLEGAL_ARG_STATUS(
-        aidl2legacy_int32_t_pid_t(callingIdentity.pid));
     if (callingIdentity.pid != mAudioClient.identity.pid) {
         int32_t count = AAudioClientTracker::getInstance().getStreamCount(pid);
         if (count >= MAX_STREAMS_PER_PROCESS) {