commit b1baabb54e4c03ddde39f2dae1e6abd207739eef
author Amy Zhang <amyjojo@google.com> Mon Feb 08 19:54:28 2021 -0800
committer Amy Zhang <amyjojo@google.com> Tue Feb 09 11:03:04 2021 -0800
tree 9145c55ce238ea4bee5e8b74f8c03e2f8e1696da
parent f543afb203285bf2bbff0a289fa30ed810266827

Fix issues in Tuner Service implementation

This CL fixes the following bugs:
1. Missing Tuner HAL version check API
2. hidl_array init issue when converting ip settings
3. Missing handling the aidl service binding error

Test: atest android.media.tv.tuner.cts
Bug: 159067322
Change-Id: Ib43cedccb062e7849b5133e03c74c58c9e082437

services/tuner/main_tunerservice.cpp

diff --git a/services/tuner/main_tunerservice.cpp b/services/tuner/main_tunerservice.cpp
index a0e7a9f..586a0e2 100644
--- a/services/tuner/main_tunerservice.cpp
+++ b/services/tuner/main_tunerservice.cpp
@@ -32,7 +32,11 @@
     sp<IServiceManager> sm = defaultServiceManager();
     ALOGD("ServiceManager: %p", sm.get());
 
-    TunerService::instantiate();
+    binder_status_t status = TunerService::instantiate();
+    if (status != STATUS_OK) {
+        ALOGD("Failed to add tuner service as AIDL interface");
+        return -1;
+    }
 
     ProcessState::self()->startThreadPool();
     IPCThreadState::self()->joinThreadPool();