commit b2fe78f72435f475fad855d20c1ef0309e392b8f
author Eric Laurent <elaurent@google.com> Thu Aug 02 17:56:11 2018 -0700
committer Eric Laurent <elaurent@google.com> Thu Aug 02 17:56:11 2018 -0700
tree 95ce3c80168218f1e0c18eda061980329d953dde
parent c74e507ea7742da83d97768b332b17dcea60cfc0

IAudioFlinger: fix early return in createEffect

Bug: 112161565
Test: make
Change-Id: I7056ed1a3454c7e0fbe692029f75fe5b50c4c42f

media/libaudioclient/IAudioFlinger.cpp

diff --git a/media/libaudioclient/IAudioFlinger.cpp b/media/libaudioclient/IAudioFlinger.cpp
index 84e8bee..23d5c49 100644
--- a/media/libaudioclient/IAudioFlinger.cpp
+++ b/media/libaudioclient/IAudioFlinger.cpp
@@ -634,10 +634,10 @@
         sp<IEffect> effect;
 
         if (pDesc == NULL) {
-            return effect;
             if (status != NULL) {
                 *status = BAD_VALUE;
             }
+            return effect;
         }
 
         data.writeInterfaceToken(IAudioFlinger::getInterfaceDescriptor());