commit c19e22450e6e3d07594c935c7a9522e85e909e82
author Glenn Kasten <gkasten@google.com> Mon Jan 30 14:54:39 2012 -0800
committer Glenn Kasten <gkasten@google.com> Fri Feb 03 14:42:43 2012 -0800
tree 2a81eb366d10425b83b6bbf9997d9c8813515ea1
parent 787bae0578fbaab6219ebf23494866b224d01438

Use virtual destructors

It turns out to be just a comment, as all except AudioMixer are RefBase.

There are only a few performance-sensitive cases where it's worth thinking
about whether you need a virtual destructor, and the headache usually
outweighs the benefit.

Change-Id: I716292f9556ec17c29ce8c76ac8ae602cb496533

services/audioflinger/AudioMixer.h

diff --git a/services/audioflinger/AudioMixer.h b/services/audioflinger/AudioMixer.h
index 84f6330..40a508e 100644
--- a/services/audioflinger/AudioMixer.h
+++ b/services/audioflinger/AudioMixer.h
@@ -33,7 +33,7 @@
 public:
                             AudioMixer(size_t frameCount, uint32_t sampleRate);
 
-                            ~AudioMixer();
+    /*virtual*/             ~AudioMixer();  // non-virtual saves a v-table, restore if sub-classed
 
     static const uint32_t MAX_NUM_TRACKS = 32;
     static const uint32_t MAX_NUM_CHANNELS = 2;