commit c5268e825d4a513ad857b7944a9f85dc478c1dc6
author Eino-Ville Talvala <etalvala@google.com> Tue Sep 11 11:01:18 2012 -0700
committer Eino-Ville Talvala <etalvala@google.com> Tue Sep 11 11:27:46 2012 -0700
tree c754fe71b73142b822c858a5b669c43016898614
parent 66765846726c02db16a0f024f2217990a90802c0

Camera1: Fix enable shutter sound command error handling.

Return the error codes from calls to enableShutterSound to the caller,
and don't call the HAL with the enable shutter sound command.

Change-Id: Ibe4943bd1cd0fcd1832fd904f12dd2f78fec06a5

services/camera/libcameraservice/CameraClient.cpp

diff --git a/services/camera/libcameraservice/CameraClient.cpp b/services/camera/libcameraservice/CameraClient.cpp
index 562384d..c9c816a 100644
--- a/services/camera/libcameraservice/CameraClient.cpp
+++ b/services/camera/libcameraservice/CameraClient.cpp
@@ -608,11 +608,9 @@
     } else if (cmd == CAMERA_CMD_ENABLE_SHUTTER_SOUND) {
         switch (arg1) {
             case 0:
-                enableShutterSound(false);
-                break;
+                return enableShutterSound(false);
             case 1:
-                enableShutterSound(true);
-                break;
+                return enableShutterSound(true);
             default:
                 return BAD_VALUE;
         }