commit cf6c75a45416a90d2afdf42f0ac2f0b26f67839a
author Sanna Catherine de Treville Wager <scwager@google.com> Fri Jul 21 17:05:25 2017 -0700
committer Sanna Catherine de Treville Wager <scwager@google.com> Mon Jul 24 13:12:50 2017 -0700
tree 9f0bfbac461e5b6f4395c39f4f0c4f58767fc16d
parent a80649ad90956a25e24c2cd00931b0253e994721

Moved dump from NBLog to ReportPerformance

Minor cleanup

Test: dumpsys media.log
Change-Id: Ib4d12f6e20c04ecb3344290083ea65a3fe1e47e0

media/libnbaio/NBLog.cpp

diff --git a/media/libnbaio/NBLog.cpp b/media/libnbaio/NBLog.cpp
index f00d86f..0adeb46 100644
--- a/media/libnbaio/NBLog.cpp
+++ b/media/libnbaio/NBLog.cpp
@@ -92,7 +92,6 @@
 #include <climits>
 #include <deque>
 #include <fstream>
-// #include <inttypes.h>
 #include <iostream>
 #include <math.h>
 #include <numeric>
@@ -941,22 +940,8 @@
     getAndProcessSnapshot(*snap);
 }
 
-// TODO: move this function to a different class than NBLog::Reader
-// writes summary of performance to the console
-void NBLog::MergeReader::dump(int fd, size_t indent)
-{
-    mFd = fd;
-    mIndent = indent;
-    String8 body, timestamp;
-    // TODO: check: is the FIXME below still a problem?
-    // FIXME: this is not thread safe
-    for (auto & threadReport : mThreadPerformanceAnalysis) {
-        threadReport.second.reportPerformance(&body);
-    }
-    if (!body.isEmpty()) {
-        ALOGD("body is not empty");
-        dumpLine(timestamp, body);
-    }
+void NBLog::MergeReader::dump(int fd, int indent) {
+    ReportPerformance::dump(fd, indent, mThreadPerformanceAnalysis);
 }
 
 // Writes a string to the console