commit d9fc34fb0fcfcc739f868b116edf50c62af19d5e
author Glenn Kasten <gkasten@google.com> Wed Aug 14 13:55:45 2013 -0700
committer Glenn Kasten <gkasten@google.com> Thu Aug 15 10:18:27 2013 -0700
tree e9866027d09e762d71946fb66acc9db32915670f
parent 4ef0b463a56c19bad9197aa9f90d792090461429

Remove dead 'if'

Change-Id: I23c082f0115ae598cad293be0ac66a130afb692a

services/audioflinger/Threads.cpp

diff --git a/services/audioflinger/Threads.cpp b/services/audioflinger/Threads.cpp
index a8854ca..4471d82 100644
--- a/services/audioflinger/Threads.cpp
+++ b/services/audioflinger/Threads.cpp
@@ -4233,46 +4233,44 @@
                 acquireWakeLock_l();
                 continue;
             }
-            if (mActiveTrack != 0) {
-                if (mActiveTrack->isTerminated()) {
-                    removeTrack_l(mActiveTrack);
+            if (mActiveTrack->isTerminated()) {
+                removeTrack_l(mActiveTrack);
+                mActiveTrack.clear();
+            } else {
+                switch (mActiveTrack->mState) {
+                case TrackBase::PAUSING:
+                    standby();
                     mActiveTrack.clear();
-                } else {
-                    switch (mActiveTrack->mState) {
-                    case TrackBase::PAUSING:
-                        standby();
+                    mStartStopCond.broadcast();
+                    break;
+
+                case TrackBase::RESUMING:
+                    if (mReqChannelCount != mActiveTrack->channelCount()) {
                         mActiveTrack.clear();
                         mStartStopCond.broadcast();
-                        break;
-
-                    case TrackBase::RESUMING:
-                        if (mReqChannelCount != mActiveTrack->channelCount()) {
+                    } else if (readOnce) {
+                        // record start succeeds only if first read from audio input
+                        // succeeds
+                        if (mBytesRead >= 0) {
+                            mActiveTrack->mState = TrackBase::ACTIVE;
+                        } else {
                             mActiveTrack.clear();
-                            mStartStopCond.broadcast();
-                        } else if (readOnce) {
-                            // record start succeeds only if first read from audio input
-                            // succeeds
-                            if (mBytesRead >= 0) {
-                                mActiveTrack->mState = TrackBase::ACTIVE;
-                            } else {
-                                mActiveTrack.clear();
-                            }
-                            mStartStopCond.broadcast();
                         }
-                        mStandby = false;
-                        break;
-
-                    case TrackBase::ACTIVE:
-                        break;
-
-                    case TrackBase::IDLE:
-                        break;
-
-                    default:
-                        LOG_FATAL("Unexpected mActiveTrack->mState %d", mActiveTrack->mState);
+                        mStartStopCond.broadcast();
                     }
+                    mStandby = false;
+                    break;
 
+                case TrackBase::ACTIVE:
+                    break;
+
+                case TrackBase::IDLE:
+                    break;
+
+                default:
+                    LOG_FATAL("Unexpected mActiveTrack->mState %d", mActiveTrack->mState);
                 }
+
             }
             lockEffectChains_l(effectChains);
         }