commit e4f1f63a2c54ee8687ad8cca18df0f6639ad7c81
author Mikhail Naganov <mnaganov@google.com> Wed Aug 31 11:35:10 2016 -0700
committer Mikhail Naganov <mnaganov@google.com> Tue Sep 13 16:27:15 2016 -0700
tree 941cdb35111e5e01ece553475e5bbf7841a7116c
parent 1724ee3caa5f0b4e73979036073f0b71a115083a

Abstract away access to audio devices HAL

In this CL all direct access to audio_hw_device_t and its functions is
encapsulated within the new class DeviceHalLocal. Loading of hardware
modules is encapsulated withing DevicesFactoryHalLocal.  AudioFlinger
uses interface classes DevicesFactoryHalInterface and DeviceHalInterface
to access these functions.

Bug: 30222631
Change-Id: Ic88b20c55813a24b898f4a832e082c17d81935b7

services/audioflinger/EffectHalLocal.cpp

diff --git a/services/audioflinger/EffectHalLocal.cpp b/services/audioflinger/EffectHalLocal.cpp
index 11fdc30..aae1921 100644
--- a/services/audioflinger/EffectHalLocal.cpp
+++ b/services/audioflinger/EffectHalLocal.cpp
@@ -14,6 +14,9 @@
  * limitations under the License.
  */
 
+#define LOG_TAG "AudioFlinger::EffectHalLocal"
+//#define LOG_NDEBUG 0
+
 #include <media/EffectsFactoryApi.h>
 #include <utils/Log.h>
 
@@ -27,9 +30,8 @@
 
 EffectHalLocal::~EffectHalLocal() {
     int status = EffectRelease(mHandle);
-    if (status != 0) {
-        ALOGW("Error releasing effect %p: %s", mHandle, strerror(-status));
-    }
+    ALOGW_IF(status, "Error releasing effect %p: %s", mHandle, strerror(-status));
+    mHandle = 0;
 }
 
 status_t EffectHalLocal::process(audio_buffer_t *inBuffer, audio_buffer_t *outBuffer) {