commit e99551ffc4139414d7e4dae7638b488adf0d6a24
author TreeHugger Robot <treehugger-gerrit@google.com> Mon Mar 11 18:12:37 2019 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Mon Mar 11 18:12:37 2019 +0000
tree c092e92bc79f4ea84df124db7be865bc1043a9e3
parent 4f2c001bf122812a00c619806c7f44159c7820a8
parent 39f4bc12d049acec9bf8a665f362b8a18ad14f6f

Merge "Fix memory leaks"

media/libmediaplayer2/MediaPlayer2AudioOutput.cpp

diff --git a/media/libmediaplayer2/MediaPlayer2AudioOutput.cpp b/media/libmediaplayer2/MediaPlayer2AudioOutput.cpp
index 7c3063d..c1bfa25 100644
--- a/media/libmediaplayer2/MediaPlayer2AudioOutput.cpp
+++ b/media/libmediaplayer2/MediaPlayer2AudioOutput.cpp
@@ -521,12 +521,15 @@
 status_t MediaPlayer2AudioOutput::addAudioDeviceCallback(jobject jRoutingDelegate) {
     ALOGV("addAudioDeviceCallback");
     Mutex::Autolock lock(mLock);
-    jobject listener = (new JObjectHolder(
-            JAudioTrack::getListener(jRoutingDelegate)))->getJObject();
+
+    JObjectHolder listenerHolder{JAudioTrack::getListener(jRoutingDelegate)};
+    jobject listener = listenerHolder.getJObject();
     if (JAudioTrack::findByKey(mRoutingDelegates, listener) == nullptr) {
-        jobject handler = (new JObjectHolder(
-                JAudioTrack::getHandler(jRoutingDelegate)))->getJObject();
-        jobject routingDelegate = (new JObjectHolder(jRoutingDelegate))->getJObject();
+        JObjectHolder handlerHolder{JAudioTrack::getHandler(jRoutingDelegate)};
+        jobject handler = handlerHolder.getJObject();
+
+        JObjectHolder routingDelegateHolder = JObjectHolder(jRoutingDelegate);
+        jobject routingDelegate = routingDelegateHolder.getJObject();
         mRoutingDelegates.push_back(std::pair<jobject, jobject>(listener, routingDelegate));
         if (mJAudioTrack != nullptr) {
             return mJAudioTrack->addAudioDeviceCallback(routingDelegate, handler);