commit ef30c3b7e761438adb9e660c0280bf61f5d7feaf
author Jayant Chowdhary <jchowdhary@google.com> Mon Feb 22 22:47:39 2021 +0000
committer Jayant Chowdhary <jchowdhary@google.com> Tue Feb 23 23:34:20 2021 +0000
tree ad20abdb7f1e14a7791ef91fb92ad72f4a83fd43
parent 5e21872a82ce9576fcf6719fa61473d42883090b

Update CameraUtils::isCameraServiceDisabled to use base::GetBoolProperty.

Bug: 168061412

Test: Test on platform with cameraserver disabled.

Change-Id: Ibb7f31497595b8f6a5129760b2470b25dc08eab1
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>

camera/Android.bp

diff --git a/camera/Android.bp b/camera/Android.bp
index 71c88ab..2c01496 100644
--- a/camera/Android.bp
+++ b/camera/Android.bp
@@ -81,6 +81,7 @@
     ],
 
     shared_libs: [
+        "libbase",
         "libcutils",
         "libutils",
         "liblog",

camera/CameraUtils.cpp

diff --git a/camera/CameraUtils.cpp b/camera/CameraUtils.cpp
index f9b1b37..af3c492 100644
--- a/camera/CameraUtils.cpp
+++ b/camera/CameraUtils.cpp
@@ -20,14 +20,16 @@
 #include <camera/CameraUtils.h>
 #include <media/hardware/HardwareAPI.h>
 
+#include <android-base/properties.h>
 #include <system/window.h>
 #include <system/graphics.h>
 
-#include <cutils/properties.h>
 #include <utils/Log.h>
 
 namespace android {
 
+const char *kCameraServiceDisabledProperty = "config.disable_cameraservice";
+
 status_t CameraUtils::getRotationTransform(const CameraMetadata& staticInfo,
                 /*out*/int32_t* transform) {
     ALOGV("%s", __FUNCTION__);
@@ -124,9 +126,7 @@
 }
 
 bool CameraUtils::isCameraServiceDisabled() {
-    char value[PROPERTY_VALUE_MAX];
-    property_get("config.disable_cameraservice", value, "0");
-    return (strncmp(value, "0", 2) != 0 && strncasecmp(value, "false", 6) != 0);
+    return base::GetBoolProperty(kCameraServiceDisabledProperty, false);
 }
 
 } /* namespace android */