commit f2f79cfcdec89052f49b74f9aab48e58daf606c6
author Eric Laurent <elaurent@google.com> Thu Apr 23 17:10:50 2015 -0700
committer Eric Laurent <elaurent@google.com> Thu Apr 23 17:13:45 2015 -0700
tree e78c065329ef4f6258285c4955ae2ded5101b46d
parent 1ac91ed2c67245ea5052182212463d3f0afe8b5a

RadioService: fix error handling in attach().

Fix typo causing tuner open error to be ignored.

Change-Id: I10735f0cf6ae64ff9c4efa2eb4b20d94d3597ae5

services/radio/RadioService.cpp

diff --git a/services/radio/RadioService.cpp b/services/radio/RadioService.cpp
index a6c2bdf..cd0f5f3 100644
--- a/services/radio/RadioService.cpp
+++ b/services/radio/RadioService.cpp
@@ -146,7 +146,7 @@
     radio = module->addClient(client, config, withAudio);
 
     if (radio == 0) {
-        NO_INIT;
+        return NO_INIT;
     }
     return NO_ERROR;
 }
@@ -500,13 +500,12 @@
         if (audio) {
             notifyDeviceConnection(true, "");
         }
+        ALOGV("addClient() DONE moduleClient %p", moduleClient.get());
     } else {
+        ALOGW("%s open_tuner failed with error %d", __FUNCTION__, ret);
         moduleClient.clear();
     }
 
-
-    ALOGV("addClient() DONE moduleClient %p", moduleClient.get());
-
     return moduleClient;
 }