)]}'
{
  "commit": "fd39db81e44e191baa476a579de6cc2618de025a",
  "tree": "bbd531650f20bb1a84b0e169b32fc558835313f4",
  "parents": [
    "56c3307952478ba42bf33ad88d8e0e194623224a"
  ],
  "author": {
    "name": "Jayant Chowdhary",
    "email": "jchowdhary@google.com",
    "time": "Mon Oct 07 15:26:41 2019 -0700"
  },
  "committer": {
    "name": "Jayant Chowdhary",
    "email": "jchowdhary@google.com",
    "time": "Wed Oct 16 14:48:24 2019 -0700"
  },
  "message": "cameraserver: Avoiding deadlocks while calling isPublicallyHiddenSecureCamera().\n\nThe following scenario can occur:\n\n T1 serving Client A\u0027s disconnect() call:\n   T2 : serving Client B\u0027s connect() call\n     T2 : CameraProviderManager::openSession() locks mInterfaceMutex and waits on open() HAL\n          interface call\n       T1: updateStatus() locks mStatusListenerMutex\n         T1: CameraProviderManager::isPublicallyHiddenSecureCamera() waits\n             on mInterfaceMutex\n           T2: while waiting on open(), gets a torchModeStatus() callback from the camera HAL\n              T2: onStatusChanged()\n                T2: broadcastTorchModeStatus() which waits on mStatusListenerMutex\n\nAs a result there\u0027s a possible circular hold and wait between T1 and T2.\n\nWe cache isPublicallyHiddenSecureCamera in CameraState. That doesn\u0027t completely\navoid having to hold mInterfaceLock while calling isPublicallyHiddenSecureCamera() in CameraService\n(cache updates), instead it reduces it. We instead need to hold mCameraStates lock which has a\nsmaller scope.\n\nBug: 141756275\n\nTest: CTS\nTest: GCA (sanity)\n\nMerged-In: I4a697c1eaccc3603007be4a595febea981fbeb64\nChange-Id: Ie5508afb126a874f76fbbfc2dd19ef79ae6255e0\nSigned-off-by: Jayant Chowdhary \u003cjchowdhary@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "e663485cd99fa3d678fac7fcd0d98fd1f7fd8d83",
      "old_mode": 33188,
      "old_path": "services/camera/libcameraservice/CameraService.cpp",
      "new_id": "bdeb27376f67dfd01f8e17a6cae55723e69873cc",
      "new_mode": 33188,
      "new_path": "services/camera/libcameraservice/CameraService.cpp"
    },
    {
      "type": "modify",
      "old_id": "cf93a4147cd460e12298e97317aa589a1a01b641",
      "old_mode": 33188,
      "old_path": "services/camera/libcameraservice/CameraService.h",
      "new_id": "8bb78cde568280f7b6e5ed529e6e669046f48689",
      "new_mode": 33188,
      "new_path": "services/camera/libcameraservice/CameraService.h"
    },
    {
      "type": "modify",
      "old_id": "47baeb2668f0d08652d9c75cdff7907fc8d642b9",
      "old_mode": 33188,
      "old_path": "services/camera/libcameraservice/common/CameraProviderManager.cpp",
      "new_id": "7f94e5525ff3293c7134b7099be7caacf9b3cbdc",
      "new_mode": 33188,
      "new_path": "services/camera/libcameraservice/common/CameraProviderManager.cpp"
    },
    {
      "type": "modify",
      "old_id": "c812f424b4af27f1707520bdebdea90cebecab8f",
      "old_mode": 33188,
      "old_path": "services/camera/libcameraservice/common/CameraProviderManager.h",
      "new_id": "cd283b3e379580961217d174727a1fcf0c45895b",
      "new_mode": 33188,
      "new_path": "services/camera/libcameraservice/common/CameraProviderManager.h"
    }
  ]
}
