)]}' { "log": [ { "commit": "84a0c6e87c48f58a0d3be71961432c086a4d24cc", "tree": "a9bea7e95223dc4d1f3219d4e60dd385881ec6d8", "parents": [ "99021c47f45ee8bf3317cff7d08226e76c8d8227" ], "author": { "name": "Andy Hung", "email": "hunga@google.com", "time": "Wed Apr 02 11:24:53 2014 -0700" }, "committer": { "name": "Andy Hung", "email": "hunga@google.com", "time": "Wed Apr 02 14:33:26 2014 -0700" }, "message": "Change references of Q19.12 to Q4.27 for clarity\n\nChange-Id: I5beb7daf6ff9bc123ff3582f7c294edcaf8652f6\nSigned-off-by: Andy Hung \u003chunga@google.com\u003e\n" }, { "commit": "adad3d7d935da176ff24941b4ae9edf7340e9b96", "tree": "7a8a2f8e31c7dd690805c1cfd9982d218c66296b", "parents": [ "1392eb3d1802e9f894f87d7a7387207d1b6faca1" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Feb 21 14:51:43 2014 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Mar 26 14:46:28 2014 -0700" }, "message": "Use LOG_ALWAYS_FATAL instead of LOG_FATAL\n\nLOG_FATAL is compiled out in most builds, so the\nassertion checks were not being performed.\n\nChange-Id: I774f0985ab9c5ccecd8989a0f1c940386b73fc35\n" }, { "commit": "788207057ed4b8df4719ed8089f376ef52de9ca1", "tree": "63659b6151de243ea608add08c3f5d2963c1bd3e", "parents": [ "7ed1873acbf43280c5afe51833c3d628fe34e258" ], "author": { "name": "Andy Hung", "email": "hunga@google.com", "time": "Fri Feb 28 16:23:02 2014 -0800" }, "committer": { "name": "Andy Hung", "email": "hunga@google.com", "time": "Sat Mar 01 04:20:18 2014 +0000" }, "message": "Rename mSinkFormat to mMixerFormat for AudioMixer::track_t\n\nAudioMixer::SINK_FORMAT also changes to AudioMixer::MIXER_FORMAT\n\nChange-Id: Ic3f8be77d2c75c082c4fd140bc907e30c304d285\nSigned-off-by: Andy Hung \u003chunga@google.com\u003e\n" }, { "commit": "3375bde6c6c1821fca3eeb4840774112e26c9a68", "tree": "aba09d6bbf9ca0afbc360be7d608ac8d83d2983a", "parents": [ "69aed5f0f4a3be3996d1e78a0473e1a72c1547da" ], "author": { "name": "Andy Hung", "email": "hunga@google.com", "time": "Fri Feb 28 15:51:47 2014 -0800" }, "committer": { "name": "Andy Hung", "email": "hunga@google.com", "time": "Fri Feb 28 17:31:44 2014 -0800" }, "message": "Use float_from_q19_12 conversion in AudioMixer\n\nChange-Id: Idbe84fb9610c7e636a84468f2e2402a913435ca9\nSigned-off-by: Andy Hung \u003chunga@google.com\u003e\n" }, { "commit": "a1ab7cc8611c83427b57f6d4d4ce7aad9d1c0330", "tree": "8a519f604c7d5f0369ffaa6f9fb268c1906bfb68", "parents": [ "56df9ff31d583ad3eae4f279a3df550273c58e1e" ], "author": { "name": "Andy Hung", "email": "hunga@google.com", "time": "Mon Feb 24 19:26:52 2014 -0800" }, "committer": { "name": "Andy Hung", "email": "hunga@google.com", "time": "Wed Feb 26 16:01:08 2014 -0800" }, "message": "Add Track Sink Format to AudioMixer\n\nTrack Sink Format now allows both AUDIO_FORMAT_PCM_FLOAT and\nAUDIO_FORMAT_PCM_16_BIT (default). The float case is not\nenabled now.\n\nChange-Id: Ibee70cab4725c8bc9905e49f1f9a9c2448f76e00\nSigned-off-by: Andy Hung \u003chunga@google.com\u003e\n" }, { "commit": "1d6fa7af1288b550faabe4ec2cf98684236723db", "tree": "a8801ca9a0925ba1faccf17acea4aa78d71a9d29", "parents": [ "b82a9f105f89d6b3684c9f626918042bd8977912", "566be7c33fc56ae4c34168ecbee5316374f7e3c5" ], "author": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Tue Feb 11 13:47:53 2014 +0000" }, "committer": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Tue Feb 11 13:53:20 2014 +0000" }, "message": "resolved conflicts for merge of 566be7c3 to master\n\nChange-Id: I7b1cc71057b2bd4f771e7bcf508a8c3abd6017ce\n" }, { "commit": "377b2ec9a2885f9b6405b07ba900a9e3f4349c38", "tree": "b938e1d75a1beefae86244f287ca22f4a277740d", "parents": [ "cdda7bf4d3ca9cad6979374a18dd5be79ea83d80" ], "author": { "name": "Kévin PETIT", "email": "kevin.petit@arm.com", "time": "Mon Feb 03 12:35:36 2014 +0000" }, "committer": { "name": "Narayan Kamath", "email": "narayan@google.com", "time": "Tue Feb 11 11:40:06 2014 +0000" }, "message": "Make frameworks/av 64-bit compatible\n\nContains the necessary changes to make frameworks/av build and work\non a 64-bit machine.\n\nSigned-off-by: Craig Barber \u003ccraig.barber@arm.com\u003e\nSigned-off-by: Kévin PETIT \u003ckevin.petit@arm.com\u003e\nSigned-off-by: Ashok Bhat \u003cashok.bhat@arm.com\u003e\nSigned-off-by: Marcus Oakland \u003cmarcus.oakland@arm.com\u003e\n\nChange-Id: I725feaae50ed8eee25ca2c947cf15aee1f395c43\n" }, { "commit": "9e0308c03d4e76d3146cbb6e30aeb3ac03f05cf5", "tree": "f64a6d90e2e6d2e45fa83a72422d08b3751c3914", "parents": [ "e983e0a0017fce81dc3d9bea36f5abb7b7bce40b" ], "author": { "name": "Andy Hung", "email": "hunga@google.com", "time": "Thu Jan 30 14:32:31 2014 -0800" }, "committer": { "name": "Andy Hung", "email": "hunga@google.com", "time": "Thu Jan 30 16:19:21 2014 -0800" }, "message": "Enable new dynamic audio resampler as default\n\nThe default may still be overridden by af.resampler.quality\nin the local or build properties file. For the build properties\ncheck the relevant device.mk files.\n\nIn the absence of being overridden, the 44.1 to 48kHz and\n48 to 44.1kHz conversion will use the DYN_MED_QUALITY resamplers\nand other conversion will use the DYN_LOW_QUALITY resamplers.\n\nChange-Id: Icf9a4af5422cddc445e1904eef93984b0abe6a44\nSigned-off-by: Andy Hung \u003chunga@google.com\u003e\n" }, { "commit": "e983e0a0017fce81dc3d9bea36f5abb7b7bce40b", "tree": "d402cf746d4cd3aa35b54c678d98d1faf998c45c", "parents": [ "000a4193dd82549192277fd4b9bb571d8a4c262f", "ee931ff7d6620e5705f4dfba901fdb03fa4a35fd" ], "author": { "name": "Andy Hung", "email": "hunga@google.com", "time": "Thu Jan 30 19:19:44 2014 +0000" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Thu Jan 30 19:19:45 2014 +0000" }, "message": "Merge \"Remove warnings in Audio mixer resampler compilation.\"" }, { "commit": "ee931ff7d6620e5705f4dfba901fdb03fa4a35fd", "tree": "6b2b85da4ed2622b2075a8e5f4b8f13d0242c810", "parents": [ "c69b91ceae6255e41c5413796fb0ed4f7af45b15" ], "author": { "name": "Andy Hung", "email": "hunga@google.com", "time": "Tue Jan 28 13:44:14 2014 -0800" }, "committer": { "name": "Andy Hung", "email": "hunga@google.com", "time": "Wed Jan 29 19:11:51 2014 -0800" }, "message": "Remove warnings in Audio mixer resampler compilation.\n\nChange-Id: Ie68766142796772a54a90afdea188d0a5a78d4ac\nSigned-off-by: Andy Hung \u003chunga@google.com\u003e\n" }, { "commit": "0eed5ac1a14067d0fd51282e97b43b4fd9121842", "tree": "a097082c6034c43e851e3adb8aaba670f859ca60", "parents": [ "de3736015c82798c431a9fa8cab5c2ec3fb181fd", "adf3f9b98b482180fc1d0835c1b6212b1659e249" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Jan 29 10:02:59 2014 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Jan 29 10:02:59 2014 -0800" }, "message": "Merge commit \u0027adf3f9b9\u0027 into manualmerge\n\nChange-Id: Icdef7d075b160eb2a5ced7c57f90c6a6a4b4c64a\n" }, { "commit": "7e79cd2d3067cdb7b9daf639cf772d4dd149c934", "tree": "bbb14bc8c011b3c7e60c2b78c2a2f4366bf12639", "parents": [ "99044adc6e209d31e9c5308d960e2bd5f6999f85" ], "author": { "name": "Gaurav Kumar", "email": "gaurav.kumar@broadcom.com", "time": "Mon Jan 06 10:57:18 2014 +0530" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@android.com", "time": "Wed Jan 29 17:46:08 2014 +0000" }, "message": "AudioMixer: Remove tracks from enabledTracks after reseting outTemp\n\nIf any track goes through AudioMixer::process__genericNoResampling, and\nits getnextbuffer returns NULL, Then that track is removed by AudioMixer\nfrom enabledTracks.\n\nThus if all tracks getnextbuffer return NULL, Then this function doesn\u0027t\nreset outTemp and last buffer in AudioFlinger\u0027s mMixBuffer will be\nrepeated and noise is observed.\n\nRemove tracks from enabledTracks after reseting outTemp to zero, so that\nprocess__genericNoResampling will reset outTemp and noise won\u0027t appear.\n\nBug: 12450065\nChange-Id: I1ccac7ee4a3bf7fd930254356c072099e11e7c19\nSigned-off-by: Gaurav Kumar \u003cgaurav.kumar@broadcom.com\u003e\nSigned-off-by: Pierre Couillaud \u003cpierre@broadcom.com\u003e\n" }, { "commit": "d8a1de6204829b0379bbd13042f1450bdb203f2b", "tree": "b7b513a563f76060ec82a73aa9ee9543a391b8db", "parents": [ "2e70b42e2af66f4abb22a95c5d642175c007e256", "f551e9961a6f66d63bb57f288c4be01b00725289" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Nov 08 19:19:00 2013 +0000" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Fri Nov 08 19:19:00 2013 +0000" }, "message": "Merge \"Channel counts are uint32_t\"" }, { "commit": "f551e9961a6f66d63bb57f288c4be01b00725289", "tree": "1253e7bc4034a35606881fe75e6c22b3a8c602cc", "parents": [ "d21952fe5bc94f7bb6ee729f806c0e641fdb1a0d" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Mon Aug 19 18:45:42 2013 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Nov 06 15:49:00 2013 -0800" }, "message": "Channel counts are uint32_t\n\nChange-Id: I5676b6a291b72d7db6326f7eaf6d17588de51b05\n" }, { "commit": "d6fadf0479b489b09b764070974d8a59855ede64", "tree": "239aa64bd7cdc0e69b1ad8e1ef85be7e09176a56", "parents": [ "8f32537d028231abed103c68705bc5d07cedf919" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Oct 30 14:37:29 2013 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Nov 06 14:49:46 2013 -0800" }, "message": "Simplify track \u0027needs\u0027 bits\n\nUse more standard coding convention for bit masks,\nand add a FIXME about max channel count.\n\nChange-Id: I856784016703417ee480b92ae73757c472f9cf95\n" }, { "commit": "8f32537d028231abed103c68705bc5d07cedf919", "tree": "17eb75d6fc15e8494cb0049df39f2e971cbb8c77", "parents": [ "e25b778b11183fda65418ab2142873a030521870" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Oct 30 14:36:47 2013 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Nov 06 14:47:41 2013 -0800" }, "message": "Remove redundant this-\u003e\n\nChange-Id: Id783201e802b6ce294fa92f4bbe492adfb446686\n" }, { "commit": "e25b778b11183fda65418ab2142873a030521870", "tree": "f7e2a2751de63187e29d0597eb0324e23a062d98", "parents": [ "5c6ba3ad8eed1d59e5e2ffe6b70ced2d582a9def" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Oct 30 14:37:10 2013 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Nov 06 14:43:25 2013 -0800" }, "message": "Remove dead code\n\nChange-Id: Ide9196aa348cd3846b5c71d51fe6538f38ea8dc2\n" }, { "commit": "49c34acbef91800930b0fe561e0787145a10cfcc", "tree": "53e636df1a5868bbea112ec3bd36e19862208adf", "parents": [ "d21952fe5bc94f7bb6ee729f806c0e641fdb1a0d" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Oct 30 14:37:01 2013 -0700" }, "committer": { "name": "Jean-Michel Trivi", "email": "jmtrivi@google.com", "time": "Wed Nov 06 18:05:09 2013 +0000" }, "message": "Fix race condition in initializing downmix\n\nThe code that initializes downmix GUID searches for an effect of\nthe right type. If two or more AudioMixers are created, there is a\npossibility that the GUID will temporarily have the wrong value.\n\nNow the initialization is only done once, regardless of how many\nAudioMixers there are.\n\nOther minor changes:\n - use naming convention of leading \u0027s\u0027 for static member variables\n - log message for no downmix effect is now a warning instead of an error,\n since it is not an error until there is actual content to downmix\n without a downmix effect\n\nChange-Id: I33ab0e51cf9d24ecaf8ae868883736b0772178c4\n" }, { "commit": "34fca34606b448e6b71c2942f63cb13a0aebd620", "tree": "45c5942f63ba22888ed24b5801400cde07b3fae2", "parents": [ "3255095af6677caeeebf81c8891ce8db745617ff" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Tue Aug 13 09:48:14 2013 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Tue Aug 13 09:56:00 2013 -0700" }, "message": "Explicit comparison to 0 for integral types\n\nChange-Id: I2bfe864d1bda719581e297a38d96abfc0e3748b9\n" }, { "commit": "6e2ebe97f2ad0a21907f20f9ee644c4eacbb7a40", "tree": "ea9d525f25620253ea86f434452bc37fbad73f76", "parents": [ "e198c360d5e75a9b2097844c495c10902e7e8500" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Tue Aug 13 09:14:51 2013 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Tue Aug 13 09:55:59 2013 -0700" }, "message": "Use curly braces in \u0027if\u0027 to make it easier to add logs\n\nChange-Id: I58b33fefdd8bf703647414157a99a3223be3531c\n" }, { "commit": "153b9fe667e6e78e0218ff0159353097428c7657", "tree": "360a76911071e362a94af32ccf67ce9619629708", "parents": [ "20f4754b7e687d3718a0a0a585f2c9ac22e2567d" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Mon Jul 15 11:23:36 2013 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Jul 19 09:30:37 2013 -0700" }, "message": "Make AudioFlinger::instantiate() more resilient when called from separate module\n\nBug: 8834855\nChange-Id: I4cd842cdfb09d2aaaaab9df9ac3bec6179709bd3\n" }, { "commit": "ab7d72f0804fbb7e91ad9d2a16f826d97e20e5d0", "tree": "9eda6276ab70724dcc98e56f7ca16afeb70ff079", "parents": [ "3605ab3c02516e4123c39062de301bacc8ea8d9f" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Feb 27 09:05:28 2013 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Mar 01 15:36:26 2013 -0800" }, "message": "media.log cleanup\n\nRemove almost all of the specific logs, but leave the media.log\nlogging infrastructure in place for the next time we need it.\n\nRe-apply a few good changes that were reverted earlier:\n - check logf format vs. argument list compatibility\n - distinguish potentially modified and actually modified tracks in FastMixer\n - fix benign bug where sq-\u003eend() was called more than once\n - fix a build warning\n\nBug: 6490974\nChange-Id: I02d3e83646c738acaebb415bd0d6b548638b4ef5\n" }, { "commit": "409e3749a5627f1b360feb1479fcd341067a90b8", "tree": "7b00ffd905ff1058b466b0e8176501e7d432a078", "parents": [ "ceb388d6c03c38b96dc41c0ea4804b749aa077c4" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Feb 27 09:39:39 2013 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Feb 27 09:39:55 2013 -0800" }, "message": "Revert \"Logging to investigate a crash\"\n\nThis reverts commit f0ff908da019a44115109f1b4d1b6864b35a8a29.\n" }, { "commit": "fc900c922e219771d0cd3c075720d90026e1ca4a", "tree": "0c6c289fd6a6d9a19197bba46c3fe1e0b3c19923", "parents": [ "4353cef86a90c83f02c4ff338d236e8361a27dd1" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Mon Feb 18 12:47:49 2013 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Tue Feb 19 10:51:47 2013 -0800" }, "message": "A reference cannot be re-bound\n\nBug: 8213067\nBug: 6490974\nChange-Id: If546215641fbc9a0fb1e8af8b85cc01f0a4b26ab\n" }, { "commit": "7f5d335f7b4caecd0dfb8f1085f352f1d2da5d2e", "tree": "dda17a3e4149815397c7bef198e64bc81dee3552", "parents": [ "32584a7d672864b20ab8b83a3cb23c1858e908b7" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Feb 15 23:55:04 2013 +0000" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Fri Feb 15 23:55:04 2013 +0000" }, "message": "Revert \"Temporary additional logging to investigate bug\"\n\nThis reverts commit 32584a7d672864b20ab8b83a3cb23c1858e908b7\n\nChange-Id: I9dc680578b955b1af462eeb7a49d61a0d45eb81b\n" }, { "commit": "32584a7d672864b20ab8b83a3cb23c1858e908b7", "tree": "87a3d8c3b801d13ceee09abab5048aef46e65332", "parents": [ "ab89ac209fd1c3b0a2227168a48d7f3ae9bc43f3" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Feb 13 14:46:45 2013 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Feb 15 15:44:50 2013 -0800" }, "message": "Temporary additional logging to investigate bug\n\nThe bug appears related to continuing to use an invalid buffer provider\nin fast mixer after track destruction, so focus the added logs in that area.\n\nAlso includes a bug fix: was calling log in an unsafe place\nnear Threads.cpp AudioFlinger::PlaybackThread::createTrack_l line 1250.\n\nDetails:\n - include caller pid or client pid where appropriate\n - increase log buffer size\n - log mFastIndex when AudioMixer sees an invalid bufferProvider.\n - log both potentially modified and actually modified tracks in FastMixer.\n - fix benign bug where sq-\u003eend() was called more than once.\n - log StateQueue push() call and return.\n - increase StateQueue size from 4 to 8 entries\n - log mixer-\u003eenable(), bufferProvider, and currentTrackMask\n - log buffer provider addresses\n - increase fast mixer log buffer again\n - check logf format vs. argument list compatibility\n - add logging to AudioMixer\n - add checking of magic field in AudioMixer to detect overwrites\n - add bool AudioMixer::enabled()\n - increase log buffer sizes yet again\n - enable assertion checking without ALOGV\n - improve a few log messages\n - check for corruption in more places\n - log in all the process hooks\n - add new mixer APIs so we can check for corruption of mixer state\n - fix a build warning\n\nBug: 6490974\nChange-Id: Ib0c4a73dcf606ef9bd898313b3b40ef61ab42f51\n" }, { "commit": "e186b51e0a9834b287d7a509e960eaf1b688db75", "tree": "82b017a4c77a82fca62571eccaa3723ee93738d1", "parents": [ "639482c24c911b125398b31883ba6d55faebe28b" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Feb 14 23:57:02 2013 +0000" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Thu Feb 14 23:57:02 2013 +0000" }, "message": "Revert \"Temporary additional logging to investigate bug\"\n\nThis reverts commit 639482c24c911b125398b31883ba6d55faebe28b\n\nChange-Id: I11f2829072ab11e18b0663024f27bf31192f1d39\n" }, { "commit": "639482c24c911b125398b31883ba6d55faebe28b", "tree": "698e25baf47d4e6a10663d21ca86c3a0702fe606", "parents": [ "085205bd23c3604c1b792c3046fdae0a489c04be" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Feb 13 14:46:45 2013 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Feb 14 14:35:29 2013 -0800" }, "message": "Temporary additional logging to investigate bug\n\nThe bug appears related to continuing to use an invalid buffer provider\nin fast mixer after track destruction, so focus the added logs in that area.\n\nAlso includes a bug fix: was calling log in an unsafe place\nnear Threads.cpp AudioFlinger::PlaybackThread::createTrack_l line 1250.\n\nDetails:\n - include caller pid or client pid where appropriate\n - increase log buffer size\n - log mFastIndex when AudioMixer sees an invalid bufferProvider.\n - log both potentially modified and actually modified tracks in FastMixer.\n - fix benign bug where sq-\u003eend() was called more than once.\n - log StateQueue push() call and return.\n - increase StateQueue size from 4 to 8 entries\n - log mixer-\u003eenable(), bufferProvider, and currentTrackMask\n - log buffer provider addresses\n - increase fast mixer log buffer again\n - check logf format vs. argument list compatibility\n - add logging to AudioMixer\n - add checking of magic field in AudioMixer to detect overwrites\n - add bool AudioMixer::enabled()\n\nBug: 6490974\nChange-Id: I1f3f18aa62d9fbd35bc32285b669f5ba40efe28e\n" }, { "commit": "51eb3965caa8ba135bcdd8ffb7a2024a042ecdc0", "tree": "0444520a23aa61553f9cf8bb67ee0f8127096b6a", "parents": [ "0ddd56316262ac74a95e9edb595697c163136d6d" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Feb 14 00:02:36 2013 +0000" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Thu Feb 14 00:02:36 2013 +0000" }, "message": "Revert \"Temporary additional logging to investigate bug\"\n\nThis reverts commit 0ddd56316262ac74a95e9edb595697c163136d6d\n\nChange-Id: I180a928af6f5a38d15a5efe44cd1fe927b5d961c\n" }, { "commit": "0ddd56316262ac74a95e9edb595697c163136d6d", "tree": "2ed313557a019eeba286e27a3f4ce2e0a45fba17", "parents": [ "cd27b0798f6abb34e464acc7c7e97e066cd3c6c7" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Feb 13 14:46:45 2013 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Feb 13 14:51:50 2013 -0800" }, "message": "Temporary additional logging to investigate bug\n\nThe bug appears related to continuing to use an invalid buffer provider\nin fast mixer after track destruction, so focus the added logs in that area.\n\nAlso includes a bug fix: was calling log in an unsafe place\nnear Threads.cpp AudioFlinger::PlaybackThread::createTrack_l line 1250.\n\nDetails:\n - include caller pid or client pid where appropriate\n - increase log buffer size\n - log mFastIndex when AudioMixer sees an invalid bufferProvider.\n - log both potentially modified and actually modified tracks in FastMixer.\n - fix benign bug where sq-\u003eend() was called more than once.\n - log StateQueue push() call and return.\n\nBug: 6490974\nChange-Id: Iee7c8f40e20b6000cd8286c0ec6a14fff4a37af1\n" }, { "commit": "ae162976dda428671af09a8fbc3f03173a7e6f3e", "tree": "23916ae7df8025a16a1d7e5b26a0e699e0236fb6", "parents": [ "9ff1087c2c53a5b3c3c3abbc6d6c1d142f65b33a", "761430930a7335d714af0f7c1d497feb8f9f0a5a" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Mon Dec 10 16:08:07 2012 -0800" }, "committer": { "name": "Android Git Automerger", "email": "android-git-automerger@android.com", "time": "Mon Dec 10 16:08:07 2012 -0800" }, "message": "am 76143093: am f0ff908d: Logging to investigate a crash\n\n* commit \u0027761430930a7335d714af0f7c1d497feb8f9f0a5a\u0027:\n Logging to investigate a crash\n" }, { "commit": "f0ff908da019a44115109f1b4d1b6864b35a8a29", "tree": "26878ce2fbb731f6cdd47a55ff1cfae54e9e58ee", "parents": [ "47c1a5f7c13d82aa8834fd4543bd1d713b97808e" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Dec 07 14:13:35 2012 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Dec 07 16:19:09 2012 -0800" }, "message": "Logging to investigate a crash\n\nBug: 6490974\nChange-Id: Ib926a9258bde4ee05ed42eea662dff68e426a997\n" }, { "commit": "85ab62c4b433df3f1a9826bed1c9bec07a86c750", "tree": "0c5443a20824924cb7403f4cabfee84062489793", "parents": [ "5fe6138bd839297a1eed16885102b3bdfc98c040" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Nov 01 11:11:38 2012 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Nov 01 12:19:25 2012 -0700" }, "message": "Line length 100\n\nChange-Id: Ib28fd7b9ce951a6933f006e7f8812ba617625530\n" }, { "commit": "599fabc596687efa4b71b8f3ebbb957c7cae0c72", "tree": "4fa21abc3355a8ac8d4c91a6e101d76bb3c17b80", "parents": [ "692c3e54c63aaaf7e9ef4d89761f98975bd34f33" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Mar 08 12:33:37 2012 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Oct 26 15:50:45 2012 -0700" }, "message": "Document AudioMixer hard-coded limits\n\nChange-Id: I83ea8bed375f251260945db788bdb5f280dba12d\n" }, { "commit": "d192e5f15c395daa87f4f198154379ee7c93d528", "tree": "9dcd60888b97045ccf108808efb0c51fba974392", "parents": [ "e50eb89bad3cb457ed7930225c47c6c4cb8534f5", "f12b1c8162d5b8cd1021daf0e32c769dac3d5d56" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Oct 04 12:05:44 2012 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Oct 04 12:05:44 2012 -0700" }, "message": "resolved conflicts for merge of f12b1c81 to master\n\nChange-Id: I914a11706bd01a198e2137e0c12af0fc92ffa02b\n" }, { "commit": "ac6020508acedd316391dee42329040bf45f8d90", "tree": "034a8ac9c453dfce993c8d2568121a9b6d042bd0", "parents": [ "d69fd4d2567f9fce02252ce10d7ae3a28fc79e04" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Mon Oct 01 14:04:31 2012 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Oct 04 09:44:04 2012 -0700" }, "message": "Integrate improved coefficient sinc resampler: VHQ\n\nSummary:\nVery high quality is enabled only for 44.1 -\u003e 48 or 48 -\u003e 44.1,\n and uses low quality for all other use cases.\nTrack estimated CPU load and throttles the quality based on load;\n as currently configured it should allow up to 2 instances of very high quality.\nMedium quality and high quality are currently disabled unless explicitly requested.\n\nDetails:\nOnly load .so the first time it is needed.\nCleanup code style: formatting, indentation, whitespace.\nRestore medium quality resampler, but it is not used (see next line).\nFix memory leak for sinc resampler.\nCheck sample rate in resampler constructor.\nAdd logs for debugging.\nRename DEFAULT to DEFAULT_QUALITY for consistency with other quality levels.\nRenumber VERY_HIGH_QUALITY from 255 to 4.\nUse enum src_quality consistently.\nImprove parsing of property af.resampler.quality.\nFix reentrancy bug - allow an instance of high quality and an instance\n of very high quality to both be active concurrently.\n\nBug: 7229644\nChange-Id: I0ce6b913b05038889f50462a38830b61a602a9f7\n" }, { "commit": "d06e132358d44f02c22527b4f463df1f58da9216", "tree": "26cd7f3324f6c50726ed0377f3137e38f316aab3", "parents": [ "4b2247510410ef71718199ea028ace8609e92fdd" ], "author": { "name": "Jean-Michel Trivi", "email": "jmtrivi@google.com", "time": "Wed Sep 12 15:47:07 2012 -0700" }, "committer": { "name": "Jean-Michel Trivi", "email": "jmtrivi@google.com", "time": "Wed Sep 12 15:49:56 2012 -0700" }, "message": "Communicate audio session ID to downmixer\n\nThe audio downmixer effect might need the audio session Id, pass it\n from the track creation in AudioFlinger to the downmix effect\n creation in AudioMixer.\n\nChange-Id: I836873eebd6711f1048fce81cd2eb29b94f0ad0c\n" }, { "commit": "fe3156ec6fd9fa57dde913fd8567530d095a6550", "tree": "2c4b8250d0089a7d9f396d40005f4fefd95f46f3", "parents": [ "66765846726c02db16a0f024f2217990a90802c0" ], "author": { "name": "Jean-Michel Trivi", "email": "jmtrivi@google.com", "time": "Mon Sep 10 18:58:27 2012 -0700" }, "committer": { "name": "Jean-Michel Trivi", "email": "jmtrivi@google.com", "time": "Mon Sep 10 18:58:27 2012 -0700" }, "message": "Communicate audio session ID to downmixer\n\nThe audio downmixer effect might need the audio session Id, pass it\n from the track creation in AudioFlinger to the downmix effect\n creation in AudioMixer.\n\nChange-Id: I5e29540542ae89cf4a0cdb537b3e67f04442a20a\n" }, { "commit": "037ac53aac0f51f2ccfaaa91822365c1c73c4365", "tree": "6552c46685738bf5baf41d8708066b823aaf64f5", "parents": [ "7f3a8e4cb89fadffe31a12859721866d5ca02353", "0efd035854ad2c8d20100a740e054c4bf7b3e9a4" ], "author": { "name": "Jean-Baptiste Queru", "email": "jbq@google.com", "time": "Fri Aug 10 12:48:51 2012 -0700" }, "committer": { "name": "Android Git Automerger", "email": "android-git-automerger@android.com", "time": "Fri Aug 10 12:48:51 2012 -0700" }, "message": "am 0efd0358: am fcfc61da: am ff4c64d6: am c64a1787: Merge \"Fix initialization of audio mixer track resources for MIPS.\"\n\n* commit \u00270efd035854ad2c8d20100a740e054c4bf7b3e9a4\u0027:\n Fix initialization of audio mixer track resources for MIPS.\n" }, { "commit": "fcfc61da927e98d18cdcb53da8fa0a8a32ee1422", "tree": "7dd8aadcffc35c98504f35d69fe467c0a8e8f397", "parents": [ "7edbacf24e60c01e2d3b10715ec8f9cc2f55c11a", "ff4c64d6b1b58494a1b15f1a664e5c421d095d15" ], "author": { "name": "Jean-Baptiste Queru", "email": "jbq@google.com", "time": "Fri Aug 10 12:44:02 2012 -0700" }, "committer": { "name": "Android Git Automerger", "email": "android-git-automerger@android.com", "time": "Fri Aug 10 12:44:02 2012 -0700" }, "message": "am ff4c64d6: am c64a1787: Merge \"Fix initialization of audio mixer track resources for MIPS.\"\n\n* commit \u0027ff4c64d6b1b58494a1b15f1a664e5c421d095d15\u0027:\n Fix initialization of audio mixer track resources for MIPS.\n" }, { "commit": "3c0a0e8541846427db0587c2fffb90f60ee680b0", "tree": "5ec5cfb29970fe635f34145ba9642f96fd91e9b7", "parents": [ "ffd99cb795c92caee7f4bd0b26af9ae37b100fc3" ], "author": { "name": "Paul Lind", "email": "plind@mips.com", "time": "Wed Aug 01 18:49:49 2012 -0700" }, "committer": { "name": "Paul Lind", "email": "plind@mips.com", "time": "Wed Aug 01 18:49:49 2012 -0700" }, "message": "Fix initialization of audio mixer track resources for MIPS.\n\nThe value 1 \u003c\u003c 32 (maxNumTracks defaults to 32) is surprisingly not defined\nin C, and differs on MIPS than the other arch.\n\nTherefore the track resources were not initialized properly, resulting\nin failure to play any audio.\n\nThe fix allows the mConfiguredNames bitmask to be correctly set to all\n1\u0027s in the 32-track case, for all arch.\n\nChange-Id: Ied3e1305952e9567602e2cd76c5ef3acb0809ee0\nSigned-off-by: Paul Lind \u003cplind@mips.com\u003e\n" }, { "commit": "52008f821a5202502a82a8ba2c024e69bd336350", "tree": "5daaddaa46d47bec27af0bc5350f414452710b00", "parents": [ "0a7af18d0308295405491f86603e3d119450aba0" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Sun Mar 18 09:34:41 2012 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Jul 25 18:49:08 2012 -0700" }, "message": "Share local time frequency for all tracks \u0026 mixers\n\nChange-Id: I5e6f0e371f728a5225c2fa6f778c109449d33602\n" }, { "commit": "254af180475346b6186b49c297f340c9c4817511", "tree": "bee0e313aaa97645167e86f4678e513ab38d1c99", "parents": [ "4d2132c866228eaef563e8141ebf06aa25ee9ff7" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Tue Jul 03 14:59:05 2012 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Tue Jul 10 10:05:31 2012 -0700" }, "message": "Use audio_channel_mask_t more places\n\nUse it in AudioSystem::getOutput(), AudioSystem::getInput(),\nIAudioPolicyService::getOutput(), IAudioPolicyService::getInput(),\nand various other places in AudioFlinger.\n\nNot done: AudioTrack and OutputDescriptor.\n\nChange-Id: I70e83455820bd8f05dafd30c63d636c6a47cd172\n" }, { "commit": "9bd23229fdec1657398abc682ccccfce1c95f8aa", "tree": "5a6790d8f19a3249b28a8b8da9e68e3a14bbde36", "parents": [ "0ca3cf94c0dfc173ad7886ae162c4b67067539f6" ], "author": { "name": "Jean-Michel Trivi", "email": "jmtrivi@google.com", "time": "Mon Apr 16 13:43:48 2012 -0700" }, "committer": { "name": "Jean-Michel Trivi", "email": "jmtrivi@google.com", "time": "Wed Apr 18 17:40:48 2012 -0700" }, "message": "Fix multichannel downmix pause bug on video player\n\nPausing a video player will cause the track audio mixer to be\n disabled, which causes the downmixer to be deleted. When reenabled,\n the track channel mask hasn\u0027t changed but the downmixer is there\n anymore.\nFixed by:\n- instanciating a downmixer when the AudioMixer track\n gets initialized (in getTrackName(), now taking a channel mask\n as input), and deleted when in deleteTrackName().\n- when the channel changes on a track, check whether it\n needs a downmixer or not. Preparing a track for downmix\n automatically removes the old downmixer if there was one.\n\nAlso: initialize the track downmixerBufferProvider field\n when AudioMixer is instanciated, so we can safely call\n delete on it in AudioMixer\u0027s destructor, in case\n deleteTrackName() wasn\u0027t called before the mixer was\n destroyed.\n\nChange-Id: I589b0781cda5b3c82f85b561c52b08546cac21f8\n" }, { "commit": "acb86cccbd9d245439a04cef0bcefa589addaa4c", "tree": "597fe66a314f3bc8a4c1746f9d9bbff0a8bd1067", "parents": [ "97b5d0d5b5ef766eb5dd680d05a5d199662d4ae0" ], "author": { "name": "Jean-Michel Trivi", "email": "jmtrivi@google.com", "time": "Mon Apr 16 12:43:57 2012 -0700" }, "committer": { "name": "Jean-Michel Trivi", "email": "jmtrivi@google.com", "time": "Wed Apr 18 09:29:45 2012 -0700" }, "message": "Configure the resampler with the correct channel count when downmixing\n\nWhen a track needs to be downmixed and resampled, it gets downmixed\n first before being resampled. Therefore the resampler needs to\n be configured with the channel count of the output of the downmixer\n instead of that of the track.\nRemoved frame size checks that don\u0027t apply anymore now that we support\n frame sizes that are not powers of 2 (e.g. 12 for 5.1 16bits), and\n changed test performed for every buffer during playback into an\n assert.\n\nChange-Id: Ia220f00ee382f4f7848b661c58555bdca664e194\n" }, { "commit": "4e2293f29f2e719af1245d365747ea06d074b345", "tree": "d07878412ffeca6ccd4e7e4bbbc0b4fb68370a59", "parents": [ "99a80e10f2d0e88c0509a298bdd1df0308b55a7b" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Apr 12 09:39:07 2012 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Mon Apr 16 17:43:58 2012 -0700" }, "message": "AudioMixer new cmd: remove sample rate converter\n\nAdd a new command REMOVE to remove any sample rate converter\n on a track, without having to delete the track name.\nAdd comments.\nRemove some dead code.\nFix whitespace and comparison to NULL.\n\nChange-Id: Id55a23ab5ee673189e99675b4e6fa5df7b617987\n" }, { "commit": "a5e821439996de6005b2fa36b3bdd31f003ce23f", "tree": "04520106c0140dfeae4baff583749bf250e7b81f", "parents": [ "a98db787397633155fd71b06ecaa765a7ad20cf2" ], "author": { "name": "Eric Laurent", "email": "elaurent@google.com", "time": "Mon Apr 16 13:47:17 2012 -0700" }, "committer": { "name": "Eric Laurent", "email": "elaurent@google.com", "time": "Mon Apr 16 14:31:24 2012 -0700" }, "message": "AudioMixer: fix crash in destructor\n\nCommit deeb1282 made that track-\u003eresampler is only set to NULL when\ngetTrackName() is called. It remains uninitialized for all unused tracks\ncausing a crash when deleted by Audiomixer destructor.\n\nIssue 6309441.\n\nChange-Id: I49451387a6afe81299b8368ef206524df32f74c4\n" }, { "commit": "7d5b26230a179cd7bcc01f6578cd80d8c15a92a5", "tree": "563086c1185e0e54770d8c60c8eec1aefdddb89f", "parents": [ "4b75a9c8b93a90749bc5d22912ad0d96c12f4ecf" ], "author": { "name": "Jean-Michel Trivi", "email": "jmtrivi@google.com", "time": "Wed Apr 04 18:54:36 2012 -0700" }, "committer": { "name": "Jean-Michel Trivi", "email": "jmtrivi@google.com", "time": "Mon Apr 09 11:27:14 2012 -0700" }, "message": "AudioMixer uses downmix effect for multichannel content\n\nIn the AudioMixer structure associated with each track, add an object\n that acts as the buffer provider when the track has more than two\n channels of input in the mixer. This object, DownmixerBufferProvider,\n gets audio from the actual buffer provider of the track, and applies\n a downmix effect on it.\nThe downmix effect is created and configured when the track gets\n created in AudioFlinger, which causes AudioMixer::getTrackName()\n to be called with the new track\u0027s channel mask. It is released\n when the track is disabled in the mixer.\n\nChange-Id: I05281ed5f61bef663a8af7ca7d5ceac3517c82db\n" }, { "commit": "deeb1282621f3177ad667360b40eef8e4fedb298", "tree": "595d49e01dc93258bc061052f103e45e2811b129", "parents": [ "a1472d9883e35edd280201c8be3191695007dfd4" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Sun Mar 25 11:59:31 2012 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Sun Apr 01 14:57:33 2012 -0700" }, "message": "AudioMixer default track parameters\n\nMove the default initialization of track parameters from the AudioMixer\nconstructor to getTrackName(). This fixes a bug where the defaults were\nonly valid the first time a name was allocated.\n\nAlso added a switch case for parameter FORMAT.\n\nChange-Id: I07abd3aaf7f4efe9825a761d2bc662aaee2c6db0\n" }, { "commit": "ccf89b54f973f11082150d02ed957f7e967fbc8b", "tree": "b3446119a9b6c03dcca98d1d9ee31a83adb8acad", "parents": [ "63c1faa8dea7feb90255d31ef2a133d8f2818844", "5c94b6c7689a335e26a86e8a0d04b56dc627738e" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Mar 21 08:19:04 2012 -0700" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Wed Mar 21 08:19:04 2012 -0700" }, "message": "Merge \"AudioMixer can be configured for fewer max tracks\"" }, { "commit": "63c1faa8dea7feb90255d31ef2a133d8f2818844", "tree": "973c66b51e7e85b6ea753b5643f7d99c66d82dde", "parents": [ "7153494670bdac8b650cb10b8b1838651e0ca418", "17a736c3e1d062d7fc916329eb32aef8935614af" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Mar 21 07:24:21 2012 -0700" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Wed Mar 21 07:24:21 2012 -0700" }, "message": "Merge \"Update comments\"" }, { "commit": "5c94b6c7689a335e26a86e8a0d04b56dc627738e", "tree": "05dcb7c6007c923a4f3ef04371e62834940a66b0", "parents": [ "6da08fc33642b832d1cde2e46815a5fd67dd0016" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Tue Mar 20 17:01:29 2012 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Tue Mar 20 17:27:10 2012 -0700" }, "message": "AudioMixer can be configured for fewer max tracks\n\nChange-Id: I371b17cef071d083eecf35cd3627a3adff907a33\n" }, { "commit": "ea7939a079b3600cab955760839b021326f8cfc3", "tree": "570fb56838735a46a28e28a4f083d763f758ea24", "parents": [ "eb76ff27c13386eb5a2dad73b1a8366f80eb0ff7" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Mar 14 12:56:26 2012 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Mon Mar 19 17:53:33 2012 -0700" }, "message": "Whitespace\n\nFix indentation, and add blank lines in key places for clarity\n\nChange-Id: I57a0a8142394f83203161aa9b8aa9276abf3ed7c\n" }, { "commit": "17a736c3e1d062d7fc916329eb32aef8935614af", "tree": "7fb73e48de8641ce6ad7b65fb4204bc60cd3e5f0", "parents": [ "1746929ddc7592ab397c402724a61352e45df093" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Tue Feb 14 08:52:15 2012 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Mon Mar 19 14:12:01 2012 -0700" }, "message": "Update comments\n\nChange-Id: I327663a020670d0a72ff57bd0b682e2ce0528650\n" }, { "commit": "5798d4ebf236357a4b13246f40e52b90a34d09a4", "tree": "b9cb82b889bee3c6b32bfa2d2870bd88034b0fdd", "parents": [ "73f4bc33e0d458933460250a47c64aa868c05f97" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Mar 08 12:18:35 2012 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Mon Mar 12 15:56:50 2012 -0700" }, "message": "Clean up assertion checks\n\nUse ALOG_ASSERT instead of assert.\nUse compile-time asserts where appropriate.\nFix typo in an ALOGV.\n\nChange-Id: I58f1c1ffc14319a022c88b5a88b8d0368660da8b\n" }, { "commit": "01c4ebf6b794493898114a502ed36de13137f7e5", "tree": "7f663fdad4040a40411e79d837c14e52e11a65b9", "parents": [ "d6fd85a157ce2054b2304e6d171fa87ae09c363d" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Feb 22 10:47:35 2012 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Feb 24 13:42:13 2012 -0800" }, "message": "AudioBufferProvider comments and cleanup\n\nAdd comments about which methods implement the AudioBufferProvider interface.\n\nSimplified the definition of kInvalidPts. \u003cstdint.h\u003e is very hard to work\nwith, there seems to be no way to use it reliably to get INT64_MAX without\nhaving a separate source file, which is ugly because it means kInvalidPts\nis not a compile-time constant. So I just deleted AudioBufferProvider.cpp\nand used a hard-coded constant instead.\n\nAdded a default constructor for Buffer so that the fields aren\u0027t random\n(especially .raw which is used to determine if the buffer is valid).\n\nMake the pts for getNextBuffer default to kInvalidPTS so code that\ndoesn\u0027t need a pts doesn\u0027t have to specify a value.\n\nRename the parameter to AudioMixer::setBufferProvider to make it clearer.\n\nChange-Id: I87e7290884d4ed975b019f62d1ab6ae2bc5065a5\n" }, { "commit": "3b81acab52b7140c1b8b20be2d67be3e221637e7", "tree": "0b225360603f19ba2f60fb1cf7a616dfe51d99b1", "parents": [ "1b094ee8f7fe7eca65bf3d2f983ba95eef6db93d" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Jan 27 15:26:23 2012 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Feb 17 09:41:56 2012 -0800" }, "message": "Remove bit fields to improve performance\n\nuint16_t enabled is (mostly) changed to bool in a separate CL\n\nChange-Id: Ied9f8c034b2479cee9a8778cee7b8ff92ae75b7b\n" }, { "commit": "a111792f1314479c649d1d44c30c2caf70c00c2a", "tree": "f67b5f32a61a259f292b7d0d992f31b8e2ff857c", "parents": [ "761defc341c5ce9019a42919c441f035f665ec0d" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Jan 26 10:53:32 2012 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Feb 17 09:39:07 2012 -0800" }, "message": "Simplify code\n\nUse DefaultKeyedVector::valueFor to avoid extra test\nMake local variables as local as possible\nNo double parentheses\nNo typedef for single use\nNo parentheses around indirect function call\nNo AudioFlinger:: prefix when not needed\nRemove unnecessary casts\nRemove block with only one line\n\nSaves 128 bytes\n\nChange-Id: I3a87430eeb01b81e7b81a1c38f6fdd3274ec48f3\n" }, { "commit": "4ff14bae91075eb274eb1c2975982358946e7e63", "tree": "e9e54fddb9832d30b69c2a11c9ed2884397f2f95", "parents": [ "951bd8d1ad9581a414e171ad8605a9515d0ad667" ], "author": { "name": "John Grossman", "email": "johngro@google.com", "time": "Wed Feb 08 16:37:41 2012 -0800" }, "committer": { "name": "John Grossman", "email": "johngro@google.com", "time": "Thu Feb 16 13:45:11 2012 -0800" }, "message": "Upintegrate Audio Flinger changes from ICS_AAH\n\nBring in changes to audio flinger made to support timed audio tracks\nand HW master volume control.\n\nChange-Id: Ide52d48809bdbed13acf35fd59b24637e35064ae\nSigned-off-by: John Grossman \u003cjohngro@google.com\u003e\n" }, { "commit": "99e53b86eebb605b70dd7591b89bf61a9414ed0e", "tree": "8939550ada02fe21121550a83952ebf7638c0dac", "parents": [ "6dbc1359f778575d09d6da722b060a6d72c2e7c5" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Jan 19 08:59:58 2012 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Tue Feb 14 09:17:59 2012 -0800" }, "message": "Update comments\n\nWe no longer put the filename at start of file.\n\nChange-Id: Ic435b159a23105681e3d4a6cb1ac097bc853302e\n" }, { "commit": "63d2daed17ab749baa80bc808fb5083b688b771b", "tree": "735cfc77d2082c044816fe367f33401fd5b472c7", "parents": [ "4f9b0c54011eb8fd2ccfb393c2dcd51cd07800e0", "c59c004a3a6042c0990d71179f88eee2ce781e3c" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Feb 08 08:39:39 2012 -0800" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Wed Feb 08 08:39:39 2012 -0800" }, "message": "Merge \"AudioFlinger methods const and inline\"" }, { "commit": "4c340c6521b634f159d2d6bc4e9359226fd8edf8", "tree": "7cfdf3bedccd84f751909ee5866871576250f274", "parents": [ "787bae0578fbaab6219ebf23494866b224d01438" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Jan 27 12:33:54 2012 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Feb 03 15:36:47 2012 -0800" }, "message": "Use bool instead of int\n\nThe .h is not modified to avoid increasing data size.\n\nChange-Id: Ide4a821a5b16424ffa03471dfff98dc3e9b5f751\n" }, { "commit": "c59c004a3a6042c0990d71179f88eee2ce781e3c", "tree": "68e0c9bb6d5bb10a1a8263ebefbb5601946702ee", "parents": [ "787bae0578fbaab6219ebf23494866b224d01438" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Feb 02 14:06:11 2012 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Feb 03 15:25:24 2012 -0800" }, "message": "AudioFlinger methods const and inline\n\nThis saves 1063 bytes and probably improves performance.\n\nChange-Id: I11cf0dfd925fbaec75e3d1b806852a538eae5518\n" }, { "commit": "a0d68338a88c2ddb4502f95017b546d603ef1ec7", "tree": "f052125f4720fde00179d41d4ee04e02934052e4", "parents": [ "87f155d6655b2d3b27e69281a29e85c6407e4d26" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Jan 27 16:47:15 2012 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Feb 03 07:57:01 2012 -0800" }, "message": "Use NULL not 0 for raw pointers\n\nUse if (p !\u003d NULL) instead of if (ptr)\n\nChange-Id: Iaec3413a59ccbf233c98fcd918cc7d70ac5da9fa\n" }, { "commit": "84afa3b51ac48f84ed62489529ce78cba7fca00e", "tree": "ee9ba57cdc17668c9362b70f6bfbfcbd40a253ad", "parents": [ "5c0ad10b14ec2287f90f95912d98e66eef006e2a" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Jan 25 15:28:08 2012 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Feb 03 07:37:14 2012 -0800" }, "message": "Constructor initialization and const fields\n\nIn constructors, initialize member fields in the initialization list\nrather than constructor body where possible. This allows more fields\nto be const, provided they are never modified.\n\nAlso initialize POD fields in constructor, unless it\u0027s obvious they\ndon\u0027t need to be initialized. In that case, put a comment instead.\n\nRemove explicit clear() in destructors on fields that are now const.\n\nGive AudioSessionRef a default constructor, so it\u0027s immutable fields can\nbe marked const.\n\nAdd comment about ~TrackBase() trick.\n\nInitialize fields in declaration order to make it easier to confirm that\nall fields are set.\n\nMove initialization of mHardwareStatus from onFirstRef() to constructor.\n\nUse NULL not 0 to initialize raw pointers in initialization list.\n\nRename field mClient to mAudioFlingerClient, and getter from client()\nto audioFlingerClient().\n\nChange-Id: Ib36cf6ed32f3cd19003f40a5d84046eb4c122052\n" }, { "commit": "e9dd0176933d6233916c84e18f3e8c0d644ca05d", "tree": "456651a5f40cbd404d39abb20604817324926db3", "parents": [ "fd267d7cf640225bb57f0ed1af44efc153275f6d" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Jan 27 18:08:45 2012 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Jan 27 18:08:45 2012 -0800" }, "message": "Unconditional delete\n\nDon\u0027t check that pointer is non-NULL before delete.\n\nDon\u0027t leave deleted member fields non-NULL, except in a destructor,\nsince it could be misleading in a dump or debugger. (mRsmpOutBuffer)\n\nChange-Id: Ic0492a6b752f74a67f4c96dfb89ca2de4e69eecf\n" }, { "commit": "02b2d2dddc9be339cf7647d4ead53cecd1c51038", "tree": "4a743ee6a972a2d35b2cb4a9f73234bd31dc8440", "parents": [ "c1dc1cb1d1eaf84e88669f1a5f22579a0d9237c2", "f9a27779634ce3a01e5957f234cd04eba74fa07f" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Jan 11 10:01:34 2012 -0800" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Wed Jan 11 10:01:34 2012 -0800" }, "message": "Merge \"Fix build warning\"" }, { "commit": "5f29ca38b71506ad7c7cb9925efbddf588e9655b", "tree": "e67bef8a10e8705ebe0f43fbf49d27764a362040", "parents": [ "25b248eb52a0a16adaef6b79c9d92cb88b9a2bc2", "54c3b66444ebfb9f2265ee70ac3b76ccefa0506a" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Mon Jan 09 11:59:17 2012 -0800" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Mon Jan 09 11:59:17 2012 -0800" }, "message": "Merge \"By convention const goes before the type specifier\"" }, { "commit": "879bc64e43d62f2690c77a3282cef2e45d1b76e9", "tree": "40952192d397dcff30df01558c68c11ef675cb7f", "parents": [ "5c7b3bcc88e2b472f1f7b416d89222714b96a567", "98dd542ffcd3424b1da58bd273c0c1ff5b8c8960" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Mon Jan 09 10:25:00 2012 -0800" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Mon Jan 09 10:25:00 2012 -0800" }, "message": "Merge \"Replace loop by __builtin_ctz\"" }, { "commit": "29357bc2c0dd7c43ad3bd0c8e3efa4e6fd9bfd47", "tree": "3bdafe4b02fe36f6ee29c3170f0b0d2799bebf86", "parents": [ "d709ca9c6a0fa1c8f40cbe624a119398643c5087" ], "author": { "name": "Steve Block", "email": "steveblock@google.com", "time": "Fri Jan 06 19:20:56 2012 +0000" }, "committer": { "name": "Steve Block", "email": "steveblock@google.com", "time": "Sun Jan 08 13:19:13 2012 +0000" }, "message": "Rename (IF_)LOGE(_IF) to (IF_)ALOGE(_IF) DO NOT MERGE\n\nSee https://android-git.corp.google.com/g/#/c/157220\n\nBug: 5449033\nChange-Id: Ic9c19d30693bd56755f55906127cd6bd7126096c\n" }, { "commit": "54c3b66444ebfb9f2265ee70ac3b76ccefa0506a", "tree": "2ae6ae86501101399d639f2a1227742c120e7ac8", "parents": [ "a2a0a5d7d56baa831870f4bf2a0d942a477d92ef" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Jan 06 07:46:30 2012 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Jan 06 08:00:59 2012 -0800" }, "message": "By convention const goes before the type specifier\n\nChange-Id: I70203abd6a6f54e5bd9f1412800cc01212157e58\n" }, { "commit": "f9a27779634ce3a01e5957f234cd04eba74fa07f", "tree": "d22f89179467963dc03ae1aa900c539c3c1e9d1c", "parents": [ "a2a0a5d7d56baa831870f4bf2a0d942a477d92ef" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Jan 06 07:47:26 2012 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Jan 06 07:49:34 2012 -0800" }, "message": "Fix build warning\n\nChange-Id: Ic99608d0c14ed56c02f036e0bbaaae1b16bab8ba\n" }, { "commit": "5ff1dd576bb93c45b44088a51544a18fc43ebf58", "tree": "c002dcda87f08329197b01395539bd25f10ca737", "parents": [ "8a08dcc0a5de19a904e77d5f31bed3dff9a59890" ], "author": { "name": "Steve Block", "email": "steveblock@google.com", "time": "Thu Jan 05 23:22:43 2012 +0000" }, "committer": { "name": "Steve Block", "email": "steveblock@google.com", "time": "Fri Jan 06 10:07:54 2012 +0000" }, "message": "Rename (IF_)LOGW(_IF) to (IF_)ALOGW(_IF) DO NOT MERGE\n\nSee https://android-git.corp.google.com/g/157065\n\nBug: 5449033\nChange-Id: I00a4b904f9449e6f93b7fd35eac28640d7929e69\n" }, { "commit": "98dd542ffcd3424b1da58bd273c0c1ff5b8c8960", "tree": "e3bc2deb104359535cb71f9f728cfb197298cda6", "parents": [ "a2a0a5d7d56baa831870f4bf2a0d942a477d92ef" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Dec 15 14:38:29 2011 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Jan 05 15:31:19 2012 -0800" }, "message": "Replace loop by __builtin_ctz\n\nUsing the builtin is faster on some platforms, for example on ARM it\u0027s\n19 instructions instead of 13, and is O(1) instead of O(n). Of course,\ntrack creation is an inherently slow operation, so this doesn\u0027t matter\nmuch now. But if we add support for virtual tracks, then physical tracks\nwill be allocated/freed more frequently. Also just on principle ...\n\nChange-Id: I3f590934092bd7a1869cbedbc7357928aa5cc8ff\n" }, { "commit": "88592eccaf6afcddd5f985955be92fe25205c680", "tree": "5a1795bd7aefe20d332f7388d8cddcadc3df841a", "parents": [ "a2a0a5d7d56baa831870f4bf2a0d942a477d92ef", "9c56d4ae6212c21ce5fd71ed534eb195983a07c1" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Jan 05 08:20:10 2012 -0800" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Thu Jan 05 08:20:10 2012 -0800" }, "message": "Merge \"Remove the notion of \"active track\" from mixer\"" }, { "commit": "a2a0a5d7d56baa831870f4bf2a0d942a477d92ef", "tree": "1979692770dd902d0aa7e8c0760e496e13539e5c", "parents": [ "7ab41c9f773ba599646f1b0d00955c1be80f92fd", "f6b1678f8f508b447155a81b44e214475ab634a8" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Jan 05 07:38:29 2012 -0800" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Thu Jan 05 07:38:29 2012 -0800" }, "message": "Merge \"Use the standard CC_LIKELY and CC_UNLIKELY macros\"" }, { "commit": "f6b1678f8f508b447155a81b44e214475ab634a8", "tree": "dabe2858dfed9133c6a270cd6b86877a9d3588b1", "parents": [ "94023fa6744e24f26f0aba1699ec278649bd66df" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Dec 15 09:51:17 2011 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Jan 05 07:33:45 2012 -0800" }, "message": "Use the standard CC_LIKELY and CC_UNLIKELY macros\n\nSeveral source files privately defined macros LIKELY and UNLIKELY in terms\nof __builtin_expect. But \u003ccutils/compiler.h\u003e already has CC_LIKELY and\nCC_UNLIKELY which are intended for this purpose. So rename the private\nuses to use the standard names.\n\nIn addition, AudioFlinger was relying on the macro expanding to extra ( ).\n\nChange-Id: I2494e087a0c0cac0ac998335f5e9c8ad02955873\n" }, { "commit": "7ab41c9f773ba599646f1b0d00955c1be80f92fd", "tree": "02a8e0276a550d6748b64e6b4e165dd562712859", "parents": [ "b8a805261bf0282e992d3608035e47d05a898710", "fe0698f9d44ca923ff1ba528f2c42019937ea5e2" ], "author": { "name": "Eric Laurent", "email": "elaurent@google.com", "time": "Wed Jan 04 17:39:12 2012 -0800" }, "committer": { "name": "Eric Laurent", "email": "elaurent@google.com", "time": "Wed Jan 04 17:39:12 2012 -0800" }, "message": "resolved conflicts for merge of 1a4b9939 to master\n\nChange-Id: I0c910d391a38a916d8431f7d1f5b82e39e1a66c2\n" }, { "commit": "b8a805261bf0282e992d3608035e47d05a898710", "tree": "7a43908b8e936ac1f30eef0542b40d667c47aa23", "parents": [ "94023fa6744e24f26f0aba1699ec278649bd66df" ], "author": { "name": "Steve Block", "email": "steveblock@google.com", "time": "Tue Dec 20 16:23:08 2011 +0000" }, "committer": { "name": "Steve Block", "email": "steveblock@google.com", "time": "Tue Jan 03 22:38:27 2012 +0000" }, "message": "Rename (IF_)LOGD(_IF) to (IF_)ALOGD(_IF) DO NOT MERGE\n\nSee https://android-git.corp.google.com/g/156016\n\nBug: 5449033\nChange-Id: I4c4e33bb9df3e39e11cd985e193e6fbab4635298\n" }, { "commit": "071ccd5a9702500f3f7d62ef881300914926184d", "tree": "2ffdfd9dbc064aa3d2a9b229f87b679220ef4f79", "parents": [ "69aac3e6cd68e8c305a41b2677123db7662efd4b" ], "author": { "name": "Eric Laurent", "email": "elaurent@google.com", "time": "Thu Dec 22 16:08:41 2011 -0800" }, "committer": { "name": "Eric Laurent", "email": "elaurent@google.com", "time": "Thu Dec 22 16:08:41 2011 -0800" }, "message": "audioflinger: fix clicks on 48kHz audio.\n\nThe calculation done in prepareTracks_l() for the minimum amount\noff frames needed to mix one output buffer had 2 issues:\n- the additional sample needed for interpolation was not included\n- the fact that the resampler does not acknowledge the frames consumed\nimmediately after each mixing round but only once all frames requested have been used\nwas not taken into account.\nThus the number of frames available in track buffer could be considered sufficient although\nit was not and the resampler would abort producing a short silence perceived as a click.\n\nIssue 5727099.\n\nChange-Id: I7419847a7474c7d9f9170bedd0a636132262142c\n" }, { "commit": "9c56d4ae6212c21ce5fd71ed534eb195983a07c1", "tree": "417c958c4fd243f4edb7bc765f4dc1e709456ddc", "parents": [ "bbaf8673f1d1dd79d1b7f474ca7111da58e84aff" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Mon Dec 19 15:06:39 2011 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Tue Dec 20 16:29:21 2011 -0800" }, "message": "Remove the notion of \"active track\" from mixer\n\nThis is a first step towards making the mixer more object-oriented.\n\nChange-Id: Ifd445d0e471023a7f5c82e934736ffc95ba1b05b\n" }, { "commit": "12d9702773c8a3242a44dd6528126c9ff0dade43", "tree": "a0184b1a6a55a924143411129a4cd13d9dbcaa08", "parents": [ "bbaf8673f1d1dd79d1b7f474ca7111da58e84aff", "81a028fef62bcadf13fc8550067a3d29c918b3ca" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Tue Dec 20 10:29:49 2011 -0800" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Tue Dec 20 10:29:49 2011 -0800" }, "message": "Merge \"Remove dead code\"" }, { "commit": "81a028fef62bcadf13fc8550067a3d29c918b3ca", "tree": "9d2c12b20abcf5e1aad3522678e685b173db776b", "parents": [ "eebeceec684a36222b4559e3157b0db04c0a67ed" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Dec 15 09:53:12 2011 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Mon Dec 19 15:55:47 2011 -0800" }, "message": "Remove dead code\n\nChange-Id: Icf23f7f90fdeb660f4015f22cf239e6d05f5d03c\n" }, { "commit": "f602a5f7f29e694a7da4c143737b74501c00477d", "tree": "c7edef89cc88918b8cb04168253664470de77036", "parents": [ "d1e672acd8fa1af899f85ee2321327237028adf8", "bf71f1e7948406492376c6cbd5e6a30c8cb670e4" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Dec 16 15:10:36 2011 -0800" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Fri Dec 16 15:10:36 2011 -0800" }, "message": "Merge \"Use constants for 2 and 32\"" }, { "commit": "d1e672acd8fa1af899f85ee2321327237028adf8", "tree": "bdcc71f510c339222d386c07a0e40121f1ab15b9", "parents": [ "b92bc47a05925c29efef0d66711b6d3f17f406e7", "3b21c50ef95fe4e7ac3426ca14b365749e66ff08" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Dec 16 15:02:30 2011 -0800" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Fri Dec 16 15:02:30 2011 -0800" }, "message": "Merge \"Extract out audio DSP code to utility library\"" }, { "commit": "bf71f1e7948406492376c6cbd5e6a30c8cb670e4", "tree": "077a8a894c95655353bd5ffec7c4c93f1d36b9be", "parents": [ "b92bc47a05925c29efef0d66711b6d3f17f406e7" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Tue Dec 13 11:52:35 2011 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Dec 16 14:55:05 2011 -0800" }, "message": "Use constants for 2 and 32\n\nChange-Id: If820dfd58b6df258570750610a07af99598d9e53\n" }, { "commit": "b92bc47a05925c29efef0d66711b6d3f17f406e7", "tree": "2e953cde5bf4b7ca0bc45cdf33cc78044660309f", "parents": [ "237a624f674800d2300806b115eee8c9bb7db033", "788040c5189bbdaf567ce4b29ffd1db08ea1020c" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Dec 16 13:31:33 2011 -0800" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Fri Dec 16 13:31:33 2011 -0800" }, "message": "Merge \"Use switch in AudioMixer::setParameter\"" }, { "commit": "788040c5189bbdaf567ce4b29ffd1db08ea1020c", "tree": "75cf254063bf823fd2e5ff6c3504ecc2c37bb488", "parents": [ "154a7fbda9b704bc1d23b6f17573016ebb5989be" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu May 05 08:19:00 2011 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Dec 16 13:28:33 2011 -0800" }, "message": "Use switch in AudioMixer::setParameter\n\nReplace series of if/then/elses by easier-to-read switch. Also return\nvoid instead of status_t, since callers weren\u0027t checking it. Assert on\nbad input parameters.\n\nChange-Id: Ie1f0a297977b28501d20e1af819afed9b4750616\n" }, { "commit": "237a624f674800d2300806b115eee8c9bb7db033", "tree": "edf7370358ef705903fe8ba8abfb7f0103d76ed5", "parents": [ "154a7fbda9b704bc1d23b6f17573016ebb5989be" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Dec 15 15:32:27 2011 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Dec 16 13:22:41 2011 -0800" }, "message": "deleteTrackName now asserts on bad input parameter\n\nThis is safe, as the input parameter is always track-\u003ename(),\nwhich must be valid.\n\nChange-Id: Iea8ea3a5706c27026335526ba8851030d00681f8\n" }, { "commit": "3b21c50ef95fe4e7ac3426ca14b365749e66ff08", "tree": "e3f9a8d6ab695bd1d4d494fbf1b9d80bcc25585c", "parents": [ "eebeceec684a36222b4559e3157b0db04c0a67ed" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Dec 15 09:52:39 2011 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Dec 16 11:42:03 2011 -0800" }, "message": "Extract out audio DSP code to utility library\n\nChange-Id: Ib8ce72028a7ea30e82baa518e381370e820ebbd0\n" }, { "commit": "6d4bf6eda04888144ec59cba4816a2cbb79b9e5c", "tree": "213424db0d71f1de94ea2789d272595287664bf6", "parents": [ "b87c068727a15a3d3f0bfdcb758c76a097f5e869", "fba380a0b2c62684ce4272a05165965bae29d6a1" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Dec 16 07:30:14 2011 -0800" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Fri Dec 16 07:30:14 2011 -0800" }, "message": "Merge \"setActiveTrack and setBufferProvider can\u0027t fail\"" }, { "commit": "b87c068727a15a3d3f0bfdcb758c76a097f5e869", "tree": "49768247c538c838564c4546bc55cb3df572b56f", "parents": [ "255adceb85bc23de61fb138ddb474852514b3b33", "1c48c3c61970527b97892ab6a2daae8eaac26964" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Dec 16 07:29:57 2011 -0800" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Fri Dec 16 07:29:57 2011 -0800" }, "message": "Merge \"Simplify enable/disable mixing\"" }, { "commit": "26fa039c3752eaaf74d1be53d9795f48e9f43de3", "tree": "cb76ba4c46c218fec35f88e47a963c93e0bb175b", "parents": [ "2a8ce907a57f30ffa336a024e09752794d08ec1a", "e0feee3da22beeffbd9357540e265f13b2119cbb" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Dec 15 16:16:55 2011 -0800" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Thu Dec 15 16:16:55 2011 -0800" }, "message": "Merge \"Use NULL not 0 for pointers\"" }, { "commit": "fba380a0b2c62684ce4272a05165965bae29d6a1", "tree": "d0a89a2c45aa09a838c5f93108a3be8f5a80d4e5", "parents": [ "eebeceec684a36222b4559e3157b0db04c0a67ed" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Dec 15 15:46:46 2011 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Dec 15 15:55:51 2011 -0800" }, "message": "setActiveTrack and setBufferProvider can\u0027t fail\n\nReturn void, not status_t, from setActiveTrack and setBufferProvider.\n\nThese methods returned status_t, but the callers never checked the\nreturn value. Since these aren\u0027t externally visible APIs, they now\nreturn void, and assert on bad input parameters.\n\nChange-Id: I530ed29484596ae41e8659826ca425149c51c2a1\n" }, { "commit": "1c48c3c61970527b97892ab6a2daae8eaac26964", "tree": "24fed87db69fcce3fb6f3b01bb72501445102c04", "parents": [ "eebeceec684a36222b4559e3157b0db04c0a67ed" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Dec 15 14:54:01 2011 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Dec 15 15:00:28 2011 -0800" }, "message": "Simplify enable/disable mixing\n\nThe MIXING enum isn\u0027t needed, and now returns void instead of status_t.\n\nChange-Id: Ibe4ec24081d75ad4ab78b9c7191fc9077959c4e9\n" }, { "commit": "e0feee3da22beeffbd9357540e265f13b2119cbb", "tree": "6b4d02fc40687bbc8b463acd659e147d084f0883", "parents": [ "eebeceec684a36222b4559e3157b0db04c0a67ed" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Tue Dec 13 11:53:26 2011 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Thu Dec 15 09:18:17 2011 -0800" }, "message": "Use NULL not 0 for pointers\n\nChange-Id: Iab3f9abbdab617dc5a599e657ec46a0b0a002eef\n" }, { "commit": "42968939dfce0954d6540011199045ec4ed7de80", "tree": "0e297b59294db0688bab53cad567bb235f3ec4df", "parents": [ "a06a9a50b37d60e9c43c9de9f8ea3a8649cd5691", "c5ac4cb3a5124860ccfc7e4ff66251c55a5595ca" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Dec 14 17:35:36 2011 -0800" }, "committer": { "name": "Android (Google) Code Review", "email": "android-gerrit@google.com", "time": "Wed Dec 14 17:35:36 2011 -0800" }, "message": "Merge \"Fix indentation and whitespace\"" }, { "commit": "0cfd8231e4c489392809bf44c174315df2690145", "tree": "37cf11873d8a71cd563fbe933dc7daab85406283", "parents": [ "eebeceec684a36222b4559e3157b0db04c0a67ed" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Tue Dec 13 11:58:23 2011 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Dec 14 17:25:28 2011 -0800" }, "message": "AudioMixer uninitialized simple fields\n\nChange-Id: I47e3849f048d4d990c9634f9c8a2ca2de0339e93\n" }, { "commit": "c5ac4cb3a5124860ccfc7e4ff66251c55a5595ca", "tree": "8b5320023ea729a043b00157e5ba528b4276e700", "parents": [ "eebeceec684a36222b4559e3157b0db04c0a67ed" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Mon Dec 12 09:05:55 2011 -0800" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Wed Dec 14 16:54:05 2011 -0800" }, "message": "Fix indentation and whitespace\n\nUse git diff -w to verify.\n\nChange-Id: Ib65be0a1ecf65d6cad516110604e3855bf68a638\n" }, { "commit": "3856b090cd04ba5dd4a59a12430ed724d5995909", "tree": "a24e4c98fa6049fd8085826be838000f9a67e39b", "parents": [ "1d2acaffde56ad79e6e96f228d7857863462397c" ], "author": { "name": "Steve Block", "email": "steveblock@google.com", "time": "Thu Oct 20 11:56:00 2011 +0100" }, "committer": { "name": "Steve Block", "email": "steveblock@google.com", "time": "Wed Oct 26 09:57:54 2011 +0100" }, "message": "Rename (IF_)LOGV(_IF) to (IF_)ALOGV(_IF) DO NOT MERGE\n\nSee https://android-git.corp.google.com/g/#/c/143865\n\nBug: 5449033\nChange-Id: I0122812ed6ff6f5b59fe4a43ab8bff0577adde0a\n" } ], "next": "0d255b2d9061ba31f13ada3fc0f7e51916407176" }