)]}' { "log": [ { "commit": "7dd39723b34c8378fc5eabb4d4ccacf32f55ffe2", "tree": "222de47bcb84931d714d250fe51d3249771edc18", "parents": [ "61d4a093f4b4041b145fbd7a3ab5ec04679f87d9" ], "author": { "name": "Ytai Ben-Tsvi", "email": "ytai@google.com", "time": "Thu Sep 05 15:14:30 2019 -0700" }, "committer": { "name": "Ytai Ben-Tsvi", "email": "ytai@google.com", "time": "Fri Sep 13 10:59:51 2019 -0700" }, "message": "Improve visibility of IMemory security risks\n\nThis change renames the IMemory raw pointer accessors to\nunsecure*() to make it apparent to coders and code reviewers\nthat the returned buffer may potentially be shared with\nuntrusted processes, who may, after the fact, attempt to\nread and/or modify the contents. This may lead to hard to\nfind security bugs and hopefully the rename makes it harder\nto forget.\n\nThe change also attempts to fix all the callsites to make\neverything build correctly, but in the processes, wherever the\ncallsite code was not obviously secure, I added a TODO requesting\nthe owners to either document why it\u0027s secure or to change the\ncode. Apologies in advance to the owners if there are some false\npositives here - I don\u0027t have enough context to reason about all\nthe different callsites.\n\nTest: Completely syntactic change. Made sure code still builds.\nChange-Id: I5fb99aa797c488406083178a6b05355d98710d3b\n" }, { "commit": "a04f6995de2e469cfb3164d88cf8fe54701c9124", "tree": "0d5d546eee3afa8e7b85d7c1099690ede12e22c5", "parents": [ "c17c28aac0fa31be3fc4068da5e2f95731e7c361" ], "author": { "name": "Santhosh Behara", "email": "santhoshbehara@codeaurora.org", "time": "Wed Nov 04 13:20:52 2015 -0800" }, "committer": { "name": "Robert Shih", "email": "robertshih@google.com", "time": "Mon Feb 13 16:49:29 2017 -0800" }, "message": "libmedia: add NULL check before accessing source and destination buffers.\n\nIMemory can return a NULL pointer or the destination buffer for readAt can\nbe NULL. Check for NULL and report error.\n\nAuthor: Shivaprasad Hongal \u003cshongal@codeaurora.org\u003e\n\nChange-Id: I6df9275f2eb9a6e1c2641d084d713b73737d68d7\n" }, { "commit": "090ef604f81447eab4aa0a5b45d6307482573560", "tree": "6eb6530aab79b1cdc543ef16650be519db449e37", "parents": [ "cdf7931424583ff20a754999216041fb46287cb3" ], "author": { "name": "Chih-Hung Hsieh", "email": "chh@google.com", "time": "Wed Apr 27 10:39:54 2016 -0700" }, "committer": { "name": "Chih-Hung Hsieh", "email": "chh@google.com", "time": "Wed Apr 27 10:55:42 2016 -0700" }, "message": "Fix google-explicit-constructor warnings.\n\nBug: 28341362\nChange-Id: I625fbab25f16282c2ea929cd16283d9d146fa17b\n" }, { "commit": "61c83317f1c8f18fd86afe0c776d16933816a83a", "tree": "0035632ea3ff8222d1be7630ec0cecb4e909c222", "parents": [ "3fc792fe36b0b9100f74185665221b37f650ff65" ], "author": { "name": "Alex Klyubin", "email": "klyubin@google.com", "time": "Thu Jun 18 12:39:44 2015 -0700" }, "committer": { "name": "Alex Klyubin", "email": "klyubin@google.com", "time": "Thu Jun 18 12:39:44 2015 -0700" }, "message": "readAt can return negative values (error codes).\n\nThis fixes the regression introduced in\n59cea2616269f34b1f3d046995efd8da42cd5549 due to which MediaPlayer\ntreated all error codes returned by MediaHTTPConnection as\nERROR_OUT_OF_RANGE.\n\nThe regression was caused by accidentally converting negative values\n(which represent error codes) returned by MediaHTTPConnection to very\nlarge positive ones (which represent length of data received).\n\nBug: 21922241\nChange-Id: I1b4592b5fec724aac1ba6c1ff8fdabcba56bcd2d\n" }, { "commit": "8cecf014ad5c62b072fad8fc24a140e8ee294f62", "tree": "21b05abf1e9d7fb1d87369c77ed31f220b6280c1", "parents": [ "ad9ef61e770c0751a9983aa5c9844dfeb9ed665b" ], "author": { "name": "Marco Nelissen", "email": "marcone@google.com", "time": "Thu Jun 11 14:08:44 2015 -0700" }, "committer": { "name": "Marco Nelissen", "email": "marcone@google.com", "time": "Thu Jun 11 14:08:44 2015 -0700" }, "message": "Return correct error code from IMediaHttpConnection\n\nIt returns a boolean, not a status_t\n\nBug: 21654826\nChange-Id: Id364a90598c5cf0bb567b5b25bbc9b7c73412760\n" }, { "commit": "831352e926c2896996df285b343cc06f39053499", "tree": "c204a60d9d2fd65633615565ceaaa4efab3323c6", "parents": [ "5603d28707ef0f19b2b915756809424698e93d9c", "d7446564c3e469aea1bba5460ff1fb9441f9fc09" ], "author": { "name": "Marco Nelissen", "email": "marcone@google.com", "time": "Thu May 07 00:49:59 2015 +0000" }, "committer": { "name": "Android Git Automerger", "email": "android-git-automerger@android.com", "time": "Thu May 07 00:49:59 2015 +0000" }, "message": "am d7446564: am 1e5670ab: am 296dc670: am d8e41553: am bd28ac74: am 59cea261: Add some sanity checks\n\n* commit \u0027d7446564c3e469aea1bba5460ff1fb9441f9fc09\u0027:\n Add some sanity checks\n" }, { "commit": "59cea2616269f34b1f3d046995efd8da42cd5549", "tree": "c2f165a35105142d715f36876ededb0311360938", "parents": [ "eb204f82afd5519eb544bf8bee692e7152820c3b" ], "author": { "name": "Marco Nelissen", "email": "marcone@google.com", "time": "Mon Apr 20 11:08:59 2015 -0700" }, "committer": { "name": "Marco Nelissen", "email": "marcone@google.com", "time": "Wed Apr 22 10:14:35 2015 -0700" }, "message": "Add some sanity checks\n\nBug: 19400722\nChange-Id: Ib3afdf73fd4647eeea5721c61c8b72dbba0647f6\n" }, { "commit": "d2027336b45f524a196403d351ec317782793792", "tree": "88b2d938d53d20c4caa1cd82a69d52dbcdbdaefd", "parents": [ "6991ed25d8b5c2f75325ccd7cc522762da6f2b09" ], "author": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Fri Mar 20 08:59:18 2015 -0700" }, "committer": { "name": "Glenn Kasten", "email": "gkasten@google.com", "time": "Mon Mar 23 08:02:50 2015 -0700" }, "message": "Whitespace\n\nChange-Id: I4640be948ad3caff0eb7525991398a1353e4bfe6\n" }, { "commit": "19a9fef6d2970a615f4f33025f9141e44b7c9f34", "tree": "7bf51af96ccdaa8a770e43795033e3da6a52df57", "parents": [ "0517e0b6e4a86f34388631416dd6b3b4fcb91ff8" ], "author": { "name": "Marco Nelissen", "email": "marcone@google.com", "time": "Thu Feb 27 13:20:07 2014 -0800" }, "committer": { "name": "Marco Nelissen", "email": "marcone@google.com", "time": "Thu Feb 27 13:20:07 2014 -0800" }, "message": "Don\u0027t crash on remote read error, just return\n\nChange-Id: I35a2af255f55e008d64142ed0eceb6e83473d630\n" }, { "commit": "c9c7e25a4b1c34439fb365f6cfbef063884566cc", "tree": "43162dd8e8867d610a3791c6ca2b2efcf4875f69", "parents": [ "3a005b3b19b750afe24577ae322aff4602ca2740" ], "author": { "name": "Marco Nelissen", "email": "marcone@google.com", "time": "Fri Feb 21 12:01:23 2014 -0800" }, "committer": { "name": "Marco Nelissen", "email": "marcone@google.com", "time": "Fri Feb 21 12:32:11 2014 -0800" }, "message": "Add method to get redirected Uri\n\nChange-Id: Id8aac1077c3de1bb1f58bfcfcca93d685abe9b79\n" }, { "commit": "1b86fe063badb5f28c467ade39be0f4008688947", "tree": "d88660112d407540184ad8e1292ed8aa98fae317", "parents": [ "5ce88270eb2d41462de8c4155673b802b2ca48cb" ], "author": { "name": "Andreas Huber", "email": "andih@google.com", "time": "Wed Jan 29 11:13:26 2014 -0800" }, "committer": { "name": "Andreas Huber", "email": "andih@google.com", "time": "Tue Feb 04 15:11:53 2014 -0800" }, "message": "FINAL ATTEMPT: HTTP services are now provided from JAVA and made available to media code\n\nChange-Id: I9f74a86e70422187c9cf0ca1318a29019700192d\n" } ] }