)]}'
{
  "commit": "6b09ff9d787911b0b46a4d286e68f1f84e8b0b94",
  "tree": "933ef684e8881d7d9b5dbbcc60694b8f36815fea",
  "parents": [
    "4f4aeeabc061826376c9a72b4714d062664999ea"
  ],
  "author": {
    "name": "Bryan Boatright",
    "email": "b1@omega71.com",
    "time": "Thu Feb 07 00:14:58 2008 -0800"
  },
  "committer": {
    "name": "Linus Torvalds",
    "email": "torvalds@woody.linux-foundation.org",
    "time": "Thu Feb 07 08:42:23 2008 -0800"
  },
  "message": "drivers/edac: pci: broken parity regression\n\nUsing the EDAC code in kernel.org kernel version 2.6.23.8 I am seeing the\nfollowing problem:\n\n    In the kernel there is a pci device attribute located in sysfs that is\n    checked by the EDAC PCI scanning code. If that attribute is set,\n    PCI parity/error scannining is skipped for that device. The attribute\n    is:\n\n            broken_parity_status\n\n    as is located in /sys/devices/pci\u003cXXX\u003e/0000:XX:YY.Z directorys for\n    PCI devices.\n\nI don\u0027t think this check was actually implemented.  I have a misbehaved card\nthat reports a parity error every 1000 ms:\n\nNov 25 07:28:43 beta kernel: EDAC PCI: Master Data Parity Error on 0000:05:01.0\nNov 25 07:28:44 beta kernel: EDAC PCI: Master Data Parity Error on 0000:05:01.0\nNov 25 07:28:45 beta kernel: EDAC PCI: Master Data Parity Error on 0000:05:01.0\n\nSetting that card\u0027s broken_parity_status bit did not mask the error:\n\necho \"1\" \u003e /sys/bus/pci/devices/0000:05:01.0/broken_parity_status\n\nI looked through the EDAC code and did not readily see any reference to\nbroken_parity_status at all (which makes sense based on the behavior I am\nseeing).  I applied the following patch as a proof-of-concept and now EDAC\u0027s\nPCI parity error reporting behaves as documented:\n\nbryan\n\nGood regression find, bryan. It used to work. sigh.\nI added more logic to your patch, for more coverage of the error.\n\nDoug T\n\nSigned-off-by: Bryan Boatright \u003cb1@omega71.com\u003e\nSigned-off-by: Doug Thompson \u003cdougthompson@xmisson.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "5b075da9914511ffebcb3f2de1362988957a9c3c",
      "old_mode": 33188,
      "old_path": "drivers/edac/edac_pci_sysfs.c",
      "new_id": "71c3195d3704428fc16a3f69848d739f0a8d723e",
      "new_mode": 33188,
      "new_path": "drivers/edac/edac_pci_sysfs.c"
    }
  ]
}
