)]}'
{
  "commit": "102eb97564c73ea73645b38599c5cbe6f54b030c",
  "tree": "c054ffd980f35d14c569204fc4dcd995544817d3",
  "parents": [
    "6291fe2abce4689d6ee7cbaea16692c79bf0d01b"
  ],
  "author": {
    "name": "Grant Likely",
    "email": "grant.likely@secretlab.ca",
    "time": "Wed Jul 23 21:29:55 2008 -0700"
  },
  "committer": {
    "name": "Linus Torvalds",
    "email": "torvalds@linux-foundation.org",
    "time": "Thu Jul 24 10:47:30 2008 -0700"
  },
  "message": "spi: make spi_board_info.modalias a char array\n\nCurrently, \u0027modalias\u0027 in the spi_device structure is a \u0027const char *\u0027.\nThe spi_new_device() function fills in the modalias value from a passed in\nspi_board_info data block.  Since it is a pointer copy, the new spi_device\nremains dependent on the spi_board_info structure after the new spi_device\nis registered (no other fields in spi_device directly depend on the\nspi_board_info structure; all of the other data is copied).\n\nThis causes a problem when dynamically propulating the list of attached\nSPI devices.  For example, in arch/powerpc, the list of SPI devices can be\npopulated from data in the device tree.  With the current code, the device\ntree adapter must kmalloc() a new spi_board_info structure for each new\nSPI device it finds in the device tree, and there is no simple mechanism\nin place for keeping track of these allocations.\n\nThis patch changes modalias from a \u0027const char *\u0027 to a fixed char array.\nBy copying the modalias string instead of referencing it, the dependency\non the spi_board_info structure is eliminated and an outside caller does\nnot need to maintain a separate spi_board_info allocation for each device.\n\nIf searched through the code to the best of my ability for any references\nto modalias which may be affected by this change and haven\u0027t found\nanything.  It has been tested with the lite5200b platform in arch/powerpc.\n\n[dbrownell@users.sourceforge.net: cope with linux-next changes: KOBJ_NAME_LEN obliterated, etc]\nSigned-off-by: Grant Likely \u003cgrant.likely@secretlab.ca\u003e\nSigned-off-by: David Brownell \u003cdbrownell@users.sourceforge.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "1771b2456bfaf8f60ab3d0fdfafdd443813b3138",
      "old_mode": 33188,
      "old_path": "drivers/spi/spi.c",
      "new_id": "ecca4a6a6f94a8b02e9d8143ae2be88d11bd00b5",
      "new_mode": 33188,
      "new_path": "drivers/spi/spi.c"
    },
    {
      "type": "modify",
      "old_id": "b9a76c9720844105eccc6fe89dc139dd54c8095e",
      "old_mode": 33188,
      "old_path": "include/linux/spi/spi.h",
      "new_id": "a9cc29d466535f64b7f3cccdcc25c5f43cd96a40",
      "new_mode": 33188,
      "new_path": "include/linux/spi/spi.h"
    }
  ]
}
