)]}'
{
  "commit": "1260f801b4e4ba7be200886b4a53d730de05ca19",
  "tree": "319a68125252ac50df21b6e84cc1131c96e60d6f",
  "parents": [
    "c36f19e02a96488f550fdb678c92500afca3109b"
  ],
  "author": {
    "name": "David Howells",
    "email": "dhowells@redhat.com",
    "time": "Thu Aug 04 11:50:01 2005 +0100"
  },
  "committer": {
    "name": "Linus Torvalds",
    "email": "torvalds@g5.osdl.org",
    "time": "Thu Aug 04 08:20:47 2005 -0700"
  },
  "message": "[PATCH] Keys: Fix key management syscall interface bugs\n\nThis fixes five bugs in the key management syscall interface:\n\n (1) add_key() returns 0 rather than EINVAL if the key type is \"\".\n\n     Checking the key type isn\u0027t \"\" should be left to lookup_user_key().\n\n (2) request_key() returns ENOKEY rather than EPERM if the key type begins\n     with a \".\".\n\n     lookup_user_key() can\u0027t do this because internal key types begin with a\n     \".\".\n\n (3) Key revocation always returns 0, even if it fails.\n\n (4) Key read can return EAGAIN rather than EACCES under some circumstances.\n\n     A key is permitted to by read by a process if it doesn\u0027t grant read\n     access, but it does grant search access and it is in the process\u0027s\n     keyrings. That search returns EAGAIN if it fails, and this needs\n     translating to EACCES.\n\n (5) request_key() never adds the new key to the destination keyring if one is\n     supplied.\n\n     The wrong macro was being used to test for an error condition: PTR_ERR()\n     will always return true, whether or not there\u0027s an error; this should\u0027ve\n     been IS_ERR().\n\nSigned-Off-By: David Howells \u003cdhowells@redhat.com\u003e\nSigned-Off-By: Linus Torvalds \u003ctorvalds@osdl.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "fea262860ea01656dbe7514b4b4a301ca47424b6",
      "old_mode": 33188,
      "old_path": "security/keys/keyctl.c",
      "new_id": "a6516a64b297898923ca760e2e3b779880021c30",
      "new_mode": 33188,
      "new_path": "security/keys/keyctl.c"
    },
    {
      "type": "modify",
      "old_id": "dfcd983af1fd88405d28c7af2a002e3e141759e5",
      "old_mode": 33188,
      "old_path": "security/keys/request_key.c",
      "new_id": "90c1506d007cc219c17ebd9c571d94b9c6a58ed9",
      "new_mode": 33188,
      "new_path": "security/keys/request_key.c"
    }
  ]
}