)]}'
{
  "commit": "18e3ee2cf96adf072deeb291eed670f2c23bb2fc",
  "tree": "50435796fa5d08795e82138c39f50f2b11ec7055",
  "parents": [
    "3157183a90fdbd686f939d2f032b675f7e9983d6"
  ],
  "author": {
    "name": "Steve Hodgson",
    "email": "shodgson@solarflare.com",
    "time": "Thu Dec 02 13:46:55 2010 +0000"
  },
  "committer": {
    "name": "David S. Miller",
    "email": "davem@davemloft.net",
    "time": "Fri Dec 03 09:08:05 2010 -0800"
  },
  "message": "sfc: Fix event based MCDI completion and MC REBOOT/CMDDONE ordering issue\n\nThe mcfw *never* sends CMDDONE when rebooting. Changing this so that it always\nsends CMDDONE *before* REBOOT is easy on Siena, but it\u0027s not obvious that we\ncould guarantee to be able to implement this on future hardware.\n\nGiven this, I\u0027m less convinced that the protocol should be changed.\n\nTo reiterate the failure mode: The driver sees this:\n\n issue command\n receive REBOOT event\n\nWas that reboot event sent before the command was issued, or in\nresponse to the command? If the former then there will be a subsequent\nCMDDONE event, if the latter, then there will be no CMDDONE event.\n\nOptions to resolve this are:\n\n 1. REBOOT always completes an outstanding mcdi request, and we set\n    the credits count to ignore a subsequent CMDDONE event with\n    mismatching seqno.\n\n 2. REBOOT never completes an outstanding mcdi request. If there is\n    no CMDDONE event then we rely on the mcdi timeout code to complete\n    the outstanding request, incurring a 10s delay.\n\nI\u0027d argue that (2) is tidier, but that incurring a 10s delay is a little\nneedless. Let\u0027s go with (1).\n\nSigned-off-by: Ben Hutchings \u003cbhutchings@solarflare.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "e389ac6c214ff30b5b3f42ca506a34a9a782e9c4",
      "old_mode": 33188,
      "old_path": "drivers/net/sfc/mcdi.c",
      "new_id": "b716e827b291bca53dab4464543553c1cdaa9673",
      "new_mode": 33188,
      "new_path": "drivers/net/sfc/mcdi.c"
    }
  ]
}