)]}'
{
  "commit": "22e78fafbdf84883f70eb4944cf658fc23c4a1f4",
  "tree": "1b922f289e05f01d5c8d02427617cdb9bd66707c",
  "parents": [
    "6c6f57f3bee1e3c3d31b08a0161c435bfaeb77eb"
  ],
  "author": {
    "name": "Michael Halcrow",
    "email": "mhalcrow@us.ibm.com",
    "time": "Tue Oct 16 01:28:02 2007 -0700"
  },
  "committer": {
    "name": "Linus Torvalds",
    "email": "torvalds@woody.linux-foundation.org",
    "time": "Tue Oct 16 09:43:11 2007 -0700"
  },
  "message": "eCryptfs: kerneldoc fixes for crypto.c and keystore.c\n\nAndrew Morton wrote:\nFrom: mhalcrow@us.ibm.com \u003cmhalcrow@halcrow.austin.ibm.com\u003e\n\u003e \u003e +/**\n\u003e \u003e + * decrypt_passphrase_encrypted_session_key - Decrypt the session key\n\u003e \u003e + * with the given auth_tok.\n\u003e \u003e   *\n\u003e \u003e   * Returns Zero on success; non-zero error otherwise.\n\u003e \u003e   */\n\u003e\n\u003e That comment purports to be a kerneldoc-style comment.  But\n\u003e\n\u003e - kerneldoc doesn\u0027t support multiple lines on the introductory line\n\u003e   which identifies the name of the function (alas).  So you\u0027ll need to\n\u003e   overflow 80 cols here.\n\u003e\n\u003e - the function args weren\u0027t documented\n\u003e\n\u003e But the return value is!  People regularly forget to do that.  And\n\u003e they frequently forget to document the locking prerequisites and the\n\u003e permissible calling contexts (process/might_sleep/hardirq, etc)\n\u003e\n\u003e (please check all ecryptfs kerneldoc for this stuff sometime)\n\nThis patch cleans up some of the existing comments and makes a couple\nof line break tweaks. There is more work to do to bring eCryptfs into\nfull kerneldoc-compliance.\n\nSigned-off-by: Michael Halcrow \u003cmhalcrow@us.ibm.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "6051dbfad0d368817aa9a9ea992d22b1e0e15506",
      "old_mode": 33188,
      "old_path": "fs/ecryptfs/crypto.c",
      "new_id": "7aa2f48978dea92ca0842bc0edacf7afa34313b9",
      "new_mode": 33188,
      "new_path": "fs/ecryptfs/crypto.c"
    },
    {
      "type": "modify",
      "old_id": "778bdf9e0502df76f739fddee6a94afe8718c26f",
      "old_mode": 33188,
      "old_path": "fs/ecryptfs/keystore.c",
      "new_id": "e9cda7afe6be9498078bcb2c7630a01ec15bebb6",
      "new_mode": 33188,
      "new_path": "fs/ecryptfs/keystore.c"
    }
  ]
}
