)]}'
{
  "commit": "3689456b4bd36027022b3215eb2acba51cd0e6b5",
  "tree": "8233856d31d744feacf6d91b0fb7dbe7fbcf2803",
  "parents": [
    "ac15ee691fe84cb46cbd2497ddcb10e246f7ee47"
  ],
  "author": {
    "name": "Phillip Lougher",
    "email": "phillip@lougher.demon.co.uk",
    "time": "Tue Jan 25 15:07:34 2011 -0800"
  },
  "committer": {
    "name": "Linus Torvalds",
    "email": "torvalds@linux-foundation.org",
    "time": "Wed Jan 26 10:50:05 2011 +1000"
  },
  "message": "squashfs: fix use of uninitialised variable in zlib \u0026 xz decompressors\n\nFix potential use of uninitialised variable caused by recent\ndecompressor code optimisations.\n\nIn zlib_uncompress (zlib_wrapper.c) we have\n\n\tint zlib_err, zlib_init \u003d 0;\n\t...\n\tdo {\n\t\t...\n\t\t\tif (avail \u003d\u003d 0) {\n\t\t\t\toffset \u003d 0;\n\t\t\t\tput_bh(bh[k++]);\n\t\t\t\tcontinue;\n\t\t\t}\n\t\t...\n\t\tzlib_err \u003d zlib_inflate(stream, Z_SYNC_FLUSH);\n\t\t...\n\t} while (zlib_err \u003d\u003d Z_OK);\n\nIf continue is executed (avail \u003d\u003d 0) then the while condition will be\nevaluated testing zlib_err, which is uninitialised first time around the\nloop.\n\nFix this by getting rid of the \u0027if (avail \u003d\u003d 0)\u0027 condition test, this\nedge condition should not be being handled in the decompressor code, and\ninstead handle it generically in the caller code.\n\nSimilarly for xz_wrapper.c.\n\nIncidentally, on most architectures (bar Mips and Parisc), no\nuninitialised variable warning is generated by gcc, this is because the\nwhile condition test on continue is optimised out and not performed\n(when executing continue zlib_err has not been changed since entering\nthe loop, and logically if the while condition was true previously, then\nit\u0027s still true).\n\nSigned-off-by: Phillip Lougher \u003cphillip@lougher.demon.co.uk\u003e\nReported-by: Jesper Juhl \u003cjj@chaosbits.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2fb2882f0fa7b1a1b656f68596ec740d10650cd9",
      "old_mode": 33188,
      "old_path": "fs/squashfs/block.c",
      "new_id": "8ab48bc2fa7d4f17f75288ac64544b9894f15dfc",
      "new_mode": 33188,
      "new_path": "fs/squashfs/block.c"
    },
    {
      "type": "modify",
      "old_id": "856756ca5ee493e29631b8e8108119c3268f5c80",
      "old_mode": 33188,
      "old_path": "fs/squashfs/xz_wrapper.c",
      "new_id": "c4eb400182564c13728fc88f95edf6db294eb2ac",
      "new_mode": 33188,
      "new_path": "fs/squashfs/xz_wrapper.c"
    },
    {
      "type": "modify",
      "old_id": "818a5e063faf37c03c189c8043ec470f52024575",
      "old_mode": 33188,
      "old_path": "fs/squashfs/zlib_wrapper.c",
      "new_id": "4661ae2b1cec8040adcadc4018deb63735309f92",
      "new_mode": 33188,
      "new_path": "fs/squashfs/zlib_wrapper.c"
    }
  ]
}
