)]}'
{
  "commit": "39cbb602b543e477df71dca84b5b2e36f8bd29fc",
  "tree": "70639084b6a04ce428cecbaa5fa30c2d71d5ff33",
  "parents": [
    "7cb7beb31aa3d941833b6a6e553687422c31e4b6"
  ],
  "author": {
    "name": "Alan D. Brunelle",
    "email": "alan.brunelle@hp.com",
    "time": "Fri Aug 07 12:01:08 2009 -0400"
  },
  "committer": {
    "name": "Jens Axboe",
    "email": "jens.axboe@oracle.com",
    "time": "Wed Aug 12 18:50:08 2009 +0200"
  },
  "message": "Remove double removal of blktrace directory\n\ncommit fd51d251e4cdb21f68e9dbc4336514d64a105a79\nAuthor: Stefan Raspl \u003craspl@linux.vnet.ibm.com\u003e\nDate:   Tue May 19 09:59:08 2009 +0200\n\n    blktrace: remove debugfs entries on bad path\n\nadded in an explicit invocation of debugfs_remove for bt-\u003edir, in\nblk_remove_buf_file_callback we are also getting the directory removed. On\noccasion I am seeing memory corruption that I have bisected down to\nthis commit. [The testing involves a (long) series of I/O benchmarks\nwith blktrace invoked around the actual runs.] I believe that this\ncommitted patch is correct, but the problem actually lies in the code\nin blk_remove_buf_file_callback.\n\nWith this patch I am able to consistently get complete runs whereas\npreviously I could not get a single run to complete.\n\nThe first part of the patch simply moves the debugfs_remove below the\nrelay_close: the relay_close call will remove files under bt-\u003edir, and\nso we should not remove the directory until all the files we created\nhave been removed. (Note: This is not sufficient to fix the problem -\nthe file system code has ref counts on the directoy, so our invocation\ndoes not cause the directory to actually be removed. Nonetheless, we\nshould not rely upon that feature.)\n\nSigned-off-by: Alan D. Brunelle \u003calan.brunelle@hp.com\u003e\nSigned-off-by: Jens Axboe \u003cjens.axboe@oracle.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "1090b0aed9bac6135d359e0cb07317085e6145d6",
      "old_mode": 33188,
      "old_path": "kernel/trace/blktrace.c",
      "new_id": "7a34cb563fec4cef90ebbf1d6bcc71dd4af4fef4",
      "new_mode": 33188,
      "new_path": "kernel/trace/blktrace.c"
    }
  ]
}
