)]}'
{
  "commit": "3ae91c21dd29e413f4111978152c14061f0984b0",
  "tree": "64b4867e2ee81180661c287fa38d068975d1d37f",
  "parents": [
    "817b33d38f81c8736d39283c35c886ae4668f1af"
  ],
  "author": {
    "name": "Paul Mundt",
    "email": "lethal@linux-sh.org",
    "time": "Thu Oct 01 15:43:54 2009 -0700"
  },
  "committer": {
    "name": "Linus Torvalds",
    "email": "torvalds@linux-foundation.org",
    "time": "Thu Oct 01 16:11:11 2009 -0700"
  },
  "message": "module: fix up CONFIG_KALLSYMS\u003dn build.\n\nStarting from commit 4a4962263f07d14660849ec134ee42b63e95ea9a \"reduce\nsymbol table for loaded modules (v2)\", the kernel/module.c build is broken\nwith CONFIG_KALLSYMS disabled.\n\n  CC      kernel/module.o\nkernel/module.c:1995: warning: type defaults to \u0027int\u0027 in declaration of \u0027Elf_Hdr\u0027\nkernel/module.c:1995: error: expected \u0027;\u0027, \u0027,\u0027 or \u0027)\u0027 before \u0027*\u0027 token\nkernel/module.c: In function \u0027load_module\u0027:\nkernel/module.c:2203: error: \u0027strmap\u0027 undeclared (first use in this function)\nkernel/module.c:2203: error: (Each undeclared identifier is reported only once\nkernel/module.c:2203: error: for each function it appears in.)\nkernel/module.c:2239: error: \u0027symoffs\u0027 undeclared (first use in this function)\nkernel/module.c:2239: error: implicit declaration of function \u0027layout_symtab\u0027\nkernel/module.c:2240: error: \u0027stroffs\u0027 undeclared (first use in this function)\nmake[1]: *** [kernel/module.o] Error 1\nmake: *** [kernel/module.o] Error 2\n\nThere are three different issues:\n\n    - layout_symtab() takes a const Elf_Ehdr\n\n    - layout_symtab() needs to return a value\n\n    - symoffs/stroffs/strmap are referenced by the load_module() code\n      despite being ifdefed out, which seems unnecessary given the noop\n      behaviour of layout_symtab()/add_kallsyms() in the case of\n      CONFIG_KALLSYMS\u003dn.\n\nSigned-off-by: Paul Mundt \u003clethal@linux-sh.org\u003e\nAcked-by: Jan Beulich \u003cjbeulich@novell.com\u003e\nAcked-by: Rusty Russell \u003crusty@rustcorp.com.au\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "fe748a86d452030b8d44fcb7731c1badeb93c33c",
      "old_mode": 33188,
      "old_path": "kernel/module.c",
      "new_id": "8b7d8805819d07d998467db967c777c04021ec9e",
      "new_mode": 33188,
      "new_path": "kernel/module.c"
    }
  ]
}