)]}'
{
  "commit": "5ac24697699b394cdebac0a2329ce3af247d6a3b",
  "tree": "6c60f82870321757f2b354fb2562769d77467fdf",
  "parents": [
    "14e0a193209aeea810ad3d66388f422dc79c5b40"
  ],
  "author": {
    "name": "Alan Cox",
    "email": "alan@lxorguk.ukuu.org.uk",
    "time": "Tue Oct 03 01:14:23 2006 -0700"
  },
  "committer": {
    "name": "Linus Torvalds",
    "email": "torvalds@g5.osdl.org",
    "time": "Tue Oct 03 08:04:08 2006 -0700"
  },
  "message": "[PATCH] ide: backport piix fixes from libata into the legacy driver\n\nThere are three flags being set by default by the PIIX driver for speeds \u003e\nPIO 1, and one not being cleared properly on fallback to PIO0.  The most\nimportant one is the prefetch/post write control which only works for ATA\nand can do bad things with ATAPI.\n\nThe patch does its best to set the flags correctly for drivers/ide.  Its\nnot 100% perfect but its closer than the original.  100% perfect requires\nproper IORDY handling but this isn\u0027t critical (and its not right in libata\neither ..  yet)\n\nSergei Shtylyov \u003csshtylyov@ru.mvista.com\u003e said:\n\n\u003e +\t\t\t\t\t{ 0, 0 },\n\u003e +\t\t\t\t\t{ 0, 0 },\n\u003e +\t\t\t\t\t{ 1, 0 },\n\u003e +\t\t\t\t\t{ 2, 1 },\n\u003e +\t\t\t\t\t{ 2, 3 }, };\n\u003e\n\u003e  \tpio \u003d ide_get_best_pio_mode(drive, pio, 5, NULL);\n\n    BTW, there\u0027s quite obvious error here which leads to access outside of\ntimings[] if somebody passes PIO mode 5 (or autotuning code finds out that\ndrive supports PIO mode 5). Could have been fixed while at it... Those drives\nshould be rare, though...\n\n\u003e +\t\t}\n\u003e  \t\tmaster_data \u003d master_data | (timings[pio][0] \u003c\u003c 12) | (timings[pio][1] \u003c\u003c 8);\n\u003e  \t}\n\u003e  \tpci_write_config_word(dev, master_port, master_data);\n\n    Actually, there\u0027s one more serious issue with piix_tune_drive() -- it\ndoesn\u0027t actually set the drive\u0027s own transfer mode.\n\nSigned-off-by: Alan Cox \u003calan@redhat.com\u003e\nCc: Sergei Shtylyov \u003csshtylyov@ru.mvista.com\u003e\nCc: Bartlomiej Zolnierkiewicz \u003cB.Zolnierkiewicz@elka.pw.edu.pl\u003e\nSigned-off-by: Andrew Morton \u003cakpm@osdl.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@osdl.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "eb5bab1890cd1d484b553597e0ced72962da8f1b",
      "old_mode": 33188,
      "old_path": "drivers/ide/pci/piix.c",
      "new_id": "cdc3aab9ebcbc46676c76f6e5569f13eb214505a",
      "new_mode": 33188,
      "new_path": "drivers/ide/pci/piix.c"
    }
  ]
}