)]}'
{
  "commit": "6c1b7f680dd4f550fa6f91f148cc6fa2c4bd0737",
  "tree": "948651742b6fcff5079d555173b60584afb7682d",
  "parents": [
    "aa94fbd5ccd840c8ab26d02439ec799b03a72547"
  ],
  "author": {
    "name": "Gerald Schaefer",
    "email": "gerald.schaefer@de.ibm.com",
    "time": "Thu Oct 02 14:50:16 2008 -0700"
  },
  "committer": {
    "name": "Linus Torvalds",
    "email": "torvalds@linux-foundation.org",
    "time": "Thu Oct 02 15:53:13 2008 -0700"
  },
  "message": "memory hotplug: missing zone-\u003elock in test_pages_isolated()\n\n__test_page_isolated_in_pageblock() in mm/page_isolation.c has a comment\nsaying that the caller must hold zone-\u003elock. But the only caller of that\nfunction, test_pages_isolated(), does not hold zone-\u003elock and the lock is\nalso not acquired anywhere before. This patch adds the missing zone-\u003elock\nto test_pages_isolated().\n\nWe reproducibly run into BUG_ON(!PageBuddy(page)) in __offline_isolated_pages()\nduring memory hotplug stress test, see trace below. This patch fixes that\nproblem, it would be good if we could have it in 2.6.27.\n\nkernel BUG at /home/autobuild/BUILD/linux-2.6.26-20080909/mm/page_alloc.c:4561!\nillegal operation: 0001 [#1] PREEMPT SMP\nModules linked in: dm_multipath sunrpc bonding qeth_l3 dm_mod qeth ccwgroup vmur\nCPU: 1 Not tainted 2.6.26-29.x.20080909-s390default #1\nProcess memory_loop_all (pid: 10025, task: 2f444028, ksp: 2b10dd28)\nKrnl PSW : 040c0000 801727ea (__offline_isolated_pages+0x18e/0x1c4)\n R:0 T:1 IO:0 EX:0 Key:0 M:1 W:0 P:0 AS:0 CC:0 PM:0\nKrnl GPRS: 00000000 7e27fc00 00000000 7e27fc00\n 00000000 00000400 00014000 7e27fc01\n 00606f00 7e27fc00 00013fe0 2b10dd28\n 00000005 80172662 801727b2 2b10dd28\nKrnl Code: 801727de: 5810900c l %r1,12(%r9)\n 801727e2: a7f4ffb3 brc 15,80172748\n 801727e6: a7f40001 brc 15,801727e8\n \u003e801727ea: a7f4ffbc brc 15,80172762\n 801727ee: a7f40001 brc 15,801727f0\n 801727f2: a7f4ffaf brc 15,80172750\n 801727f6: 0707 bcr 0,%r7\n 801727f8: 0017 unknown\nCall Trace:\n([\u003c0000000000172772\u003e] __offline_isolated_pages+0x116/0x1c4)\n [\u003c00000000001953a2\u003e] offline_isolated_pages_cb+0x22/0x34\n [\u003c000000000013164c\u003e] walk_memory_resource+0xcc/0x11c\n [\u003c000000000019520e\u003e] offline_pages+0x36a/0x498\n [\u003c00000000001004d6\u003e] remove_memory+0x36/0x44\n [\u003c000000000028fb06\u003e] memory_block_change_state+0x112/0x150\n [\u003c000000000028ffb8\u003e] store_mem_state+0x90/0xe4\n [\u003c0000000000289c00\u003e] sysdev_store+0x34/0x40\n [\u003c00000000001ee048\u003e] sysfs_write_file+0xd0/0x178\n [\u003c000000000019b1a8\u003e] vfs_write+0x74/0x118\n [\u003c000000000019b9ae\u003e] sys_write+0x46/0x7c\n [\u003c000000000011160e\u003e] sysc_do_restart+0x12/0x16\n [\u003c0000000077f3e8ca\u003e] 0x77f3e8ca\n\nSigned-off-by: Gerald Schaefer \u003cgerald.schaefer@de.ibm.com\u003e\nAcked-by: KAMEZAWA Hiroyuki \u003ckamezawa.hiroyu@jp.fujitsu.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "c69f84fe038d8b725b8639aae0fd88151206b515",
      "old_mode": 33188,
      "old_path": "mm/page_isolation.c",
      "new_id": "b70a7fec1ff6c3a4aa2c210215185b31085c8f4d",
      "new_mode": 33188,
      "new_path": "mm/page_isolation.c"
    }
  ]
}
